On 2013-12-10 18:27 +0000 Martin Wimpress wrote:
<a great application> Regards, Martin.
Hi, That is a very nice application. It leaves no doubt concerning your skill and dedication (assuming that it's all true... Balló left carrying rubber gloves, so I expect that he was thorough in vetting you). Having someone from upstream maintain the MATE ecosystem would ensure a great user experience, and you are clearly capable of maintaining the packages in a repo. Your PKGBUILDs look good overall but I noticed two things. The first is the absence of quoted variables (e.g $srcdir), but you mentioned that you wrote a script to generate PKGBUILDs so perhaps that is a single, central fault? The second is the absence of "prepare" functions. There are numerous packages that modify existing source files in the "build" and/or "package" functions (e.g. several replace "python" with "python2"). All such modifications should be done in a separate "prepare" function when possible. Beyond that there were just a few niggles. For example, I wonder why you check if the CARCH variable is empty in the brother-mfc7360n-lpr package [1]. The "arch" array restricts available architectures to x86_64 and i686, so the warning doesn't make sense to me. There are also some apparently inherited PKGBUILD issues, e.g. the missing package function in nullmailer [2] but I presume those will be fixed whenever the next update happens. Regards, Xyne Btw, if anyone is interested, I have added a "maintainer" option to pbget because I wanted to grep all of the PKGBUILDs (e.g. $ pbget --maintainer flexiondotorg; grep -r --color -C 3 sed). [1] https://aur.archlinux.org/packages/br/brother-mfc7360n-lpr/PKGBUILD [2] https://aur.archlinux.org/packages/nullmailer/