Hi, On Tue, Sep 05, 2017 at 05:33:09PM +0200, Levente Polyak wrote:
- test cases could be run via tox, therefor all py2+3 dependencies should be added to checkdepends and tox be invoked
Running package tests via tox sounds like a bad idea. Tox creates a Python virtualenv[1] and installs all needed dependencies in there. That means: - If there's something packaged in a wrong way, you're not going to notice (because tox just tests the sources). - If there's a dependency missing, you're not going to notice (because tox installs it for you, according to the tox.ini). Note that also means tox is the only checkdepends actually needed. - If there's a version mismatch in a dependency between what Archlinux packages and what upstream needs, you're not going to notice (same reason as above). In summary, running tests via tox really doesn't test anything at all, assuming that upstream's tests aren't broken. It's whole job is to abstract over platform differences, while in a package, you want to test for exactly those platform differences. Florian [1] https://virtualenv.pypa.io/en/stable/ -- https://www.qutebrowser.org | me@the-compiler.org (Mail/XMPP) GPG: 916E B0C8 FD55 A072 | https://the-compiler.org/pubkey.asc I love long mails! | https://email.is-not-s.ms/