On 3/22/23 22:34, Anton Hvornum wrote:
Hi,
Actually this is a package you co-maintain, any other packages you have maintained in the AUR? [1]
It's hard get a feel about your packaging history without any examples to look at. It's a valid question, and my response would be that I don't think my AUR-packaging experience is my super power yet (or at least nothing to brag about). If anything it's my involvement with developing Arch Linux tooling,
On 3/22/23 19:37, Jelle van der Waa wrote: participate and being involved in projects[1][2][3][4][5][6][7][8][9][10] and helping the community. Those are what made me to apply for a TU role.
I have a deep rooted willingness to learn if given the opportunity and I've seen the need and calling from people to help with orphaned packages and every now and then packages pop up that I use, love and would love to help out carry on the packaging of - but can't due to my current role. I see this as an opportunity to gently ease my way into it while still being very familiar with the Arch echo system and how a lot of the packages are packaged in general terms. I honestly also don't have many packages that I would need to put into AUR that I feel others would want or need.
As a person I'm a very "hands-on" person. I need practical reasons and examples for doings things - so co-maintaining packages would be the best way for me to learn and gradually shoulder more and more responsibilities. And I hope my involvement in packaging[11] and distributing archinstall releases[12] for the last 2 years (anniversary[13] coming up in the 1:st of April this year) would count for something. Not trying to apply or win sympathy points, but it has been a lot of work and I hope it counts for something.
I will mention that I have packaged a few personal projects on AUR >5 years ago:
* slimDHCP[14] (Was in AUR ~2018, but quality of the PKGBUILD was not the best) * slimDNS[15] (Also in AUR, a bit older than slimDHCP) * slimSMTP[16] (same here)
I think I had a few more but they've been deleted since long ago. Again, they're by no means production worthy examples and quite outdated frankly and I learned a lot back then and since.
[1] https://gitlab.archlinux.org/archlinux/archiso/-/merge_requests/251 [2] https://gitlab.archlinux.org/archlinux/mkinitcpio/mkinitcpio-archiso/-/merge... [3] https://gitlab.archlinux.org/archlinux/archiso/-/issues/65 [4] https://gitlab.archlinux.org/archlinux/mkinitcpio/mkinitcpio-archiso/-/merge... [5] https://gitlab.archlinux.org/archlinux/mkinitcpio/mkinitcpio-archiso/-/merge... [6] https://gitlab.archlinux.org/archlinux/repod/-/issues/14 [7] https://gitlab.archlinux.org/archlinux/repod/-/merge_requests/21 [8] https://github.com/Torxed/archoffline [9] https://github.com/archlinux/archweb/pulls?q=is%3Apr+author%3ATorxed [10] https://gitlab.archlinux.org/archlinux/archiso/-/merge_requests/294 [11] https://github.com/archlinux/archinstall/commits/master/PKGBUILD [12] https://github.com/archlinux/archinstall/releases [13] https://archlinux.org/news/installation-medium-with-installer/ [14] https://gist.github.com/Torxed/206a15e5d11b2252c696c32ed394caaf [15] https://gist.github.com/Torxed/5c872cf8b673afc74927cb31a1d4e5e5 [16] https://gist.github.com/Torxed/5a41155a0dd88d518c404e94b56a8a8a
[1] https://aur.archlinux.org/packages?K=Torxed&SeB=m
Greetings,
Jelle
All the best, //Anton
Hi Anton,
As there isn't much packages to review anymore, which is unfortunate, I'd like to ask if you can improve the only package you currently co-maintain in the AUR currently: archinstall-git.
I'd love to see it being upgraded to the latest python ecosystem standards using (PEP 517 and friends). Archinstall does have an updated build and install echosystem upstream as we use PEP 517 compliant tools[1]. I've been focusing outright on getting a release out so I haven't had time to push those changes during
On 3/26/23 13:43, Levente Polyak wrote: this discussion period to the AUR PKGBUILD, but these changes have been made in the upstream package PKGBUILD since long ago. I did take some time just now to update the AUR PKGBUILD.
Furthermore it lacks proper provides/conflicts declaration on the none -git named archinstall package itself (both provide/conflict the same meta declaration, but in terms of correctness it should always conflict on the none git pkgname).
I assumed (incorrectly?) that since both have 'provides' that point to 'python-archinstall' they detect the conflict automatically. Would 'conflicts=(python-archinstall-git)' be appropriate in the non -git package or should it be 'conflicts=(archinstall-git)' as the package is called 'archinstall-git' not 'python-archinstall-git'?
On top It lacks `git` as makedepends.
Thanks, that is fixed!
It should also provide a pkgver() function as documented in the packaging guidelines, currently different states would yield to the same pkgver which is not good.
This is now implemented in both PKGBUILD's as well, thank you! Just to shed some more info on the decisions during packaging. One change was to remove flit[1] and homogenizing to the pypa 'setuptools', 'build' and 'installer' toolings (which serves as reference implementations in my mind and should hopefully be more stable) as flit was causing sudden and unexpected issues. And we keep 'twine' for interacting with PyPi instead. We also made efforts ~1 year ago to make archinstall reproducible (was simple enough I think, thanks Dave (IIRC)!) Next up is to introduce our first dependency[2][3]. That change will be represented in the PKGBUILD once the python-pyparted is out of testing[2]. Thank you for your feedback btw, it's appreicated and served as a good reminder that the PKGBUILD in the AUR had not been updated to reflect the state of the PKGBUILD in the upstream GitHub repo[5]. I've strived to follow the Python package guidelines[4] as closely as I can and hope that's reflected in the PKGBUILD's now. [1] https://github.com/archlinux/archinstall/pull/1655 [2] https://archlinux.org/packages/community-testing/x86_64/python-pyparted/ [3] https://github.com/archlinux/archinstall/pull/1604 [4] https://wiki.archlinux.org/title/Python_package_guidelines [5] https://github.com/archlinux/archinstall/blob/master/PKGBUILD //Anton