On 13/04/12 04:16 AM, Ike Devolder wrote:
Op vrijdag 13 april 2012 18:00:08 schreef Allan McRae:
On 13/04/12 17:51, Connor Behan wrote:
How's this? The author of this signed message and the person who uploaded the key fingerprint to http://demohack.sourceforge.net/contact.html and http://mebitag.sourceforge.net/contact.html solemnly swears that he wrote the TU application that was just sent and hopes that you do not think less of him for being too absent-minded to sign emails! Hmm... barely acceptable, but we will let you away with it this time.
Anyway, I recognize your name and have no bad connotations with it, which is the only criterion I use for reviewing applications.
So, good luck!
Allan All looks pretty clean to me, i would do one suggestion start using the package function, i just checked some pkgbuilds randomly and did not see it in any of them. (this is not at all life threatening ;p) and you can remove the '|| return 1' since makepkg catches this nicely for some time now
Very true. I just updated 10 of my PKGBUILDs to make them not look like they were written 3 years ago. Will do more soon.