9 Sep
2011
9 Sep
'11
7:11 p.m.
On Mon, Sep 05, 2011 at 04:15:34PM -0400, keenerd wrote:
Looks good, you've got my vote.
Just to chip in 2 cents on the addinclude thing, does it offer any benefit over say
sed -i '1i #include <whatever>' foo.c
As Dave and I already mentioned on IRC, it *might* be useful if it would check for headers that are already included and check for correct ordering of includes. This is very hard to impossible to implement, though (and at least requires some C preprocessor to be involved). Given that addinclude seems to do nothing of the sort, -1 to using it anywhere in our PKGBUILDs. If anyone still wants to use it for the sake of convenience, feel free to apply it on a local copy of the source code and use diff(1) to create a patch.