On 13.11.23 at 8:56 (UTC+0100), Torsten Keßler wrote:
Hey Jakub,
I'm excited to see your application as a package maintainer! As we discussed in the chat a while ago, we always need help in maintaining HPC/ML packages.
Thanks! I will gladly offer my hands and hardware to help.
I did a review of your packages. High quality PKGBUILDs for important HPC libraries. Even with ROCm support. Very nice! One small remark: Package guidelines discourage the use of CMAKE_BUILD_TYPE=Release (see tnl-git and pastix).
Right, thanks for the note. I fixed it easily for pastix and it should also be fine for ginkgo-git, though I will need to check if some other issues popped up since the last time I built it from the develop branch... Which reminds me that I should also enable ROCm support in Ginkgo :-) For tnl-git, there is actually a difference between the Release and None build types, since the project adds the -O3 -DNDEBUG flags for the Release build. The -O3 may be arguably unnecessary, but omitting the -DNDEBUG would make the binaries veeery slooow. I could add -DNDEBUG to CXXFLAGS manually, but I'm not sure if that is better than CMAKE_BUILD_TYPE=Release. I should also disclose that I'm an upstream developer of this TNL project. This is where I find all the bugs in the nvcc compiler :-D Jakub