On Mon, 31 Jul 2017 14:16:33 -0400 Eli Schwartz <eschwartz@archlinux.org> wrote:
On 07/31/2017 02:09 PM, Christian Rebischke wrote:
Do I really need to do this? Won't the 'git submodule update' command choose the correct commit?
May somebody else correct me, but I don't think so. `git submodule update` will just update to the HEAD of the sub repository. And we want stable builds. Therefore it's important to pin the software at a specific commit and it's dependencies, too.
You're both right and wrong. "$srcdir/$submodulename" will be at origin/master, but `git submodule update` in the primary repo will completely ignore that clone altogether and just cares about the git objects which it uses in yet another clone.
This is a bit confusing. You set the URL of the submodule to the location of the local clone, so it doesn't ignore it, it just clones from the local clone. And yes, it does use the specific commit specified in the main repo, so setting #commit= for the submodule is useless.