On Thu, Sep 14, 2017 at 01:36:20PM +0000, Levente Polyak wrote:
On 09/10/2017 03:16 PM, Alad Wenter via aur-general wrote:
Hello everyone,
My name is Alad Wenter, and I would like to apply for a position as Trusted User. I’m a student in Germany, majoring in Mathematics with a focus on Algebraic Topology. Many thanks to Johannes Löthberg who is sponsoring my TU application.
Hi Alad,
some technical feedback that I found after the current reworks mentioned here:
cottage: - it ignores LDFLAGS and just uses CFLAGS wich results in a binary without our flags (like -znow)
Proposed upstream: [1] [1] https://github.com/HarveyHunt/cottage/pull/11
cottage-git: - same as cottage, LDFLAGS - should provides and conflicts cottage as its a VCS pkgname
Fixed.
dpkg: - would me more error prone and convenient to keep pkgver in sync when using a pkgver() function for pinned commits and f.e. do: git describe --always | sed 's/^v//;s/-/./g'
Fixed.
kkrieger: - cd "$srcdir" doesn't do anything at all
Fixed.
nvtv: - static mention of 0.4.7 version label in source array looks ugly and is less error prone when bumping a pkgver=
Fixed.
pkgelf-git: - should provides and conflicts pkgelf as its a VCS pkgname
Fixed.
xss: - packages doesn't even build line 18: cd: xss-master: No such file or directory and after that install: cannot stat 'README.md': No such file or directory did you test this at all? - would me more error prone and convenient to keep pkgver in sync when using a pkgver() function for pinned commits and f.e. do: git describe --always | sed 's/^v//;s/-/./g' or just count the commits as prefix to pkv - CFLAGS is completely purged and overwritten by the Makefile, it should be passed to be preserved or the Makefile be patched
Fixed. [2] I did test it, but forgot to remove the xss-master directory from the previous source (master.zip) before doing so... [2] https://github.com/9wm/xss/pull/2#event-1249347915
cheers Levente
Cheers, Alad