2008/1/4, Timm Preetz <timm@preetz.us>:
The PKGBUILD seem good, except for some style.
I think it is extra-important that TUs obey the "standard PKGBUILD style" and so I would like to point you to a forum post explaining some more detail: http://bbs.archlinux.org/viewtopic.php?id=35121
Of course one may call this minor, but I think the right order, and (more importantly) the "|| return 1" is good if used throughout all PKGBUILDs.
I think the restructuring can be done in ~10-15 minutes, so not that big of a problem, just something one has to get used to (also took me some time and I'm always looking at my cheat-sheet ;))
Furthermore the two arches are a big plus, so you have my vote.
Please, avoid to comment out. The discussion period for Abhishek (abhidg) is over. -- Giovanni Scafora Arch Linux Trusted User (voidnull) http://www.archlinux.org linuxmania@gmail.com