On Thu, Mar 19, 2009 at 1:54 AM, Abhishek Dasgupta <abhidg@gmail.com> wrote:
2009/3/17 Aaron Griffin <aaronmgriffin@gmail.com>:
Finally pulled in the last patch there into my any-arch branch.
I'm not sure how I feel about it, seeing as it duplicates a lot of work (I was hoping to reuse the loop somehow), but it seems ok otherwise.
Now we just need to make sure db-move and db-remove can handle "any" packages
I could have added the ANYPKGS stuff in the main loop itself, but that was cluttering the code with a lot of if calls. I'm now working on db-{move, remove}. Would it be better if I refactored it to move packages in all archs possible, rather than specifying the arch? Then we could get rid of the testing2core64 and other *64 scripts.
I thought of that. The reason I decided not to was because some packages could move, say, out of testing for i686 and NOT x86_64. I don't know if that's a common case though. Perhaps we can do this: move all packages by default. if the arch is specified on the command line, move only that arch. or in code - looparches="${ARCHES[@]}" [ -n "$2" ] && looparches="$2" for arch in $looparches; do .... do move logic here done