On Sun, Oct 31, 2021 at 06:24:51PM +0000, Leonidas Spyropoulos via aur-general wrote:
Hello,
I'm Leonidas Spyropoulos and I'd like to apply to become a Trusted User. I'm particularly instersted in packaging dependencies which are required for the ongoing python porting of Aurweb and anything related performance. I'm sponsored from Jelle van der Waa <jelle> and Sven-Hendrik Haase<sventaro>.
hello Leonidas. first of all, I wish you luck with your application. I have reviewed your pkgbuilds and would like to share some notes: # aarchup provides=("${pkgname}") this is the default behavior, so this line is unnecessary. install -Dm644 LICENSE.md "$pkgdir/usr/share/licenses/$pkgname/LICENSE" GPL3 is in licenses package so no need to install it. # auracle-git _pkgname=auracle you can use "${pkgname%-git}" instead. # caatinga-git cd "${srcdir}/${pkgname%-git}" all makepkg's functions start in ${srcdir}. python2 setup.py install --root="${pkgdir}/" --optimize=1 no python2-setuptools in makedepends. I take this opportunity to recommend building aur packages in a clean chroot. it helps to identify just such errors. # corefreq-git no git in makedepends. # freeplane mkdir -p I recommend to use install for that. Moreover. below install will create these folders on its own thanks to the D flag. # gnome-shell-extension-cpufreq _pkgname=cpufreq you can use ${pkgname#gnome-shell-extension-} instead. mkdir -p "${pkgdir}/usr/share/gnome-shell/extensions/" I recommend to use install for that. # ntellij-idea-ce-eap, intellij-idea-ue-eap mkdir -p I recommend to use install for that. cat <<EOF a nicer looking solution is to put this file in git and modify it with sed in prepare function. mkdir -p "${pkgdir}/usr/bin/" mkdir -p "${pkgdir}/usr/share/applications/" mkdir -p "${pkgdir}/usr/share/licenses/${pkgname}/" all of this is unnecessary since install will create these folders. ln -sf "${srcdir}/${_pkgname}-${_buildver}/license/$i" "${pkgdir}/usr/share/licenses/${pkgname}/$i" I do not quite understand why this is needed, but it does not look correct. and it seems to me that namcap will agree with me. # python-sklearn-pandas mkdir -p "${pkgdir}/usr/share/licenses/${pkgname}/" install will do this for you. -- Sincerely, Alexander | Trusted User