Re: [aur-general] Dell 2155cdn driver PKGBUILD quality check

On 26-12-15 05:56, Doug Newgard wrote:

On Sat, 26 Dec 2015 01:13:39 +0100 Peter Tobler wrote:

...

Here is the mentioned PKGBUILD: http://pastie.org/pastes/10652982/text?key=23xhgip17gp9tvriuiyma

There's no reason to use the conditionals with the depends array anymore, pacman supports architecture specific arrays now (depends_i686, etc).

bsdtar will extract rpm files, no reason to pull in rpmextract.

Make sure you quote any paths that include any variables that you don't control, like ${pkgdir} and ${srcdir}.

Peter, since your package uses binaries, please append -bin to it's name. rpm-based distros use some folders other then arch does, verify if you need to move things. I assume the source-file has separate 32& 64-bit rpms? If so, you'll have to differentiate between those in package() function. LW