On Sun, Oct 26, 2008 at 9:24 PM, Evangelos Foutras <foutrelis@gmail.com> wrote:
They look very good. A couple of really minor issues is omitting to append " || return 1" to the end of `patch' commands (this is necessary for commands that are important to the build and might fail) and utilizing mv/cp/mkdir instead of the more safe `install'. The latter may be seen as a mainly cosmetic change, but can prevent permission problems caused by non-standard umask setting.

Ok, thank you very much for the advices! I've updated the pkgbuilds :)

Additionally, in case you don't know about it, "namcap" is a utility that points out common mistakes found in packages and PKGBUILDs. It's located in the [extra] repo.

I already used that and pacman -Qpil <package> :P