On Mon, Sep 4, 2023 at 3:29 PM Aaron Liu <aaronliu0130@gmail.com> wrote:

I don't see why you're that infuriated. xiota is indeed a bit combative with language but save for removing `conflicts` their suggestions all look good. Simply adding the "no same owner" removes the need for all that find chmod and chown stuff and just put the conflicting packing name under "conflicts", no need to make a new variable.

You can't accuse a suggestion of being wrong if you don't implement it completely and you already did implement the dynamic URL in the pkgbuild right; why are you still suggesting that implementing it breaks the package? It already works albeit suboptimally because the no-same-owner stuff hasn't been implemented.

You do not have to maintain this package. Nobody is forcing you to go back from church or a funeral. Your email seems like you're nitpicking their admittingly combative language, and I don't see any nitpicks in the line-by-line review. "Code review" has no negative connotations.

On 2023/9/4 15:20, Xavier Baez wrote:

The variable they recommended was build_id

but that didn't create a clean

makepkg --printsrcinfo > .SRCINFO

Here are some of the comments, it's like

https://aur.archlinux.org/packages/motivewave#comment-932313
https://aur.archlinux.org/packages/motivewave#comment-932245
https://aur.archlinux.org/packages/motivewave#comment-932340
https://aur.archlinux.org/packages/motivewave#comment-932245

https://aur.archlinux.org/packages/motivewave#comment-932340

Xiota also manages chaotic AUR, so he created an 'issue' where two packages wouldn't be able to exist, so he deleted motivewave and created motivewave-latest-bin

Then I got re-uploaded, and within hours he re-deleted me again.

He also blocked me from their Git.

Then he moved again to AUR motivewave to team up and the comments started again.

I would like to know what the rules are, today at Labor Day 3 AM the change requests arrive again, yesterday I had to leave church to come home and do more changes Test the package, was working.

I don't want to be forced to use variables or have a permanent code reviewer.

Be called incompetent or imply I am dumb and need help.

This is in the git and shows how their suggestions actually broke the package.

I created my custom variable

but the nit picking has not continued.

Calling a person non competent, rude, rude, rude.

Especially when today the issue has been resolved.

Here is how the package broke because code review.

commit 1bceb28d1875deb4a303e6f13ee51e1ea86c0011
Author: Xavier Baez <xavierbaez@gmail.com>
Date: Sun Sep 3 09:12:02 2023 -0700

changes suggested by muflone

When .SRCINFO is automatically generated with makepkg

the following changes happen in SRCINFO
- source = motivewave-6.7.10.deb::https://downloads.motivewave.com/builds/500/motivewave_.deb
+ source = motivewave-6.7.10.deb::https://downloads.motivewave.com/builds/{}/motivewave{6.7.10}_amd64.deb

diff --git a/.SRCINFO b/.SRCINFO
index e82622d..1dd9db6 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -1,7 +1,7 @@
pkgbase = motivewave
pkgdesc = Advanced trading and charting application.
pkgver = 6.7.10
- pkgrel = 3
+ pkgrel = 4
url = https://www.motivewave.com
arch = x86_64
license = custom
@@ -13,7 +13,7 @@ pkgbase = motivewave
depends = xorg-xrandr
provides = motivewave
conflicts = motivewave-latest-bin
- source = motivewave-6.7.10.deb::https://downloads.motivewave.com/builds/500/motivewave_.deb
+ source = motivewave-6.7.10.deb::https://downloads.motivewave.com/builds/{}/motivewave{6.7.10}_amd64.deb
sha512sums = c97e3bb78236d6ef1ae8581e29b128e6ee512f8241617dbcab5989f3068bfa6bbe9b9c091bb09b238ea891f59e6c12ef13ceee079610f3fc95722c58c4769bb9

--

Regards

Xavier