Hi Daniel, Small summary of things I repeatedly noticed: - # Generated by mksrcinfo v8 Wed Nov 14 05:46:26 UTC 2018 I would say remove this ancient package from your system and use makepkg --printsrcinfo instead - if a setup.py uses entry_points for scripts that means setuptools is not just a make but a hard dependency - tests are awesome <3 run them whenever possible! more is better! pulling sources from github is favorable when you get free tests and sometimes manpages/docs [+] Running xxarhtna --verbose --pedantic asciinema-rs: - provides asciinema, but where is the conflicts? black-git: - this should be called python-black - running unit tests is missing - setuptools is a hard dependency, setup.py uses entry_points - python-aiohttp should be a checkdepends otherwise tests deactivate several things diskus: - we can use --locked for repro as there is a Cargo.lock espeak-ng: - That shouldn't provide espeak, its not a drop in replacement and breaks stuff, this epoch on espeak is for a reason: https://git.archlinux.org/svntogit/community.git/commit/trunk?h=packages/espeak&id=fee824f6ed964b1bab1586fdc4342577f2a57bf2 - autogen.sh should be a prepare() thing firefox-* - i just skip over those, not a fan of repackaging xpi but meh - also meh on the lack of firefox dependency when putting files in /usr/lib/firefox firefox-bookmarkdupes: - building from source will have nice signatures gitleaks: - there are tests available for check() - RELRO ldflags gixy: - setuptools is a hard dependency, setup.py uses entry_points - there are tests available for check() if you pull the real soruces hangups: - setuptools is a hard dependency, setup.py uses entry_points - there are tests available for check() if you pull the real soruces - you can distribute manpages via docs dir + man target if you pull the real soruces (and add python-sphinx as makedepends) instalooter - there are tests available for check() if you pull the real soruces - you can distribute manpages via docs dir + man target if you pull the real soruces (and add python-sphinx as makedepends) mwic - the hack does upstream do, it will create .py files in usr/share/mwic/lib/ that lack the pyo/pyc files and if running as root the imports will create untracked files in that directory that will remain forever pcaudiolib - prepare() is a better place for autogen.sh pulldown-cmark - there is a Cargo.lock lets use --locked for reproducible builds this requires to pull unstripped sources from github - there are also tests available but whatever upstream does, some of them seem to fail? investigate? pulseaudio-dlna: - setuptools is a hard dependency, setup.py uses entry_points pycoinmon: - setuptools is a hard dependency, setup.py uses entry_points - there are tests available for check() if you pull the real soruces shaderc: - pacman -Q glslang-git hm no it depends on glslang - build works perfectly fine with python3 - CMAKE_INSTALL_PREFIX must not use $pkgdir, that belongs to DESTDIR for ninja in package() - i'm sorry, i gonna need to pull this into [extra] as part of an update. thanks for the work pyt: - setuptools is a hard dependency, setup.py uses entry_points pyt-git: - setuptools is a hard dependency, setup.py uses entry_points python-black: - setuptools is a hard dependency, setup.py uses entry_points - python-aiohttp should be a checkdepends otherwise tests deactivate several things python-fake-useragent: - there are tests available for check() if you pull the real soruces needs checkdepends of pytest and mock python-flake8-bugbear: - setuptools is a hard dependency, setup.py uses entry_points python-milksnake: - setuptools is a hard dependency, setup.py uses entry_points - there are tests available for check() if you pull the real soruces python-py-spin: - there are tests available for check() if you pull the real soruces via test_pyspin.py python-soco: - there are tests available for check() via py.test - maybe distribute some docs as well like manpages from docs dir razercfg: - razercfg.install could be removed, ldconfig systemd-tmpfiles and udevadm are handled via hooks - do we _really_ need to split razer mouse tool UI and daemon here? doubt it tbh. rst2ctags: - setuptools is a hard dependency, setup.py uses entry_points rstcheck: - there are tests available for check() via test_rstcheck.py - setuptools is a hard dependency, setup.py uses entry_points socos: - setuptools is a hard dependency, setup.py uses entry_points speedtest-zpeters: - go magic to get RELRO ldflags - whats wrong with the tests? maybe comment? spotify-adkiller-git: - i dont like file-type postfixes in /usr/bin they should be removed and ADKILLER= be adjusted spt: - this needs a build() func, don't build implicitly in package() - CPPFLAGS are not respected and should be populated properly an upstream patch for that would be best termdown: - setuptools is a hard dependency, setup.py uses entry_points termtosvg: - there are nice manpages for this CLI tool in the upstream sourceso on GH toastify: - github sources have Cargo.lock that we need for reproducible builds passed via --locked trust-dns-server: - there are tests that could be run via check() weather-go: - go magic to get RELRO ldflags [*] xxarhtna report finished cheers, Levente