On 26 Jan 2018, at 4:35 -0500, Eli Schwartz via aur-general wrote:
On 01/26/2018 04:23 PM, Ivy Foster wrote:
I'm writing to apply to be a TU, and Alad Wenter has kindly agreed to be my sponsor.
It is great to see you take the plunge, I wish you the best of luck!
Thanks!
Arch has always been a rewarding community to contribute to, and I figure that maintaining some packages and generally helping out could be a good way to contribute a bit more.
If accepted to be a TU, my plan of action is as follows: 1. Go mad with power^U 1. Bring a handful of packages into [community] (see below) 2. Help out with rebuilds and package updates where that does not involve stepping on toes 3. Continue to submit occasional patches to Arch projects 4. Help with to-do lists. [...]
Sounds like a (wo)man after my own heart!
Woman, and glad to hear it!
This reminds me I still have so much to do... like all that https/gpg stuff.
There's always more to do, I guess.
Thanks for your consideration, and I'm of course happy to answer questions and address critiques.
But overall, quite good!
Thanks!
- ledger This program is super useful, and I doubt I'm the only one who dreads every boost update because this takes so long to build!
Lukas has beaten you to it: https://packages.archlinux.org/ledger
I replied to this elsewhere already, but that's great news (-: . In related news, I've [poked upstream][1] to see about a new release, since there's been a year's worth of bugfixes! They're into it. # Critiques & Responses
We discussed this on IRC already, I'll have to check and see how you've adapted to my suggestions.
I've addressed most of them; see responses inline. Of course, onlookers should judge each fix to make sure it's not a "fix" instead. ## cgo-git
2018-01-25 07:07:51 PM guys I noticed something immediately, cgo-git has a custom:cgo-git license, but it is really an ISC license. 2018-01-25 07:08:15 PM guys And it installs the whole source code in /usr/share/licenses/ instead of using sed to extract it or something. :p 2018-01-25 07:09:25 PM guys I'd just extract the first few lines using sed, until I hit the first */ and call it a day
I've changed the license to ISC and used sed to extract the license from the source. I've also [submitted a patch upstream][2] creating a separate LICENSE file.
2018-01-25 07:11:25 PM guys Also, the upstream Makefile is terrible and should use CFLAGS properly :p 2018-01-25 07:12:27 PM guys I want pull requests to fix this :p
[Pull request submitted][3].
2018-01-25 07:14:28 PM guys fist, should be upgraded to use HTTPS since their website upgrades you anyway
[Done][4]. ## frotz-dumb-git / frotz-ncurses-git
2018-01-25 07:27:55 PM guys frotz-git conflicts and *replaces* frotz, which is wrong, it should provide it instead 2018-01-25 07:28:23 PM guys replaces means that if you pacman -Syu and find it in a repo, it gets synced as a replacement for what you currently have...
2018-01-25 07:29:11 PM guys I can hardly read the sed line you use in pkgver() 2018-01-25 07:29:22 PM guys sed 's,-\(.*\)-,.r\1.,' 2018-01-25 07:29:30 PM guys wrong place to use , as separators! 2018-01-25 07:33:03 PM guys But anyway, to modify 2.44-196-gf3ceac9 could just use the standard sed line from the wiki page 2018-01-25 07:34:05 PM escondida that one *I* can hardly read (-:
2018-01-25 07:35:48 PM guys Use of sed to modify more than three things in prepare should be strictly prohibited; use a patch file
[All fixed][5]. I still refuse to use the sed line from the wiki page, because I'm a big weirdo. ## libbulletml & rrootage
2018-01-25 07:39:48 PM guys > # upstream does not provide checksums, though Debian does for their patches 2018-01-25 07:40:04 PM guys This is not a reason to disable checks for download errors.
I've [added checksums][6], along with a note not to place too much trust in them since they're mine and not the developer's.
2018-01-25 07:41:09 PM guys Why does libbulletml.so need to modify CFLAGS CXXFLAGS :( 2018-01-25 07:41:21 PM guys And why does it overwrite LDFLAGS, instead? 2018-01-25 07:41:41 PM guys Does it derp on the LDFLAGS from makepkg.conf? 2018-01-25 07:42:17 PM guys Why does it create libbulletml.a anyway, if makepkg automatically strips staticlibs?
This library's build process is simply bizarre. I've left the build as is, since that seems to be what it takes to get it to, well, build.
2018-01-25 07:51:23 PM guys rrootage: the pkgdesc is self-referential, remove the first two words 2018-01-25 07:52:12 PM guys And it downloads from http://downloads.sourceforge.net, but that can be upgraded to https:// even if the website cannot 2018-01-25 07:53:05 PM guys Is http://ftp.de.debian.org/ really the best download url? I would assume they have something that redirects to the right country mirror
I found a better Debian download url and upgraded the Sourceforge url to https; [fixes here][7]. I've also sent an email to the mysterious Evil Mr. Henry, the porter (portreeve?) who brought it to Linux, to see whether he'd be interested in accepting the Debian patches officially, since they're required to build these days. ## lua-cosmo-git
2018-01-25 07:49:02 PM guys lua-cosmo-git: is built, in package(). 2018-01-25 07:49:27 PM guys If it cannot be built separately from the install command, build it in build() and cp -a it in package() 2018-01-25 07:50:12 PM escondida Oh, right, I meant to drop that one. Instead, I'll update it and then drop it.
To be honest, I ended up simply dropping this package. As far as I can tell, luarocks really seems to expect you to build and intall in one step. I can pick it back up again if anybody has particularly strong feelings on this point. ## netsurf et al.
2018-01-25 07:43:58 PM guys libcss-git should probably use git+https:// for TLS security purposes 2018-01-25 07:45:31 PM guys Same with the other netsurf related packages
Sadly, I got SSL errors when I tried to pull netsurf libs from https. They seem to be available only over http for now. I didn't try *all* of them, granted, but I figure what's true for the css is true for the cssander. I need to update these in general, to tell the truth. Part of me wants to do them all as a massive split PKGBUILD, because the dependency order is fairly intricate (I have them in directories numbered in stages on my machine, but that doesn't translate well to the AUR). ## sndio-git
2018-01-25 07:56:23 PM guys Is sndio-git/0001-put-cookie-somewhere-better.patch upstreamable? 2018-01-25 07:56:32 PM guys Or have you tried and they rejected it
I haven't written the better version to submit yet; that'll probably be sometime in the next few days. ## translate-shell
2018-01-25 07:56:59 PM guys http://www.soimort.org/translate-shell/ is available over HTTPS 2018-01-25 07:57:00 PM phrik Title: Translate Shell (at www.soimort.org) 2018-01-25 07:57:09 PM guys As is the github repo via git+https:// ;)
2018-01-25 07:57:29 PM guys pkgver=v0.9.0.4.7.g1a4d83e # should have the leading v stripped
https://github.com/soimort/translate-shell/blob/develop/Makefile 2018-01-25 07:59:10 PM phrik Title: translate-shell/Makefile at develop · soimort/translate-shell · GitHub (at github.com) 2018-01-25 07:59:22 PM guys latest commit to that file says "Implement DESTDIR support" 2018-01-25 07:59:39 PM guys Complete with mkdir -p ;)
2018-01-25 08:00:44 PM guys And /usr/share/licenses/${_gitname}/LICENSE is technically quite wrong, that is not the package the license is for at all
2018-01-25 08:00:57 PM guys besides which it does not conflict/provide the non-git version
[All fixed][8]. # Concluding thoughts Who's next? Bring it on! iff # Links [1]: https://github.com/ledger/ledger/issues/523 [2]: https://github.com/kieselsteini/cgo/pull/10 [3]: https://github.com/kieselsteini/cgo/pull/9 [4]: https://aur.archlinux.org/cgit/aur.git/log/?h=fist [5]: https://aur.archlinux.org/cgit/aur.git/log/?h=frotz-git [6]: https://aur.archlinux.org/cgit/aur.git/log/?h=libbulletml [7]: https://aur.archlinux.org/cgit/aur.git/log/?h=rrootage [8]: https://aur.archlinux.org/cgit/aur.git/log/?h=translate-shell-git