Sorry, I was attacching an archive, maybe it's not possible, here [1] the archive, it'll be uploaded to the AUR if everything it's ok [1]http://efesto.eigenlab.org/~valo/monkeysphere-0.37-2.src.tar.gz Il 10/12/2014 14:49, Florian Bruhin ha scritto:

* Valo [2014-12-10 14:45:45 +0100]:

...

Hello everybody, I'm a new subscriber of the list and an arch user since 3-4 years. I adopted monkeysphere after talking with the old maintainer, hope it's fine for you. Since it's my first adoption and PKGBUILD I'd like to ask you to review it, I'm wide-open to suggestions, then if it's fine i'll update the package on the AUR. Thanks I can't see any PKGBUILD ;)

Looking at the header:

X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1

Maybe try using a pastebin such as http://p.cmpl.cc/ (shamless plug) instead.

Florian

-- Valerio Baldisserotto -- PGP ID 0x06DD1631 -- www.eigenlab.org -- www.autistici.org/mailman/listinfo/ascia -- "It must be inconvenient to be made of flesh," said the Scarecrow thoughtfully, "for you must sleep, and eat and drink. However, you have brains, and it is worth a lot of bother to be able to think properly." [The Wonderful Wizard of Oz] -- Please avoid sending me Word or PowerPoint attachments,it is a secret proprietary format, so it is hard for me to read. If you send me plain text, HTML, PDF, or ODF then I will read it without any problem. See http://www.gnu.org/philosophy/no-word-attachments.html Thanks

Thanks! I uploaded it Il 10/12/2014 21:28, Florian Bruhin ha scritto:

* Valo [2014-12-10 20:53:58 +0100]:

...

Sorry, I was attacching an archive, maybe it's not possible, here [1] the archive, it'll be uploaded to the AUR if everything it's ok Some minor things:

- There are two checksum arrays, you most likely want to delete sha1sums. Most PKGBUILDs also have them next to source=(...) instead of at the end.

- In line 42, the path should be quoted properly ("$pkgdir/var/...") so it works if $pkgdir e.g. has spaces in it.

Florian

-- Valerio Baldisserotto -- PGP ID 0x06DD1631 -- www.eigenlab.org -- www.autistici.org/mailman/listinfo/ascia -- "It must be inconvenient to be made of flesh," said the Scarecrow thoughtfully, "for you must sleep, and eat and drink. However, you have brains, and it is worth a lot of bother to be able to think properly." [The Wonderful Wizard of Oz] -- Please avoid sending me Word or PowerPoint attachments,it is a secret proprietary format, so it is hard for me to read. If you send me plain text, HTML, PDF, or ODF then I will read it without any problem. See http://www.gnu.org/philosophy/no-word-attachments.html Thanks