[aur-general] TU Application: Andrew Crerar
Hi Everyone! My name is Andrew Crerar (aka andrewSC) and I'm applying to become a Trusted User. Big thanks to Johannes Löthberg for being my sponsor! :) At the moment I'm a Research Software Engineer at The Laboratory for Analytic Sciences [1] where I primarily write Python 3.x (in combination with various other tech like nginx, gunicorn, elasticsearch, etc.) for the prototypes we're building here. Prior to working at the lab I was a Software Engineer and Computer Scientist at Adobe Inc. [2] where I lead and managed the development of Custom Creative Networks [3] (primarily PHP with some JS heavy elements) on the Behance [4] team. My Bachelor's degree is in Computer Science which I received from The Rochester Institute of Technology [5]. I've been using Arch Linux since 2008-2009ish and have seen it grow into something incredible. Over the past several years I've picked up a handful of packages [6] in the AUR which I enjoy maintaining. I also participate in package signoffs for [core], [extra], and [community]. I wish to grow my ability to contribute by becoming more involved in maintaining and managing the AUR while also making contributions to [community] where appropriate. More recently I've created and open sourced Checkthat [7] with the intention to help other AUR package maintainers increase the quality of their packages by combining makepkg and namcap to produce a status + lint report in an automated fashion. I'm not entirely sure if this could be considered an AUR helper so I've refrained from adding it to the wiki for the time being. I also contribute patches to upstream projects on occasion, the most recent being for Gtk+ [8]. If I were to become a Trusted User, I would like to move firefox-developer [9] to [community] as well as adopt Evangelos Foutras's [community] packages [10] if he doesn't want to move them to [extra]. I should mention that the firefox-developer package in the AUR, as it exists, would not be moved to [community]. I've been working with Jan Steffens to produce an acceptable PKGBUILD [11] that would. I would ask the TU's to review that PKGBUILD in place of the current AUR package. Furthermore, the primary reason I'm refraining from landing these changes immediately in the AUR is because it would dramatically increase build times for all current users of the package. Regards, Andrew [1] https://ncsu-las.org [2] https://www.adobe.com [3] https://www.behance.net/poweredby [4] https://www.behance.net [5] https://www.rit.edu [6] https://ptpb.pw/lvIR [7] https://github.com/andrewSC/checkthat [8] https://bugzilla.gnome.org/show_bug.cgi?id=789777 [9] https://aur.archlinux.org/packages/firefox-developer [10] https://www.archlinux.org/packages/?sort=&repo=Community&q=&maintainer=foutrelis&flagged= [11] https://github.com/andrewSC/firefox-developer-edition
Quoting Andrew Crerar (2017-11-17 13:22:38)
Hi Everyone!
My name is Andrew Crerar (aka andrewSC) and I'm applying to become a Trusted User. Big thanks to Johannes Löthberg for being my sponsor! :)
At the moment I'm a Research Software Engineer at The Laboratory for Analytic Sciences [1] where I primarily write Python 3.x (in combination with various other tech like nginx, gunicorn, elasticsearch, etc.) for the prototypes we're building here. Prior to working at the lab I was a Software Engineer and Computer Scientist at Adobe Inc. [2] where I lead and managed the development of Custom Creative Networks [3] (primarily PHP with some JS heavy elements) on the Behance [4] team. My Bachelor's degree is in Computer Science which I received from The Rochester Institute of Technology [5].
I've been using Arch Linux since 2008-2009ish and have seen it grow into something incredible. Over the past several years I've picked up a handful of packages [6] in the AUR which I enjoy maintaining. I also participate in package signoffs for [core], [extra], and [community]. I wish to grow my ability to contribute by becoming more involved in maintaining and managing the AUR while also making contributions to [community] where appropriate.
More recently I've created and open sourced Checkthat [7] with the intention to help other AUR package maintainers increase the quality of their packages by combining makepkg and namcap to produce a status + lint report in an automated fashion. I'm not entirely sure if this could be considered an AUR helper so I've refrained from adding it to the wiki for the time being. I also contribute patches to upstream projects on occasion, the most recent being for Gtk+ [8].
If I were to become a Trusted User, I would like to move firefox-developer [9] to [community] as well as adopt Evangelos Foutras's [community] packages [10] if he doesn't want to move them to [extra]. I should mention that the firefox-developer package in the AUR, as it exists, would not be moved to [community]. I've been working with Jan Steffens to produce an acceptable PKGBUILD [11] that would. I would ask the TU's to review that PKGBUILD in place of the current AUR package. Furthermore, the primary reason I'm refraining from landing these changes immediately in the AUR is because it would dramatically increase build times for all current users of the package.
Regards,
Andrew
[1] https://ncsu-las.org [2] https://www.adobe.com [3] https://www.behance.net/poweredby [4] https://www.behance.net [5] https://www.rit.edu [6] https://ptpb.pw/lvIR [7] https://github.com/andrewSC/checkthat [8] https://bugzilla.gnome.org/show_bug.cgi?id=789777 [9] https://aur.archlinux.org/packages/firefox-developer [10] https://www.archlinux.org/packages/?sort=&repo=Community&q=&maintainer=foutrelis&flagged= [11] https://github.com/andrewSC/firefox-developer-edition
I confirm my sponsorship and all that jazz. Let the discussion period begin. -- Sincerely, Johannes Löthberg PGP Key ID: 0x50FB9B273A9D0BB5 PGP Key FP: 5134 EF9E AF65 F95B 6BB1 608E 50FB 9B27 3A9D 0BB5 https://theos.kyriasis.com/~kyrias/
Quoting Johannes Löthberg (2017-11-17 13:25:20)
I confirm my sponsorship and all that jazz. Let the discussion period begin.
Discussion period is over, and the polling stations are ready. https://aur.archlinux.org/tu/?id=98 -- Sincerely, Johannes Löthberg PGP Key ID: 0x50FB9B273A9D0BB5 PGP Key FP: 5134 EF9E AF65 F95B 6BB1 608E 50FB 9B27 3A9D 0BB5 https://theos.kyriasis.com/~kyrias/
Quoting Johannes Löthberg (2017-11-22 20:58:02)
Quoting Johannes Löthberg (2017-11-17 13:25:20)
I confirm my sponsorship and all that jazz. Let the discussion period begin.
Discussion period is over, and the polling stations are ready. https://aur.archlinux.org/tu/?id=98
So the results are in, and you've been voted in as a TU, congrats! Yes: 25 No: 5 Abstain: 7 Total: 37 -- Sincerely, Johannes Löthberg PGP Key ID: 0x50FB9B273A9D0BB5 PGP Key FP: 5134 EF9E AF65 F95B 6BB1 608E 50FB 9B27 3A9D 0BB5 https://theos.kyriasis.com/~kyrias/
On 11/29/2017 04:10 PM, Johannes Löthberg via aur-general wrote:
Quoting Johannes Löthberg (2017-11-22 20:58:02)
Quoting Johannes Löthberg (2017-11-17 13:25:20)
I confirm my sponsorship and all that jazz. Let the discussion period begin.
Discussion period is over, and the polling stations are ready. https://aur.archlinux.org/tu/?id=98
So the results are in, and you've been voted in as a TU, congrats!
Yes: 25 No: 5 Abstain: 7 Total: 37
Congrats, Andrew! I have upgraded your bugtracker account, you are now a TU in the Community Packages project, and a member in the Keyring project. -- Eli Schwartz
On 11/29/17 4:43 PM, Eli Schwartz via aur-general wrote:
On 11/29/2017 04:10 PM, Johannes Löthberg via aur-general wrote:
Quoting Johannes Löthberg (2017-11-22 20:58:02)
Quoting Johannes Löthberg (2017-11-17 13:25:20)
I confirm my sponsorship and all that jazz. Let the discussion period begin.
Discussion period is over, and the polling stations are ready. https://aur.archlinux.org/tu/?id=98
So the results are in, and you've been voted in as a TU, congrats!
Yes: 25 No: 5 Abstain: 7 Total: 37
Congrats, Andrew! I have upgraded your bugtracker account, you are now a TU in the Community Packages project, and a member in the Keyring project.
Thank you all for this incredible opportunity!! I couldn't be more excited :D Regards, Andrew
On 17/11/17 14:22, Andrew Crerar wrote:
If I were to become a Trusted User, I would like to move firefox-developer [9] to [community] as well as adopt Evangelos Foutras's [community] packages [10] if he doesn't want to move them to [extra]. You told me about this privately on IRC and asked if it was OK to mention it in your application. That was kind of you, but you should have waited more than 9 minutes for my response before going ahead and sending in your application.
To answer your question though, I will keep my community packages in [community] since I don't see a reason to move them and Developers are allowed to maintain packages in [community]. Thanks for the thought though; it's always good for orphan packages to get adopted. Good luck with your application!
On 11/17/17 7:47 AM, Evangelos Foutras via aur-general wrote:
On 17/11/17 14:22, Andrew Crerar wrote:
If I were to become a Trusted User, I would like to move firefox-developer [9] to [community] as well as adopt Evangelos Foutras's [community] packages [10] if he doesn't want to move them to [extra]. You told me about this privately on IRC and asked if it was OK to mention it in your application. That was kind of you, but you should have waited more than 9 minutes for my response before going ahead and sending in your application.
To answer your question though, I will keep my community packages in [community] since I don't see a reason to move them and Developers are allowed to maintain packages in [community].
Thanks for the thought though; it's always good for orphan packages to get adopted. Good luck with your application!
You're right, it was impatient of me to send this before hearing back. I apologize. Thank you for following up and the well wishes!
Hi Andrew, Le 17/11/2017 à 13:22, Andrew Crerar a écrit :
Hi Everyone!
My name is Andrew Crerar (aka andrewSC) and I'm applying to become a Trusted User. Big thanks to Johannes Löthberg for being my sponsor! :)
At the moment I'm a Research Software Engineer at The Laboratory for Analytic Sciences [1] where I primarily write Python 3.x (in combination with various other tech like nginx, gunicorn, elasticsearch, etc.) for the prototypes we're building here. Prior to working at the lab I was a Software Engineer and Computer Scientist at Adobe Inc. [2] where I lead and managed the development of Custom Creative Networks [3] (primarily PHP with some JS heavy elements) on the Behance [4] team. My Bachelor's degree is in Computer Science which I received from The Rochester Institute of Technology [5].
I've been using Arch Linux since 2008-2009ish and have seen it grow into something incredible. Over the past several years I've picked up a handful of packages [6] in the AUR which I enjoy maintaining. I also participate in package signoffs for [core], [extra], and [community]. I wish to grow my ability to contribute by becoming more involved in maintaining and managing the AUR while also making contributions to [community] where appropriate.
More recently I've created and open sourced Checkthat [7] with the intention to help other AUR package maintainers increase the quality of their packages by combining makepkg and namcap to produce a status + lint report in an automated fashion. I'm not entirely sure if this could be considered an AUR helper so I've refrained from adding it to the wiki for the time being. I also contribute patches to upstream projects on occasion, the most recent being for Gtk+ [8].
Nice background and nice project. :) Will be happy to have you on board.
If I were to become a Trusted User, I would like to move firefox-developer [9] to [community] as well as adopt Evangelos Foutras's [community] packages [10] if he doesn't want to move them to [extra]. I should mention that the firefox-developer package in the AUR, as it exists, would not be moved to [community]. I've been working with Jan Steffens to produce an acceptable PKGBUILD [11] that would. I would ask the TU's to review that PKGBUILD in place of the current AUR package. Furthermore, the primary reason I'm refraining from landing these changes immediately in the AUR is because it would dramatically increase build times for all current users of the package.
This is something I had in mind since firefox-developer moved to fixed released instead of nightly builds. I’ll likely switch to that as my main browser once it lands in the repos. ;) I didn’t take a thorough look at the PKGBUILD yet (because I’m currently lacking free time a lot), but one thing that I’ve already pointed out for the existing firefox package as well as for the current firefox-developer package in the AUR is that gtk2 should be moved to optdeps as it is only required by the flashplayer plugin. Also, how do you intend to manage lang packs? I suppose https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packag... could be adapted for that. If so, please do it. ;) Regards, Bruno
I didn’t take a thorough look at the PKGBUILD yet (because I’m currently lacking free time a lot), but one thing that I’ve already pointed out for the existing firefox package as well as for the current firefox-developer package in the AUR is that gtk2 should be moved to optdeps as it is only required by the flashplayer plugin. Not unless the original reason for rejecting the bugreport asking for
On 11/20/2017 06:22 PM, Bruno Pagani via aur-general wrote: that to be an optdepends, has suddenly become invalid. https://bugs.archlinux.org/task/47398 I would assume that foutrelis/heftig are aware of the reasoning for that bug, and will know if/when that changes. I freely admit I have no idea of the status of that, but if I am wrong then that bug could be reopened. -- Eli Schwartz
On 11/17/2017 07:22 AM, Andrew Crerar wrote:
Hi Everyone!
My name is Andrew Crerar (aka andrewSC) and I'm applying to become a Trusted User. Big thanks to Johannes Löthberg for being my sponsor! :)
At the moment I'm a Research Software Engineer at The Laboratory for Analytic Sciences [1] where I primarily write Python 3.x (in combination with various other tech like nginx, gunicorn, elasticsearch, etc.) for the prototypes we're building here. Prior to working at the lab I was a Software Engineer and Computer Scientist at Adobe Inc. [2] where I lead and managed the development of Custom Creative Networks [3] (primarily PHP with some JS heavy elements) on the Behance [4] team. My Bachelor's degree is in Computer Science which I received from The Rochester Institute of Technology [5].
I've been using Arch Linux since 2008-2009ish and have seen it grow into something incredible. Over the past several years I've picked up a handful of packages [6] in the AUR which I enjoy maintaining. I also participate in package signoffs for [core], [extra], and [community]. I wish to grow my ability to contribute by becoming more involved in maintaining and managing the AUR while also making contributions to [community] where appropriate.
Nice to see you applying, and good luck! :) Some quick comments on your AUR packages, but they basically look fine. git-git: - consider adding the latest systemd service changes from [extra]/git - Why does this depend on glib2-git - why are libgnome-keyring and libsecret hard dependencies for people not using those helpers? - Why go to all that extra effort to create a sysusers configuration when the benefit of using sysusers is removed by the need to set a login shell... which you do not add to /etc/shells? In the event that the sysusers configuration is ever made use of, the shell will still need to be fixed. gtk4-git: - url redirects to HTTPS version, this is really an [extra] issue opencv-git: - url redirects to HTTPS version, this is really an [extra] issue - The repo package has hdf5 as a makedepends/optdepends, why is this a depends? More importantly... why is it also still an optdepends? ttf-google-fonts-git: - `install -dm755 ...; install -Dm644 ...;` is kind of like sprinkling your code with `sleep 1` - Instead of copying licenses to a per-font subdirectory, I would use LICENSE.$fontname vlc-git: - Mercy on your soul for having the bravery to touch VLC, I'm skipping this one. :D Nothing jumps out at me anyway. -- Eli Schwartz
ttf-google-fonts-git: - `install -dm755 ...; install -Dm644 ...;` is kind of like sprinkling your code with `sleep 1`
(I think) I understand what you mean, but Andrew might not. To put a finer point on it, `install -dm755` is unnecessary, because install's `-D` flag creates directories anyway. For example, this: install -dm755 "$pkg_license_path" install -Dm644 "$src_license_path" "$pkg_license_path"/OFL.txt Could be replaced with this: install -Dm644 "$src_license_path" "$pkg_license_path"/OFL.txt
On 11/21/17 10:25 AM, Jeremy Audet via aur-general wrote:
ttf-google-fonts-git: - `install -dm755 ...; install -Dm644 ...;` is kind of like sprinkling your code with `sleep 1`
(I think) I understand what you mean, but Andrew might not. To put a finer point on it, `install -dm755` is unnecessary, because install's `-D` flag creates directories anyway. For example, this:
install -dm755 "$pkg_license_path" install -Dm644 "$src_license_path" "$pkg_license_path"/OFL.txt
Could be replaced with this:
install -Dm644 "$src_license_path" "$pkg_license_path"/OFL.txt
Thanks for the heads up, yeah, I was being overly verbose/explicit with the commands in the PKGBUILD. I'm making the changes now :)
On 11/20/17 8:18 PM, Eli Schwartz wrote:
On 11/17/2017 07:22 AM, Andrew Crerar wrote:
Hi Everyone!
My name is Andrew Crerar (aka andrewSC) and I'm applying to become a Trusted User. Big thanks to Johannes Löthberg for being my sponsor! :)
At the moment I'm a Research Software Engineer at The Laboratory for Analytic Sciences [1] where I primarily write Python 3.x (in combination with various other tech like nginx, gunicorn, elasticsearch, etc.) for the prototypes we're building here. Prior to working at the lab I was a Software Engineer and Computer Scientist at Adobe Inc. [2] where I lead and managed the development of Custom Creative Networks [3] (primarily PHP with some JS heavy elements) on the Behance [4] team. My Bachelor's degree is in Computer Science which I received from The Rochester Institute of Technology [5].
I've been using Arch Linux since 2008-2009ish and have seen it grow into something incredible. Over the past several years I've picked up a handful of packages [6] in the AUR which I enjoy maintaining. I also participate in package signoffs for [core], [extra], and [community]. I wish to grow my ability to contribute by becoming more involved in maintaining and managing the AUR while also making contributions to [community] where appropriate.
Nice to see you applying, and good luck! :)
Thanks :)
Some quick comments on your AUR packages, but they basically look fine.
git-git: - consider adding the latest systemd service changes from [extra]/git
Done.
- Why does this depend on glib2-git
Initially it was because Namcap reported that glib2-git (which provided libgobject-2.0.so.0 and libglib-2.0.so.0) was needed for the files git-core/git-credential-libsecret and git-core/git-credential-gnome-keyring. Honestly it didn't need to be glib2-git as glib2 from [core] would work just as well in providing those libs. Seeing as libsecret from [core] has a dependency on glib2 I'll take glib2-git out and put libsecret in the optdepends array.
- why are libgnome-keyring and libsecret hard dependencies for people not using those helpers?
You're right, these should be optdepends. Also I took the liberty of removing libgnome-keyring as it's deprecated [1].
- Why go to all that extra effort to create a sysusers configuration when the benefit of using sysusers is removed by the need to set a login shell... which you do not add to /etc/shells? In the event that the sysusers configuration is ever made use of, the shell will still need to be fixed.
I double checked this one and I am adding git-shell to /etc/shells within the install file [2]. This is the same behavior as git in [extra] [3].
gtk4-git: - url redirects to HTTPS version, this is really an [extra] issue
Fixed.
opencv-git: - url redirects to HTTPS version, this is really an [extra] issue
Fixed.
- The repo package has hdf5 as a makedepends/optdepends, why is this a depends? More importantly... why is it also still an optdepends?
I dug around a bit and found this ticket [4] where it seems if you didn't have hdf5 as a makedepends, then the build would fail (I personally don't think it should have failed given the documentation [5]). This really should be optdepends now since you can build without it. Fixed. I also took the liberty of adding opencv-samples to the conflicts array (since opencv-git provides samples without the split package).
ttf-google-fonts-git: - `install -dm755 ...; install -Dm644 ...;` is kind of like sprinkling your code with `sleep 1`
Fixed.
- Instead of copying licenses to a per-font subdirectory, I would use LICENSE.$fontname
Fixed.
vlc-git: - Mercy on your soul for having the bravery to touch VLC, I'm skipping this one. :D Nothing jumps out at me anyway.
;) [1] https://wiki.gnome.org/Projects/Libsecret [2] https://aur.archlinux.org/cgit/aur.git/tree/git-git.install?h=git-git#n7 [3] https://git.archlinux.org/svntogit/packages.git/tree/trunk/git.install?h=pac... [4] https://bugs.archlinux.org/task/50111 [5] https://docs.opencv.org/master/d3/d23/classcv_1_1hdf_1_1HDF5.html#details
On November 21, 2017 5:41:19 PM GMT+01:00, Andrew Crerar
opencv-git: - The repo package has hdf5 as a makedepends/optdepends, why is this a depends? More importantly... why is it also still an optdepends?
I dug around a bit and found this ticket [4] where it seems if you didn't have hdf5 as a makedepends, then the build would fail (I personally don't think it should have failed given the documentation [5]). This really should be optdepends now since you can build without it. Fixed.
I don't think this is what the intention was, the mention of optdepends was to ask why it's an optdepends if it's already a hard depends (doesn't make sense). Now there is no hdf5 support built at all and a optdepends won't change this fact. What you want is most likely the same as the non git variant: add it to makedepends so at build time the hdf5 part can be compiled but remove it from depends as it's runtime optional. Cheers Levente
On 11/21/2017 11:41 AM, Andrew Crerar wrote:
I double checked this one and I am adding git-shell to /etc/shells within the install file [2]. This is the same behavior as git in [extra] [3].
Whoops, I must have gotten confused while `diff`ing your files against the version in extra.
I dug around a bit and found this ticket [4] where it seems if you didn't have hdf5 as a makedepends, then the build would fail (I personally don't think it should have failed given the documentation [5]). This really should be optdepends now since you can build without it. Fixed. I also took the liberty of adding opencv-samples to the conflicts array (since opencv-git provides samples without the split package).
As anthraxx said... I have no personal experience with the package but it should either be a makedepends+optdepends as with the non-git package, or if something has changed in git and it cannot be made optional it shouldn't be both a depends and an optdepends. -- Eli Schwartz
On 11/21/17 3:17 PM, Eli Schwartz wrote:
On 11/21/2017 11:41 AM, Andrew Crerar wrote:
I double checked this one and I am adding git-shell to /etc/shells within the install file [2]. This is the same behavior as git in [extra] [3].
Whoops, I must have gotten confused while `diff`ing your files against the version in extra.
I dug around a bit and found this ticket [4] where it seems if you didn't have hdf5 as a makedepends, then the build would fail (I personally don't think it should have failed given the documentation [5]). This really should be optdepends now since you can build without it. Fixed. I also took the liberty of adding opencv-samples to the conflicts array (since opencv-git provides samples without the split package).
As anthraxx said... I have no personal experience with the package but it should either be a makedepends+optdepends as with the non-git package, or if something has changed in git and it cannot be made optional it shouldn't be both a depends and an optdepends.
Mhmm, after reading what anthraxx wrote I realized the mistake I made in not putting it in makedepends as well. It's like yes, the package will compile without it but the support will be missing and if you install hdf5 _after_ installing the package you still don't get the hdf5 support (since you needed to have hdf5 installed before compiling to enable it in the first place).
participants (7)
-
Andrew Crerar
-
Bruno Pagani
-
Eli Schwartz
-
Evangelos Foutras
-
Jeremy Audet
-
Johannes Löthberg
-
Levente Polyak