[aur-general] Request for comments: new tdom package - replace or additional git
Hello, since I'm really new to archlinux and the AUR I would like to get some comments on my first package, derived from an existing one: https://aur.archlinux.org/packages/tdom/ Since the update to tcl 8.6 it is not possible to build the package. Their is no current tagged version so I have created a git-version of the PKGBUILD: https://gist.github.com/4614862 So besides any comment to make the PKGBUILD better, I have the following questions: What's best: make a new package tdom-git that uses the github master branch or just change the current package? Or make a "stable" package that uses the last tagged version and patch the support for tcl 8.6? (and maybe make a git package too) The current maintainer wants to hand over the package. What are the right steps for this? Best regards Uwe
On 01/28/2013 06:58 PM, Uwe Koloska wrote:
Hello,
since I'm really new to archlinux and the AUR
Welcome to Arch!
I would like to get some comments on my first package, derived from an existing one: https://aur.archlinux.org/packages/tdom/ Since the update to tcl 8.6 it is not possible to build the package.
Their is no current tagged version so I have created a git-version of the PKGBUILD: https://gist.github.com/4614862
So besides any comment to make the PKGBUILD better,
You can smoosh that package function into: https://gist.github.com/4660513 (Just remember to quote anything involving $srcdir, for the same reason you quoted $pkgdir)
I have the following questions:
What's best: make a new package tdom-git that uses the github master branch or just change the current package?
Or make a "stable" package that uses the last tagged version and patch the support for tcl 8.6? (and maybe make a git package too) You can both make a -git version and update the current one; they're treated independently. Although, what tags are you using? I believe you mentioned above that they weren't tagged...? The current maintainer wants to hand over the package. What are the right steps for this?
There's no way to "hand over" the package, per se; the best you can do is have the maintainer orphan the package and you can then scoop it up immediately. Of course, expressing your intent on this mailing list is a good step.
Best regards Uwe Same to you; good luck! ;]
luolimao
On 01/28/2013 07:24 PM, Limao Luo wrote:
What's best: make a new package tdom-git that uses the github master branch or just change the current package?
Or make a "stable" package that uses the last tagged version and patch the support for tcl 8.6? (and maybe make a git package too) You can both make a -git version and update the current one; they're
On 01/28/2013 06:58 PM, Uwe Koloska wrote: treated independently.
To be clear, the current one should be treated as "stable", and the -git version will pull git sources as they are committed to master.
On 29.01.2013 01:24, Limao Luo wrote:
You can smoosh that package function into: https://gist.github.com/4660513
(Just remember to quote anything involving $srcdir, for the same reason you quoted $pkgdir)
Thank you -- together with the --mandir trick from Daniel this will make the script a lot better!
You can both make a -git version and update the current one; they're treated independently. Although, what tags are you using? I believe you mentioned above that they weren't tagged...?
Yeah, that's the culprit. No official stable version for tcl 8.6 at the moment. The last tagged version is from 2008 but their are only few changes. But, what to do with the stable package? * use fixed revision to not get unwanted/unreviewed commits? * variation: fork the repo, tag the current version and then use this? * use last tagged version and patch the incompatibility? * variation: fork the repo, cherry pick only the 8.6 fix, tag and use this? Thank you Uwe
You can smoosh that package function into: https://gist.github.com/4660513
(Just remember to quote anything involving $srcdir, for the same reason you quoted $pkgdir) Thank you -- together with the --mandir trick from Daniel this will make
On 29.01.2013 01:24, Limao Luo wrote: the script a lot better! Actually, if you use --mandir (which is the better idea -- I forgot about it completely) you don't need the install -d or mv in package() function; i.e. it would be the same as the other posted package function (the one in http://ix.io/4bk).
You can both make a -git version and update the current one; they're treated independently. Although, what tags are you using? I believe you mentioned above that they weren't tagged...? Yeah, that's the culprit. No official stable version for tcl 8.6 at the moment.
The last tagged version is from 2008 but their are only few changes.
But, what to do with the stable package? * use fixed revision to not get unwanted/unreviewed commits? * variation: fork the repo, tag the current version and then use this? * use last tagged version and patch the incompatibility? * variation: fork the repo, cherry pick only the 8.6 fix, tag and use this? The upstream looks dead (inactive for 9 months, and no material commits for even longer), so I would suggest that last variation (fork, cherry
On 01/29/2013 07:42 PM, Uwe Koloska wrote: pick fix, tag, release).
Thank you Uwe
Hello,
since I'm really new to archlinux and the AUR I would like to get some comments on my first package, derived from an existing one: https://aur.archlinux.org/packages/tdom/ Since the update to tcl 8.6 it is not possible to build the package.
Their is no current tagged version so I have created a git-version of the PKGBUILD: https://gist.github.com/4614862
So besides any comment to make the PKGBUILD better, I have the following questions:
What's best: make a new package tdom-git that uses the github master branch or just change the current package?
Or make a "stable" package that uses the last tagged version and patch the support for tcl 8.6? (and maybe make a git package too)
The current maintainer wants to hand over the package. What are the right steps for this?
Best regards Uwe
On Tue, Jan 29, 2013 at 12:58:42AM +0100, Uwe Koloska wrote: try http://ix.io/4bk and configure the --mandir so you can just get dir of the mkdir and mv commands all together. -- Daniel Wallace Archlinux Trusted User (gtmanfred) Georgia Institute of Technology
On 29.01.2013 01:50, Daniel Wallace wrote:
try http://ix.io/4bk and configure the --mandir so you can just get dir of the mkdir and mv commands all together.
Thank you -- that looks great and is very welcome! Because you changed the Maintainer back to the (now) former one: Is there a proposed way to give credit to the former maintainer? Or will he only survive in the history (if there is anything like this)? About the changes in the git code: I (maybe) have used this template: https://projects.archlinux.org/abs.git/tree/prototypes/PKGBUILD-git.proto The tip from the Arch wiki: https://wiki.archlinux.org/index.php/VCS_PKGBUILD_Guidelines is slightly different ... Should I reflect the changes (the quotes) at least there? What about using "--depth=1" when doing "git clone" from the remote repo? And why did you remove the '()' around cd "${_gitname}" && git pull origin A makepkg function is a normal shellscript, isn't it? If it is, the following lines will be executed inside ${_gitname} and that is not what I want -- maybe I'm wrong. Thank you for your help Uwe
On 30.01.2013 01:41, Uwe Koloska wrote:
Because you changed the Maintainer back to the (now) former one:
Forget about this sentence, it doesn't make sense ... ... I have diffed a newer version of my PKGBUILD.
Is there a proposed way to give credit to the former maintainer? Or will he only survive in the history (if there is anything like this)?
But this question is still of interest ;-)
On 01/29/2013 08:00 PM, Uwe Koloska wrote:
Is there a proposed way to give credit to the former maintainer? Or will he only survive in the history (if there is anything like this)? But this question is still of interest ;-) Have a look at the top of one of my packages: https://aur.archlinux.org/packages/cb/cbrpager/PKGBUILD
On 29.01.2013 01:50, Daniel Wallace wrote:
try http://ix.io/4bk and configure the --mandir so you can just get dir of the mkdir and mv commands all together. The tip from the Arch wiki: https://wiki.archlinux.org/index.php/VCS_PKGBUILD_Guidelines is slightly different ... Should I reflect the changes (the quotes) at least there?
What about using "--depth=1" when doing "git clone" from the remote repo? Since you're not manipulating past commits or non-master branches,
On 01/29/2013 07:41 PM, Uwe Koloska wrote: that's fine for this package, yes.
And why did you remove the '()' around cd "${_gitname}" && git pull origin A makepkg function is a normal shellscript, isn't it? Yes, absolutely. If it is, the following lines will be executed inside ${_gitname} and that is not what I want -- maybe I'm wrong. No, you're right; the PKGBUILD-git.proto uses
rm -rf "$srcdir/$_gitname-build" git clone "$srcdir/$_gitname" "$srcdir/$_gitname-build" cd "$srcdir/$_gitname-build" which doesn't use relative paths; however, since your PKGBUILD does use relative paths, removing the parentheses will cause it to not build when the .git dir already exists.
Thank you for your help Uwe
participants (3)
-
Daniel Wallace
-
Limao Luo
-
Uwe Koloska