Howdy, I am working on a PKGBUILD for a new GNU Social client called GnuSocialShell. I made one for the git version, because this is being rapidly developed, and I don't believe there is an actual release yet anyway. The problem is, it haults with an error when trying to copy files in place, and I'm not sure why. I have gone over this file and can't find anything wrong with it. It's probably something simple I'm just overlooking though. Thanks for any help :) Storm
On Tue, 12 Jul 2016 12:01:22 -0400 Storm Dragon via aur-general aur-general@archlinux.org wrote:
Howdy, I am working on a PKGBUILD for a new GNU Social client called GnuSocialShell. I made one for the git version, because this is being rapidly developed, and I don't believe there is an actual release yet anyway. The problem is, it haults with an error when trying to copy files in place, and I'm not sure why. I have gone over this file and can't find anything wrong with it. It's probably something simple I'm just overlooking though. Thanks for any help :) Storm
Looks like a very badly written Makefile. You'll have to install the files to $pkgdir yourself.
Hi there,
It looks like the reason you are receiving the error is because their Makefile does not support DESTDIR or prefix. There are static locations that the make install copies the config to. (and makepkg doesn't have root permissions so it can't copy to /etc/)
On 07/12/2016 12:01 PM, Storm Dragon via aur-general wrote:
Howdy, I am working on a PKGBUILD for a new GNU Social client called GnuSocialShell. I made one for the git version, because this is being rapidly developed, and I don't believe there is an actual release yet anyway. The problem is, it haults with an error when trying to copy files in place, and I'm not sure why. I have gone over this file and can't find anything wrong with it. It's probably something simple I'm just overlooking though. Thanks for any help :) Storm
On 07/12/2016 12:11 PM, Doug Newgard wrote:
On Tue, 12 Jul 2016 12:01:22 -0400 Storm Dragon via aur-general aur-general@archlinux.org wrote:
Howdy, I am working on a PKGBUILD for a new GNU Social client called GnuSocialShell. I made one for the git version, because this is being rapidly developed, and I don't believe there is an actual release yet anyway. The problem is, it haults with an error when trying to copy files in place, and I'm not sure why. I have gone over this file and can't find anything wrong with it. It's probably something simple I'm just overlooking though. Thanks for any help :) Storm
Looks like a very badly written Makefile. You'll have to install the files to $pkgdir yourself.
That, or write a competently-written Makefile *from scratch* and contribute it upstream if you want to help the project.
Seriously. That Makefile looks like someone decided "Makefiles are traditional, so we need one", but had no real idea how to make one, so they just created aliases for the commands they usually used to manually compile and install it.
2016-07-12 13:01 GMT-03:00 Storm Dragon via aur-general < aur-general@archlinux.org>:
Howdy, I am working on a PKGBUILD for a new GNU Social client called GnuSocialShell. I made one for the git version, because this is being rapidly developed, and I don't believe there is an actual release yet anyway. The problem is, it haults with an error when trying to copy files in place, and I'm not sure why. I have gone over this file and can't find anything wrong with it. It's probably something simple I'm just overlooking though. Thanks for any help :) Storm
Hello there.
My comments on this situation and your PKGBUILD:
1st - The PKGBUILD has CRLF. You need to format it to Unix (use 'dos2unix' command)
2nd - Your command line to get version doesn't seem to be correct. 'Main.c' reports current version 0.8, just like 'git shortlog' history shows. But you've got '1' from what doesn't look to be a version. Please review that.
3rd - Not the main issue, but remember to set arch (don't use 'any')
4th - Makefile is copying files to directly to '/etc' and '/usr', instead of allowing fakeroot to work with a variable like $(DESTDIR) before that path. That's an upstream bug, that can be fixed with the attached patch
5th - Makefile tries to copy to directories without making sure they exist. Again, upstream bug fixed with my patch.
My suggestion is to fix yourself the first 3 issues and file a bug report for the last 2.
Best regards, Rafael Fontenelle
2016-07-12 19:55 GMT-03:00 Rafael Fontenelle rafaelff@gnome.org:
2016-07-12 13:01 GMT-03:00 Storm Dragon via aur-general < aur-general@archlinux.org>:
Howdy, I am working on a PKGBUILD for a new GNU Social client called GnuSocialShell. I made one for the git version, because this is being rapidly developed, and I don't believe there is an actual release yet anyway. The problem is, it haults with an error when trying to copy files in place, and I'm not sure why. I have gone over this file and can't find anything wrong with it. It's probably something simple I'm just overlooking though. Thanks for any help :) Storm
Hello there.
My comments on this situation and your PKGBUILD:
1st - The PKGBUILD has CRLF. You need to format it to Unix (use 'dos2unix' command)
2nd - Your command line to get version doesn't seem to be correct. 'Main.c' reports current version 0.8, just like 'git shortlog' history shows. But you've got '1' from what doesn't look to be a version. Please review that.
3rd - Not the main issue, but remember to set arch (don't use 'any')
4th - Makefile is copying files to directly to '/etc' and '/usr', instead of allowing fakeroot to work with a variable like $(DESTDIR) before that path. That's an upstream bug, that can be fixed with the attached patch
5th - Makefile tries to copy to directories without making sure they exist. Again, upstream bug fixed with my patch.
My suggestion is to fix yourself the first 3 issues and file a bug report for the last 2.
Best regards, Rafael Fontenelle
Now with attachment.
Rafael Fontenelle
Still no attachment
On Tue, 12 Jul 2016 20:05:43 -0300, Rafael Fontenelle wrote:
Now with attachment.
Third time lucky.
2016-07-12 20:14 GMT-03:00 Justin Dray justin@dray.be:
Still no attachment
Looks like the mailing list is blocking my attachment...
Storm Dragon, here is the patch: http://pastie.org/10905472
Howdy, I have no clue how it got set to crlf. I made this in Vim on Arch lol. I guess the original was from a template with the wrong format. This is fixed now, however. I also think I have a working fix for the version issue. This really does compile on any architecture, including ARMv7 etc. I applied your patch and did a pull request, thanks so much for providing that. Also, thank you for the tips. Storm
On Tue, Jul 12, 2016 at 08:05:43PM -0300, Rafael Fontenelle wrote:
2016-07-12 19:55 GMT-03:00 Rafael Fontenelle rafaelff@gnome.org:
2016-07-12 13:01 GMT-03:00 Storm Dragon via aur-general < aur-general@archlinux.org>:
Howdy, I am working on a PKGBUILD for a new GNU Social client called GnuSocialShell. I made one for the git version, because this is being rapidly developed, and I don't believe there is an actual release yet anyway. The problem is, it haults with an error when trying to copy files in place, and I'm not sure why. I have gone over this file and can't find anything wrong with it. It's probably something simple I'm just overlooking though. Thanks for any help :) Storm
Hello there.
My comments on this situation and your PKGBUILD:
1st - The PKGBUILD has CRLF. You need to format it to Unix (use 'dos2unix' command)
2nd - Your command line to get version doesn't seem to be correct. 'Main.c' reports current version 0.8, just like 'git shortlog' history shows. But you've got '1' from what doesn't look to be a version. Please review that.
3rd - Not the main issue, but remember to set arch (don't use 'any')
4th - Makefile is copying files to directly to '/etc' and '/usr', instead of allowing fakeroot to work with a variable like $(DESTDIR) before that path. That's an upstream bug, that can be fixed with the attached patch
5th - Makefile tries to copy to directories without making sure they exist. Again, upstream bug fixed with my patch.
My suggestion is to fix yourself the first 3 issues and file a bug report for the last 2.
Best regards, Rafael Fontenelle
Now with attachment.
Rafael Fontenelle
On Wed, Jul 13, 2016 at 12:30:53PM -0400, Storm Dragon via aur-general wrote:
Howdy, I have no clue how it got set to crlf. I made this in Vim on Arch lol. I guess the original was from a template with the wrong format. This is fixed now, however. I also think I have a working fix for the version issue. This really does compile on any architecture, including ARMv7 etc.
'any' is for packages that can be installed unchanged on any architecture (think of python or perl scripts, or just data with no binary program).
A compiled program must use an explicit array of architectures, not 'any'.
I applied your patch and did a pull request, thanks so much for providing that. Also, thank you for the tips. Storm
On Tue, Jul 12, 2016 at 08:05:43PM -0300, Rafael Fontenelle wrote:
2016-07-12 19:55 GMT-03:00 Rafael Fontenelle rafaelff@gnome.org:
2016-07-12 13:01 GMT-03:00 Storm Dragon via aur-general < aur-general@archlinux.org>:
Howdy, I am working on a PKGBUILD for a new GNU Social client called GnuSocialShell. I made one for the git version, because this is being rapidly developed, and I don't believe there is an actual release yet anyway. The problem is, it haults with an error when trying to copy files in place, and I'm not sure why. I have gone over this file and can't find anything wrong with it. It's probably something simple I'm just overlooking though. Thanks for any help :) Storm
Hello there.
My comments on this situation and your PKGBUILD:
1st - The PKGBUILD has CRLF. You need to format it to Unix (use 'dos2unix' command)
2nd - Your command line to get version doesn't seem to be correct. 'Main.c' reports current version 0.8, just like 'git shortlog' history shows. But you've got '1' from what doesn't look to be a version. Please review that.
3rd - Not the main issue, but remember to set arch (don't use 'any')
4th - Makefile is copying files to directly to '/etc' and '/usr', instead of allowing fakeroot to work with a variable like $(DESTDIR) before that path. That's an upstream bug, that can be fixed with the attached patch
5th - Makefile tries to copy to directories without making sure they exist. Again, upstream bug fixed with my patch.
My suggestion is to fix yourself the first 3 issues and file a bug report for the last 2.
Best regards, Rafael Fontenelle
Now with attachment.
Rafael Fontenelle
On 07/13/2016 12:30 PM, Storm Dragon via aur-general wrote:
Howdy, I have no clue how it got set to crlf. I made this in Vim on Arch lol. I guess the original was from a template with the wrong format. This is fixed now, however. I also think I have a working fix for the version issue.
The proper fix for the version issue is for upstream to tag their releases, and use the `git describe` example on the Arch Wiki.
This really does compile on any architecture, including ARMv7 etc.
Right, but that isn't what "arch" means in the context of a PKGBUILD. Maybe it is time to review the PKGBUILD definition? https://wiki.archlinux.org/index.php/PKGBUILD#arch
I applied your patch and did a pull request, thanks so much for providing that. Also, thank you for the tips. Storm
As mentioned several times, that Makefile is a wreck. The *proper* fix looks a lot more like this: http://pastebin.com/raw/EUN7P1e5
aur-general@lists.archlinux.org