[aur-general] libgroove package review, round 2
Hi all, I'm hoping to push a change [1] [2] to my libgroove package. I know that the change _works_, but I'm not sure if it's _correct_. Upstream has added a sample pkg-config config file to their source code. I'd like to install a slightly modified version of that config file to users' systems. The question is this: when do I make those minor modifications? Should I copy and patch the pkg-config file during the `prepare` function? Should I wait until `package`? I've read the PKGBUILD (5) man page and wiki page with a special eye toward functional differences between these functions. However, I just don't see any good guidance on this point. I should reiterate that this question is more focused on stylistic correctness than function, as my proposed change does work. [1] https://github.com/Ichimonji10/PKGBUILDs/compare/libgroove [2] https://github.com/Ichimonji10/PKGBUILDs/commit/7619a4bccda0e643f8dc250a849b... — Jeremy "Ichimonji10" Audet
* Jeremy Audet <ichimonji10@gmail.com> (Tue, 14 Oct 2014 23:17:03 -0400):
Upstream has added a sample pkg-config config file to their source code. I'd like to install a slightly modified version of that config file to users' systems. The question is this: when do I make those minor modifications? Should I copy and patch the pkg-config file during the `prepare` function? Should I wait until `package`?
IMHO, it's like patches to the sources: you don't want that to happen twice if someone tries to build your package with --noextract, it will fail. So I think those changes should be done in prepare(), not in package(). Regards, Marcel
--noextract
Ahhhh, so that's the functional difference between `prepare` and `package`! Thanks. I haven't tested any of my packages with `--noextract`, but I'll spend some time getting familiar with that option. — Jeremy "Ichimonji10" Audet
* Jeremy Audet <ichimonji10@gmail.com> (Wed, 15 Oct 2014 13:34:57 -0400):
Ahhhh, so that's the functional difference between `prepare` and `package`!
And in prepare(), build() and check() you shouldn't touch $pkgdir!
Thanks. I haven't tested any of my packages with `--noextract`, but I'll spend some time getting familiar with that option.
There's also the other function --nobuild, that extracts the sources and runs prepare(). Regards, Marcel
participants (2)
-
Jeremy Audet
-
Marcel Korpel