[aur-general] Request to remove/orphan the AUR package "aspell-nb"
The AUR package "aspell-nb" doesn't build, is outdated and most likely abandoned. I suggest to either remove it or orphan it so that I can replace the PKGBUILD with an edited version that actually builds: pkgname=aspell-nb _pkgname=aspell-no pkgver=0.50 pkgrel=2 pkgdesc="Norwegian Bokmål dictionary for aspell" url="http://aspell.net/" license="GPL" depends=('aspell') arch=('i686' 'x86_64') source=(ftp://ftp.gnu.org/gnu/aspell/dict/nb/${_pkgname}-${pkgver}-${pkgrel}.tar.bz2) md5sums=('b24b20ad02ce2a569f71f949b48823cc') build() { cd $startdir/src/${_pkgname}-${pkgver}-${pkgrel} ./configure /usr/bin/make || return 1 /usr/bin/make DESTDIR=$startdir/pkg install } Please let advise if this PKGBUILD isn't following AUR guidelines. Thank you.
On Feb 9, 2013 10:33 AM, "Third3ye" <tredje0ye@gmail.com> wrote:
The AUR package "aspell-nb" doesn't build, is outdated and most likely
abandoned. I suggest to either remove it or orphan it so that I can replace the PKGBUILD with an edited version that actually builds:
pkgname=aspell-nb _pkgname=aspell-no
Why not just use the actual package name?
pkgver=0.50 pkgrel=2 pkgdesc="Norwegian Bokmål dictionary for aspell" url="http://aspell.net/" license="GPL" ("GPL") is better :)
depends=('aspell') arch=('i686' 'x86_64') source=( ftp://ftp.gnu.org/gnu/aspell/dict/nb/${_pkgname}-${pkgver}-${pkgrel}.tar.bz2 ) md5sums=('b24b20ad02ce2a569f71f949b48823cc')
build() { cd $startdir/src/${_pkgname}-${pkgver}-${pkgrel} Please do not use $startdir, use $srcdir and $pkgdir instead, and quote them :)
./configure /usr/bin/make || return 1
" || return 1 " is not needed anymore.
/usr/bin/make DESTDIR=$startdir/pkg install
The install part should be splitted in package()
}
Please let advise if this PKGBUILD isn't following AUR guidelines.
Thank you.
On 02/08/2013 09:53 PM, Felix Yan wrote:
The AUR package "aspell-nb" doesn't build, is outdated and most likely abandoned. I suggest to either remove it or orphan it so that I can replace
On Feb 9, 2013 10:33 AM, "Third3ye" <tredje0ye@gmail.com> wrote: the PKGBUILD with an edited version that actually builds:
pkgname=aspell-nb _pkgname=aspell-no Why not just use the actual package name?
pkgver=0.50 pkgrel=2 pkgdesc="Norwegian Bokmål dictionary for aspell" url="http://aspell.net/" license="GPL" ("GPL") is better :)
depends=('aspell') arch=('i686' 'x86_64') source=( ftp://ftp.gnu.org/gnu/aspell/dict/nb/${_pkgname}-${pkgver}-${pkgrel}.tar.bz2 ) md5sums=('b24b20ad02ce2a569f71f949b48823cc')
build() { cd $startdir/src/${_pkgname}-${pkgver}-${pkgrel} Please do not use $startdir, use $srcdir and $pkgdir instead, and quote them :)
./configure /usr/bin/make || return 1
" || return 1 " is not needed anymore.
/usr/bin/make DESTDIR=$startdir/pkg install
The install part should be splitted in package()
}
Please let advise if this PKGBUILD isn't following AUR guidelines.
Thank you. Whoops, a TU beat me to it :D
On 02/08/2013 09:33 PM, Third3ye wrote:
The AUR package "aspell-nb" doesn't build, is outdated and most likely abandoned. I suggest to either remove it or orphan it so that I can replace the PKGBUILD with an edited version that actually builds:
pkgname=aspell-nb _pkgname=aspell-no pkgver=0.50 pkgrel=2 pkgdesc="Norwegian Bokmål dictionary for aspell" url="http://aspell.net/" license="GPL"
Nitpicky, I know, but license is an array, and should have parentheses around it.
depends=('aspell') arch=('i686' 'x86_64') source=(ftp://ftp.gnu.org/gnu/aspell/dict/nb/${_pkgname}-${pkgver}-${pkgrel}.tar.bz2)
md5sums=('b24b20ad02ce2a569f71f949b48823cc')
build() { cd $startdir/src/${_pkgname}-${pkgver}-${pkgrel}
Don't use $startdir, please. Use $srcdir instead of $startdir/src.
./configure /usr/bin/make || return 1
The "|| return 1" does nothing; makepkg will exit if any command fails anyway. Also, I don't see it necessary to explicitly call /usr/bin/make, just make will work fine.
/usr/bin/make DESTDIR=$startdir/pkg install
Similar to above, $pkgdir is standard, while $startdir/pkg is obsolete.
}
Please let advise if this PKGBUILD isn't following AUR guidelines.
Thank you.
On Sat, Feb 09, 2013 at 03:33:30AM +0100, Third3ye wrote:
The AUR package "aspell-nb" doesn't build, is outdated and most likely abandoned. I suggest to either remove it or orphan it so that I can replace the PKGBUILD with an edited version that actually builds:
pkgname=aspell-nb _pkgname=aspell-no pkgver=0.50 pkgrel=2 pkgdesc="Norwegian Bokmål dictionary for aspell" url="http://aspell.net/" license="GPL" depends=('aspell') arch=('i686' 'x86_64') source=(ftp://ftp.gnu.org/gnu/aspell/dict/nb/${_pkgname}-${pkgver}-${pkgrel}.tar.bz2) md5sums=('b24b20ad02ce2a569f71f949b48823cc')
Alright, time to go on a quick run down of how this pkgbuild is outdated as heck: pretty much okay. till here.
build() { cd $startdir/src/${_pkgname}-${pkgver}-${pkgrel}
DO NOT USE $startdir. It it outdated and breaks on peoples systems that have a BUILDDIR specified.
./configure /usr/bin/make || return 1
Don't do this. Makepkg will do this itself. These || return 1 things are totally unneeded.
/usr/bin/make DESTDIR=$startdir/pkg install
Again, more startdir. Also, this should be part of a package() function, nto a build function. And in pacman 4.1, the $pkgdir is made unread/writeable before the package function is called (Allan, correct me if this is just your working branch) so calling $pkgdir (or $startdir/pkg) will just fail if it's called before a `package()`.
}
Here's what I'd make it look like: pkgname=aspell-nb pkgver=0.50.1 pkgrel=2 pkgdesc="Norwegian Bokmål dictionary for aspell" url="http://aspell.net/" license="GPL" depends=('aspell') arch=('i686' 'x86_64') source=(ftp://ftp.gnu.org/gnu/aspell/dict/nb/${pkgname}-${pkgver}-0.tar.bz2) md5sums=('b24b20ad02ce2a569f71f949b48823cc') build() { cd $srcdir/${pkgname}-${pkgver}-0 ./configure make } package() { cd $srcdir/${pkgname}-${pkgver}-0 make DESTDIR=$pkgdir install } And that builds fine. ps: next time give us the errors you got when trying to build this. Thanks, -- William Giokas | KaiSforza GnuPG Key: 0xE99A7F0F Fingerprint: F078 CFF2 45E8 1E72 6D5A 8653 CDF5 E7A5 E99A 7F0F
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 02/09/2013 03:33 AM, Third3ye wrote:
The AUR package "aspell-nb" doesn't build, is outdated and most likely abandoned. I suggest to either remove it or orphan it so that I can replace the PKGBUILD with an edited version that actually builds:
pkgname=aspell-nb _pkgname=aspell-no pkgver=0.50 pkgrel=2 pkgdesc="Norwegian Bokmål dictionary for aspell" url="http://aspell.net/" license="GPL" depends=('aspell') arch=('i686' 'x86_64') source=(ftp://ftp.gnu.org/gnu/aspell/dict/nb/${_pkgname}-${pkgver}-${pkgrel}.tar.bz2)
md5sums=('b24b20ad02ce2a569f71f949b48823cc')
build() { cd $startdir/src/${_pkgname}-${pkgver}-${pkgrel} ./configure /usr/bin/make || return 1 /usr/bin/make DESTDIR=$startdir/pkg install }
Please let advise if this PKGBUILD isn't following AUR guidelines.
Thank you.
Just a small note, pkgrel is the arch specific release number of a package's specific version, so you shouldn't use it in the source URL. What you currently have in the pkgrel (2) actually belong in pkgver (0.50-2) - -- Kindest Regards, Johannes Löthberg PGP Key ID: 583664EF Fingerprint: 14FD DCA8 4D41 FF41 78EF DD49 35CA 3661 5836 64EF -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCgAGBQJRFjSlAAoJEDXKNmFYNmTvcuAQAOgQeLd/QI0gPBClGyeU62yn 2u1Kbsf3lcj5F8Cr4eufG+ksQAV+aTyws9n2nEt7tImaqI/cbpumBhBbMvuEGWin SDfvUtfBETQt+amDpRw6K5UZekw6VUJz4FdQTHPSyOv3k3A2tOxfZp/8CD/HZeNx n3SxOHRSzir/+3DrxoJT5wUpqIULsa2B5AqLUO52/6gkq/ENGq62fCHhFh1h0ank PjROQPRAm+c3BUXaTw0yXXu3F208rX/yegAi5f0x75alzp2bPmZMAxeHodmVHGJq zNBSNor9zL/OVqXjzuez9TxBlOhRq8hF3WyWK+yOYR3dvfZgujz0CVEwxpX155dW MBxZM3AKMYqxaR7sp2apJDHNoQ1daZ5cAem66ly6e/t1DmMQoUEXTgIwWyhTid+I b/HBKcfKvOvf1VXiMLytuUp9qHpyRlW63wNEC0ItDU83BecFe7Hst8KdsrxWBr3a 18bz9HkWccPEAZWl0gWewkLTdnNUEXQ1el5XAUToRRGYhct/Br9QT/5olLaeA+kX dmoFqkaktwk1FO9eWueX9ou5RZsaXbVvQfNQwqxbq/1JEIEtN4+0mEh4MF28iQYb mOj6sPMdl1wtpz1xeIwQj/GpikJNECuxsvFT6/15ZhAKt9HiG3BU/KIb38aA/lEM dUEVReRJPFk0+mjQ+YoE =tDw9 -----END PGP SIGNATURE-----
On 02/09/2013 06:36 AM, Johannes Löthberg wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
The AUR package "aspell-nb" doesn't build, is outdated and most likely abandoned. I suggest to either remove it or orphan it so that I can replace the PKGBUILD with an edited version that actually builds:
pkgname=aspell-nb _pkgname=aspell-no pkgver=0.50 pkgrel=2 pkgdesc="Norwegian Bokmål dictionary for aspell" url="http://aspell.net/" license="GPL" depends=('aspell') arch=('i686' 'x86_64') source=(ftp://ftp.gnu.org/gnu/aspell/dict/nb/${_pkgname}-${pkgver}-${pkgrel}.tar.bz2)
md5sums=('b24b20ad02ce2a569f71f949b48823cc')
build() { cd $startdir/src/${_pkgname}-${pkgver}-${pkgrel} ./configure /usr/bin/make || return 1 /usr/bin/make DESTDIR=$startdir/pkg install }
Please let advise if this PKGBUILD isn't following AUR guidelines.
Thank you. Just a small note, pkgrel is the arch specific release number of a
On 02/09/2013 03:33 AM, Third3ye wrote: package's specific version, so you shouldn't use it in the source URL. What you currently have in the pkgrel (2) actually belong in pkgver (0.50-2)
You can't use hyphens in the pkgver; makepkg won't accept it as valid.
On Sat, Feb 09, 2013 at 02:13:41PM -0500, Limao Luo wrote:
On 02/09/2013 06:36 AM, Johannes Löthberg wrote:
The AUR package "aspell-nb" doesn't build, is outdated and most likely abandoned. I suggest to either remove it or orphan it so that I can replace the PKGBUILD with an edited version that actually builds:
pkgname=aspell-nb _pkgname=aspell-no pkgver=0.50 pkgrel=2 pkgdesc="Norwegian Bokmål dictionary for aspell" url="http://aspell.net/" license="GPL" depends=('aspell') arch=('i686' 'x86_64') source=(ftp://ftp.gnu.org/gnu/aspell/dict/nb/${_pkgname}-${pkgver}-${pkgrel}.tar.bz2)
md5sums=('b24b20ad02ce2a569f71f949b48823cc')
build() { cd $startdir/src/${_pkgname}-${pkgver}-${pkgrel} ./configure /usr/bin/make || return 1 /usr/bin/make DESTDIR=$startdir/pkg install }
Please let advise if this PKGBUILD isn't following AUR guidelines.
Thank you. Just a small note, pkgrel is the arch specific release number of a
On 02/09/2013 03:33 AM, Third3ye wrote: package's specific version, so you shouldn't use it in the source URL. What you currently have in the pkgrel (2) actually belong in pkgver (0.50-2)
You can't use hyphens in the pkgver; makepkg won't accept it as valid.
You are also only supposed to use ${foo} when it helps make updating easier. This could easily work against that. Just make it a number, or have a _pkgver variable that you use in the URL if you need that. -- William Giokas | KaiSforza GnuPG Key: 0xE99A7F0F Fingerprint: F078 CFF2 45E8 1E72 6D5A 8653 CDF5 E7A5 E99A 7F0F
participants (5)
-
Felix Yan
-
Johannes Löthberg
-
Limao Luo
-
Third3ye
-
William Giokas