I am not meaning a specific package, it could be a random package(s) On Mon, Aug 23, 2010 at 3:42 AM, Magnus Therning wrote:

On Mon, Aug 23, 2010 at 07:00, Nathan O wrote:

...

Hey I was wondering if somebody has time to look at my packages and see if they are of quality :) Some I adopted and got to add my name and email as maintainer and update the quality of it. The ones with my name and email are already updated. If you look you may see ndowens04 at gmail dot com or ndowens04+AUR at gmail dot com I may end up adding this email to the packages, I created this email address for AUR purposes so my main email address doesn't get cluttered.

I'm not sure I understand what you wrote above, but wouldn't it improve your chances of help if you actually listed the packages in question instead?

/M

-- Magnus Therning (OpenPGP: 0xAB4DFBA4) magnus＠therning．org Jabber: magnus＠therning．org http://therning.org/magnus identi.ca|twitter: magthe

Random: http://aur.archlinux.org/packages/coffeearc/coffeearc/PKGBUILD On Mon, Aug 23, 2010 at 3:47 AM, Magnus Therning wrote:

On Mon, Aug 23, 2010 at 09:44, Nathan O wrote:

...

I am not meaning a specific package, it could be a random package(s)

Huh?

I quote your email here:

Hey I was wondering if somebody has time to look at my packages and see if they are of quality :)

So, what packages should I choose randomly from?

/M

...

On Mon, Aug 23, 2010 at 3:42 AM, Magnus Therning

...

On Mon, Aug 23, 2010 at 07:00, Nathan O wrote:

...

Hey I was wondering if somebody has time to look at my packages and see if they are of quality :) Some I adopted and got to add my name and email as maintainer and update the quality of it. The ones with my name and email are already updated. If you look you may see ndowens04 at gmail dot com or ndowens04+AUR at gmail dot com I may end up adding this email to the packages, I created this email address for AUR purposes so my main email address doesn't get cluttered.

I'm not sure I understand what you wrote above, but wouldn't it improve your chances of help if you actually listed the packages in question instead?

/M

-- Magnus Therning (OpenPGP: 0xAB4DFBA4) magnus＠therning．org Jabber: magnus＠therning．org http://therning.org/magnus identi.ca|twitter: magthe

-- Magnus Therning (OpenPGP: 0xAB4DFBA4) magnus＠therning．org Jabber: magnus＠therning．org http://therning.org/magnus identi.ca|twitter: magthe

Some packages you may see has the previous maintainer listed and not mine yet. I got to update those sometime, I started on it but don't have any time left to do it, currently attempting to help somebody else with their package. On Mon, Aug 23, 2010 at 3:53 AM, Philipp Überbacher wrote:

...

Random: http://aur.archlinux.org/packages/coffeearc/coffeearc/PKGBUILD

On Mon, Aug 23, 2010 at 3:47 AM, Magnus Therning

...

On Mon, Aug 23, 2010 at 09:44, Nathan O wrote:

...

I am not meaning a specific package, it could be a random package(s)

Huh?

I quote your email here:

Hey I was wondering if somebody has time to look at my packages and see if they are of quality :)

So, what packages should I choose randomly from?

/M

...

On Mon, Aug 23, 2010 at 3:42 AM, Magnus Therning < magnus@therning.org wrote:

...

On Mon, Aug 23, 2010 at 07:00, Nathan O wrote:

...

Hey I was wondering if somebody has time to look at my packages and see if they are of quality :) Some I adopted and got to add my name and email as maintainer and update the quality of it. The ones with my name and email are already updated. If you look you may see ndowens04 at gmail dot com or ndowens04+AUR at gmail dot com I may end up adding this email to

Excerpts from Nathan O's message of 2010-08-23 10:50:11 +0200: the

...

...

...

...

...

packages, I created this email address for AUR purposes so my main email address doesn't get cluttered.

I'm not sure I understand what you wrote above, but wouldn't it improve your chances of help if you actually listed the packages in question instead?

/M

-- Magnus Therning (OpenPGP: 0xAB4DFBA4) magnus＠therning．org Jabber: magnus＠therning．org http://therning.org/magnus identi.ca|twitter: magthe

-- Magnus Therning (OpenPGP: 0xAB4DFBA4) magnus＠therning．org Jabber: magnus＠therning．org http://therning.org/magnus identi.ca|twitter: magthe

This link might help:

http://aur.archlinux.org/packages.php?O=0&K=ndowens&do_Search=Go&detail=1&C=0&SeB=m&SB=n&SO=a&PP=25 -- Philipp

-- "Wir stehen selbst enttäuscht und sehn betroffen / Den Vorhang zu und alle Fragen offen." Bertolt Brecht, Der gute Mensch von Sezuan

Nice that you took on algoscore. http://aur.archlinux.org/packages.php?ID=23577 Not sure whether you fixed it or I was low on coffee when I wrote the comment. Anyway, I noticed a few things: 1) your package is i686 only 2) "|| return 1" is used, which is apparently not really necessary anymore. You can remove them as you update. 3) I don't know its build system, but if it uses cmake you should use cmake to configure it correctly (paths) and then just install. You can use cmake interactively for example with "ccmake .". Non-interactively the options are prefixed with -D, example from one of my packages: cmake . -DCMAKE_INSTALL_PREFIX="/usr" \ -DWANT_MP3_ENCODE=ON \ -DUSE_SYSTEM_SLV2_LIBRARY=ON make DESTDIR="${pkgdir}" install "namcap" is in general very helpful, not sure it finds anything here though. I didn't know that one, looks nice, audiomove: http://aur.archlinux.org/packages.php?ID=24726 One obvious thing is this line: makedepends=('autoconf' 'automake>=1.6' 'pkgconfig>=0.9' 'patch') Those are covered by a package everyone who builds stuff should have installed. I don't remember the name. The next question is whether the patch is necessary and/or still applies, I didn't try, but it's worth checking. Next one, cdplay: http://aur.archlinux.org/packages.php?ID=1750 I see i686 only. This looks wrong for multiple reasons: install -Dm 755 cdplay $pkgdir/usr/bin install -Dm 755 eject $pkgdir/usr/bin 1) Wrong install syntax. From man install: -D create all leading components of DEST except the last, then copy SOURCE to DEST 2) The binaries, if they'd be installed correctly, would easily overwrite other binaries. I found 'cdplay' on my system, as part of cdtool from extra. I'm sure 'eject' is also prone to crash with something else, even if I don't have it on my system. Well, pacman would complain in those cases, but you should avoid them. That was my pseudo-random pick for now. Hope I could show you some of the possible pitfalls. I'm looking forward to trying audiomove and algoscore. Regards, -- Philipp -- "Wir stehen selbst enttäuscht und sehn betroffen / Den Vorhang zu und alle Fragen offen." Bertolt Brecht, Der gute Mensch von Sezuan

Thanks for the suggestions. I had to do install -Dm 755 cdplay $pkgdir/usr/bin install -Dm 755 eject $pkgdir/usr/bin If I remember correctly because you couldn't run make install or something, but I will check tonight if the eject one is nessisary. Algoscore was a pain in the butt, though it isn't fixed though, though I will try the cmake like you mentioned. There seems to be also something wrong with algoscore itself, if you try and run it, it will crash. Though I may try the svn version of algoscore and if it works, then I will request "algoscore" to be deleted and offer the svn version. On the audiomove package, I probably added my name and email and quickly went over the package for obvious problems. Probably at the time I was looking though AUR for some orphan packages I would want to take over and edited them quickly. I hope I improve my packages and you all will find them of quality :) Thanks On Mon, Aug 23, 2010 at 4:49 AM, Philipp Überbacher wrote:

One more pick, jackie: http://aur.archlinux.org/packages.php?ID=30652

- wrong upstream URL - i686 only? - makedepends=('make' 'gcc' 'pkgconfig') - PREFIX="/usr" twice? - || return 1

And just to mention one more thing: check the licenses, they are often wrong. Not in this case, and I forgot to check with the previous ones, but in general people tend to get them wrong. There is some page on the wiki that helps you translate the pacman string to human readable. GPL afaik translates to GPL2, GPL2 to GPL2 only or something.. but I'm never sure about that stuff. -- Philipp

-- "Wir stehen selbst enttäuscht und sehn betroffen / Den Vorhang zu und alle Fragen offen." Bertolt Brecht, Der gute Mensch von Sezuan

I will probably update it to: install -Dm 755 cdplay ${pkgdir}/usr/bin/ install -Dm 755 eject ${pkgdir}/usr/bin/ This way it will install in the dir, and less text :) On Mon, Aug 23, 2010 at 2:31 PM, Philipp Überbacher wrote:

Excerpts from Nathan O's message of 2010-08-23 19:50:51 +0200:

...

Thanks for the suggestions. I had to do install -Dm 755 cdplay $pkgdir/usr/bin install -Dm 755 eject $pkgdir/usr/bin

If I remember correctly because you couldn't run make install or something, but I will check tonight if the eject one is nessisary.

To make clear what's wrong with this: It installs cdplay as $pkgdir/usr/bin and then eject as $pkgdir/usr/bin. Not into, as. Check the /pkg directory to see it with your own eyes.

Correct syntax would be: install -Dm 755 cdplay $pkgdir/usr/bin/cdplay

I think almost everyone fell into this trap at one time or another.

Good luck :) -- Philipp

-- "Wir stehen selbst enttäuscht und sehn betroffen / Den Vorhang zu und alle Fragen offen." Bertolt Brecht, Der gute Mensch von Sezuan

On Tue, Aug 24, 2010 at 6:38 AM, Philipp Überbacher wrote:

Excerpts from Nathan O's message of 2010-08-24 06:38:29 +0200:

...

I will probably update it to: install -Dm 755 cdplay ${pkgdir}/usr/bin/ install -Dm 755 eject ${pkgdir}/usr/bin/

This way it will install in the dir, and less text :)

Nope, read again, or read 'man install' and look for '-D'. -- Philipp

-- "Wir stehen selbst enttäuscht und sehn betroffen / Den Vorhang zu und alle Fragen offen." Bertolt Brecht, Der gute Mensch von Sezuan

Ok, will look at it, generally that is how I install programs that doesn't automaticly install in the directories. I know if I accidently left the '/' off at the very end it would install as /usr/bin instead of installing in /usr/bin/

Thanks for showing the startdir spot. I edited it some time ago, but guess I over looked that when I was working on it. On Mon, Aug 23, 2010 at 3:59 AM, Ionuț Bîru wrote:

On 08/23/2010 11:50 AM, Nathan O wrote:

...

Random: http://aur.archlinux.org/packages/coffeearc/coffeearc/PKGBUILD

for that, add coffeearc.sh to sources array and instead of $startdir/coffeearc.sh use $srcdir/conffeearc.sh and remove || return 1 statements

-- Ionuț

On Mon, Aug 23, 2010 at 11:13 AM, Magnus Therning wrote:

On Mon, Aug 23, 2010 at 09:59, Ionuț Bîru wrote:

...

On 08/23/2010 11:50 AM, Nathan O wrote:

...

Random: http://aur.archlinux.org/packages/coffeearc/coffeearc/PKGBUILD

for that, add coffeearc.sh to sources array and instead of $startdir/coffeearc.sh use $srcdir/conffeearc.sh and remove || return 1 statements

I was trying to find a reference for the last point (removing '|| return 1') but couldn't find one.  In fact I found the opposite on the wiki[1].

makepkg changelog for pacman 3.4.0 - makepkg: - automatically aborts on any errors during packaging - changelogs are now included via the "changelog" variable - override pkgver, pkgrel and arch in split packages (FS#15955) - repackaging without a package() function is deprecated - stricter syntax checking for backup and optdepends entries - file stripping options are configurable - New --pkg flag to allow building specific package(s) from split PKGBUILDs (FS#15956) - build() function is now optional (FS#15147) - warn about reference to build root in a package (FS#14751) - configure source package destination with SRCPKGDEST - major internal refactoring of handling tests ("[" to "[[") - contrib/pactree: print reverse dependency tree

Here we go http://aur.archlinux.org/packages.php?ID=27485 is now updated with new version and suggestions On Mon, Aug 23, 2010 at 4:20 AM, Ionuț Bîru wrote:

On 08/23/2010 12:13 PM, Magnus Therning wrote:

...

On Mon, Aug 23, 2010 at 09:59, Ionuț Bîru wrote:

...

On 08/23/2010 11:50 AM, Nathan O wrote:

...

Random: http://aur.archlinux.org/packages/coffeearc/coffeearc/PKGBUILD

for that, add coffeearc.sh to sources array and instead of $startdir/coffeearc.sh use $srcdir/conffeearc.sh and remove || return 1 statements

I was trying to find a reference for the last point (removing '|| return 1') but couldn't find one. In fact I found the opposite on the wiki[1].

/M

[1] http://wiki.archlinux.org/index.php/Arch_Packaging_Standards#Package_Etiquet...

that's one of the new features in pacman 3.4 and wiki should be fixed http://projects.archlinux.org/pacman.git/tree/NEWS

- makepkg: - automatically aborts on any errors during packaging

-- Ionuț

On Mon, Aug 23, 2010 at 09:50, Nathan O wrote:

Random: http://aur.archlinux.org/packages/coffeearc/coffeearc/PKGBUILD

:-) So is your request for someone to look at any of the packages maintained by the user ndowens? Here are my comments on coffeearc: # Contributor: Nathan Owe <ndowens04 at gmail> pkgname=coffeearc pkgver=0_60a pkgrel=1 pkgdesc="java zip/other format archiver" -- This description can probably be improved somewhat. Looking at the upstream page it's described like this: "Coffeearc is a simple, extensible GUI archiver that interfaces with file-to-file command-line compression tools or special plugins which use the Coffeearc API." Maybe something like "Multi-format GUI archiver"? arch=('any') url="http://forge.simplana.de/projects/show/coffeearc" license=('gpl') depends=('java-runtime' 'bash') -- is bash really a dependency, or would sh be enough? source=(http://forge.simplana.de/attachments/download/15/Coffeearc_$pkgver.zip) -- this link gives me a 404 -- coffeearc.sh should be among the sources noextract=(*.jar) md5sums=('f3eab83a95175a3381679aab081e5d20') build() { cd $srcdir/Coffeearc_$pkgver install -d $pkgdir/usr/share/java/$pkgname $pkgdir/usr/bin || return 1 cp -rf libs profiles plugin.mf coffeearc.mf $pkgdir/usr/share/java/$pkgname || return 1 install -m755 coffeearc.jar $pkgdir/usr/share/java/$pkgname/coffeearc.jar || return 1 install -m755 $startdir/coffeearc.sh $pkgdir/usr/bin/coffeearc } # vim:set ts=2 sw=2 et: /M -- Magnus Therning                        (OpenPGP: 0xAB4DFBA4) magnus＠therning．org          Jabber: magnus＠therning．org http://therning.org/magnus         identi.ca|twitter: magthe

It's ok :) We do sometimes get things turned around in our minds :) On Mon, Aug 23, 2010 at 4:13 AM, Nathan O wrote:

I am currently editing the PKGBUILD, I changed bash to sh and removed $startdir and their is a new version of it so I am updating to that as well.

On Mon, Aug 23, 2010 at 4:11 AM, Magnus Therning wrote:

...

On Mon, Aug 23, 2010 at 09:50, Nathan O wrote:

...

Random: http://aur.archlinux.org/packages/coffeearc/coffeearc/PKGBUILD

:-)

So is your request for someone to look at any of the packages maintained by the user ndowens?

Here are my comments on coffeearc:

# Contributor: Nathan Owe <ndowens04 at gmail> pkgname=coffeearc pkgver=0_60a pkgrel=1 pkgdesc="java zip/other format archiver"

-- This description can probably be improved somewhat. Looking at the upstream page it's described like this:

"Coffeearc is a simple, extensible GUI archiver that interfaces with file-to-file command-line compression tools or special plugins which use the Coffeearc API."

Maybe something like "Multi-format GUI archiver"?

arch=('any') url="http://forge.simplana.de/projects/show/coffeearc" license=('gpl') depends=('java-runtime' 'bash')

-- is bash really a dependency, or would sh be enough?

source=( http://forge.simplana.de/attachments/download/15/Coffeearc_$pkgver.zip)

-- this link gives me a 404 -- coffeearc.sh should be among the sources

noextract=(*.jar) md5sums=('f3eab83a95175a3381679aab081e5d20')

build() { cd $srcdir/Coffeearc_$pkgver install -d $pkgdir/usr/share/java/$pkgname $pkgdir/usr/bin || return 1 cp -rf libs profiles plugin.mf coffeearc.mf $pkgdir/usr/share/java/$pkgname || return 1 install -m755 coffeearc.jar $pkgdir/usr/share/java/$pkgname/coffeearc.jar || return 1 install -m755 $startdir/coffeearc.sh $pkgdir/usr/bin/coffeearc

}

# vim:set ts=2 sw=2 et:

/M

-- Magnus Therning (OpenPGP: 0xAB4DFBA4) magnus＠therning．org Jabber: magnus＠therning．org http://therning.org/magnus identi.ca|twitter: magthe