[aur-general] swiften-git, spectrum2-git
Hi, I'd like to update the swiften-git [1] so it can be used again with spectrum2-git [2], both are orphaned. The upstream master of swift is no longer compatible with spectrum2. The swiften-git package is only used by spectrum2-git. To reflect the change from master to swift-2.x branch I'd like to change the name of of the swiften package swiften-git -> swiften2-git and change the depencency of spectrum2-git accordingly. With that, I'd like to request removal of the swiften-git package, as soon as swiften2-git is in place and spectrum2-git reflects this change. The proposed new PKGBUILDS are: swiften2-git https://gist.github.com/gdkags/08c0c9d42443e98eb4ff spectrum2-git https://gist.github.com/gdkags/6df5cb155356b7a9caee I do hope that I did everything according to AUR guidelines; packages were checked namcap. Dependencies were updated according to namcap output, they seemed sane to me, especially the deps that already were satisfied. PKGBUILDs were not modified except necessary changes. Also: are there optional makedeps? libcommuni can be used, but only if it is already installed. How does one reflect this? Same for mariadb. Feel free to correct any mistakes. This would be my first submissions so newbie mistakes are not out of the question. regards, David [1] https://aur.archlinux.org/packages/swiften-git/ [2] https://aur.archlinux.org/packages/spectrum2-git/
Make sure to wrap all variable interpolations in double quotes. For example: SWIFTEN_INSTALLDIR="${pkgdir}"/usr force-configure=1 This is also acceptable: SWIFTEN_INSTALLDIR="${pkgdir}/usr" force-configure=1 Also, did you forget to add ';' to the end of your `find` statement? I'm not familiar with what the `+` does. — Jeremy "Ichimonji10" Audet
Don't clone Git repositories manually. Pacman has the ability to do that itself. For an example, see [1]. I also believe it's good practice to make -git packages conflict with and provide non-git versions of the same package. I would place the following lines in your spectrum2-git package: provides=("${pkgname%-git}") conflicts=("${pkgname%-git}") Or: provides=(spectrum2) conflicts=(spectrum2) I also believe you can strip the empty lists from your spectrum2-git package. For example, `backup=()` [2] is unnecessary. — Jeremy "Ichimonji10" Audet [1] https://github.com/Ichimonji10/PKGBUILDs/blob/master/vim-hemisu-git/PKGBUILD [2] https://gist.github.com/gdkags/6df5cb155356b7a9caee#file-pkgbuild-L15
* Jeremy Audet <ichimonji10@gmail.com> [2014-05-16 10:57:18 -0400]:
Also, did you forget to add ';' to the end of your `find` statement? I'm not familiar with what the `+` does.
It essentially means the same as ;, but the command gets multiple arguments passed rather than just one, speeding the execution up. -- () ascii ribbon campaign - stop html mail www.asciiribbon.org /\ www.the-compiler.org | I love long mails http://email.is-not-s.ms/ Yow! Am I in Milwaukee?
Ooho! That's cool. Thanks for the info, Florian. — Jeremy
participants (3)
-
David Schmid
-
Florian Bruhin
-
Jeremy Audet