On 2 October 2013 19:42, <wolfgang_mader@brain-frog.de> wrote:

Dear list,

I read that if one feels the need to get comments of a PKGBUILD, this is the place to ask. This is my first PKGBUILD.

Source code to be package ===================== homepage: http://einspline.sourceforge.net/

From the homepage ---------------------------- einspline is a C library for the creation and evaluation of interpolating cubic basis splines (B-splines) in 1, 2, and 3 dimensions.

Output of namcap ============== namcap PKGBUILD: clean

If einspline package is not installed: namcap einspline-0.9.2-1-x86_64.pkg.tar.xz einspline W: Referenced library 'libeinspline.so.0' is an uninstalled dependency

If einspline packages is installed: namcap einspline-0.9.2-1-x86_64.pkg.tar.xz: clean

ldd is fine on all libeinspline*

Stuff to do ======== I am not sure if fftw is a build-only or a runtime dependency. I will figure that out.

Is there anything in the PKGBUILD which is wrong? Can I upload thes PKGBUILD to the AUR?

Thank you for your comments. Best, Wolfgang

You don't need to specify gcc, gcc-libs, or pkg-config, as these are satisfied by base and base-devel groups that people are expected to have installed when building AUR packages: https://wiki.archlinux.org/index.php/AUR#Prerequisites Other than that, looks good to me.

----------------------------------------

Date: Wed, 2 Oct 2013 20:42:42 +0200 From: wolfgang_mader@brain-frog.de To: aur-general@archlinux.org Subject: [aur-general] Review request of PKGBUILD: einspline

Dear list,

I read that if one feels the need to get comments of a PKGBUILD, this is the place to ask. This is my first PKGBUILD.

Source code to be package ===================== homepage: http://einspline.sourceforge.net/

From the homepage ---------------------------- einspline is a C library for the creation and evaluation of interpolating cubic basis splines (B-splines) in 1, 2, and 3 dimensions.

Output of namcap ============== namcap PKGBUILD: clean

If einspline package is not installed: namcap einspline-0.9.2-1-x86_64.pkg.tar.xz einspline W: Referenced library 'libeinspline.so.0' is an uninstalled dependency

If einspline packages is installed: namcap einspline-0.9.2-1-x86_64.pkg.tar.xz: clean

ldd is fine on all libeinspline*

Stuff to do ======== I am not sure if fftw is a build-only or a runtime dependency. I will figure that out.

Is there anything in the PKGBUILD which is wrong? Can I upload thes PKGBUILD to the AUR?

Thank you for your comments. Best, Wolfgang

The only other thing I see is that you don't need the versioned dep on fftw. It's at version 3.3.3 in the [extra] repo, so it's already taken care of.