[aur-general] afraiddns-git PKGBUILD: review and criticism welcome
Just throwing this out there. I'd welcome hints and advice for a more modern / more compliant way to write PKGBUILDs as of 2016. Eg. whether my install file overengineers things a bit, I could as well adjust my script to crash properly if no apikey is found. cheers! mar77i [0] https://aur.archlinux.org/packages/afraiddns-git [1] https://github.com/mar77i/afraiddns
You can add an empty file in the package for the key, and set it in the backup array, that way it won't overwrite existing files and will work without doing it via a shell script and not tracking the file in pacman. Your pkgver function should probably be below the list of static variables at the top, not in the middle of them. The license should be 'custom' unless it's a more standard one. See [1] for more info on that. If you don't use a build function, just don't include it. No point making a no-op one in there. Otherwise it looks good to me [1] https://wiki.archlinux.org/index.php/PKGBUILD#license Regards, Justin
The license should be 'custom' unless it's a more standard one. See [1] for more info on that.
Isn't it the MIT License? https://github.com/mar77i/afraiddns/blob/master/LICENSE https://opensource.org/licenses/MIT Regards, Michael
On Sun, Jun 5, 2016 at 1:46 PM, Michael S. <m.s.online@gmx.de> wrote:
Isn't it the MIT License? https://github.com/mar77i/afraiddns/blob/master/LICENSE https://opensource.org/licenses/MIT
Whoa thanks. Will fix. cheers! mar77i
participants (3)
-
Justin Dray
-
Martin Kühne
-
Michael S.