Also, are you sure that the dependencies are actually dependencies, that is, are required on runtime? Say, pacman and git rather look like makedependencies. But of course, I might be completely wrong.

Thank all for comments! I was referring to https://aur.archlinux.org/yay.git as a source of truth of golang PKGBUILD. On Mon, Aug 5, 2019 at 5:06 PM Robin Broda via aur-general < aur-general@archlinux.org> wrote:

On 8/5/19 9:51 AM, Vladimir Bauer via aur-general wrote:

...

Hi!

I have a PKGBUILD I would like to submit: https://github.com/vbauerster/getparty-PKGBUILD

What is further steps?

pacman, sudo, and git are not dependencies of your package. They should not be in depends=()

The PKGBUILD does not follow the golang packaging guidelines outlined on our wiki.

The git ls-remote dance in build() makes no sense. Pull the source from git directly instead. (If you do that, git becomes a makedep)

Stylistically, pkgdesc shouldn't end on punctuation.

References to $srcdir are redundant in your entire PKGBUILD.

-- Rob (coderobe)

O< ascii ribbon campaign - stop html mail - www.asciiribbon.org

-- Kind Regards, Vladimir Bauer

Please ignore my last reply, golang guideline is ok. How do I include a license? On Tue, Aug 6, 2019 at 11:26 AM Vladimir Bauer wrote:

Just FYI, It's not mandatory to export GOPATH with latest go 1.12. So I reckon guide at https://wiki.archlinux.org/index.php/Go_package_guidelines is out of date. Example there is doing much dancing around exporting GOPATH, which is unnecessary at all.

On Tue, Aug 6, 2019 at 9:53 AM Vladimir Bauer wrote:

...

Thank all for comments! I was referring to

https://aur.archlinux.org/yay.git

as a source of truth of golang PKGBUILD.

On Mon, Aug 5, 2019 at 5:06 PM Robin Broda via aur-general < aur-general@archlinux.org> wrote:

...

On 8/5/19 9:51 AM, Vladimir Bauer via aur-general wrote:

...

Hi!

I have a PKGBUILD I would like to submit: https://github.com/vbauerster/getparty-PKGBUILD

What is further steps?

pacman, sudo, and git are not dependencies of your package. They should not be in depends=()

The PKGBUILD does not follow the golang packaging guidelines outlined on our wiki.

The git ls-remote dance in build() makes no sense. Pull the source from git directly instead. (If you do that, git becomes a makedep)

Stylistically, pkgdesc shouldn't end on punctuation.

References to $srcdir are redundant in your entire PKGBUILD.

-- Rob (coderobe)

O< ascii ribbon campaign - stop html mail - www.asciiribbon.org

-- Kind Regards, Vladimir Bauer

-- Kind Regards, Vladimir Bauer

-- Kind Regards, Vladimir Bauer

On 06-08-2019 12:08, Iyán Méndez Veiga wrote:

El martes, 6 de agosto de 2019 8:56:28 (CEST) Vladimir Bauer via aur-general escribió:

...

Please ignore my last reply, golang guideline is ok. How do I include a license? https://wiki.archlinux.org/index.php/PKGBUILD#license

The license at https://github.com/vbauerster/getparty/blob/master/LICENSE mentions copyright 2016-2017 . Since there have been updates to the code after that, you should update the year. (You might want to do that every year around december 31) Lone