[aur-general] How To Submit Fix for AUR - Merge Request
Howdy All, This will (hopefully) be my first time submitting a merge request to an existing package (p4) within the AUR. The trouble I am having, it that it is unclear, for me, how this process should work. Reading the wiki page on this[1] mentions that it can be done. I have a local copy of the updated PKGBUILD file, verified that it works via makepkg --source and installs correctly via pacman. I have followed the Arch Package Standards[2] and everything looks to be in order. The trouble I am having is _how_ to submit the request via the AUR website. The wiki briefly alludes that I should: 1) Submit my version of the changes as a *new* package. For example: upload p4-abrenner as a new package on the submit page[3] 2) Then go ahead to the original package page, p4, and select the File Request link[4]? Is this correct? If not, what fundamental concept am I missing? Thank you in advanced for your help, -Adam [1]: https://wiki.archlinux.org/index.php/Arch_User_Repository#Other_requests [2]: https://wiki.archlinux.org/index.php/Arch_packaging_standards [3]: https://aur.archlinux.org/submit/ [4]: https://aur.archlinux.org/pkgbase/p4/request/ -- Adam Brenner <adam@aeb.io>
On 17/05, Adam Brenner wrote:
This will (hopefully) be my first time submitting a merge request to an existing package (p4) within the AUR. The trouble I am having, it that it is unclear, for me, how this process should work.
Merge requests are for merging two already existing packages into one. You seem to want something like git pull requests. There is no such thing, comment on the package and hope that the maintainer incorporates your changes. -- Sincerely, Johannes Löthberg PGP Key ID: 0x50FB9B273A9D0BB5 https://theos.kyriasis.com/~kyrias/
* Johannes Löthberg <johannes@kyriasis.com> [2015-05-17 23:31:16 +0200]:
On 17/05, Adam Brenner wrote:
This will (hopefully) be my first time submitting a merge request to an existing package (p4) within the AUR. The trouble I am having, it that it is unclear, for me, how this process should work.
Merge requests are for merging two already existing packages into one. You seem to want something like git pull requests. There is no such thing, comment on the package and hope that the maintainer incorporates your changes.
Note GitLab[1] calls those Merge Requests, that's maybe where the confusion comes from. Florian [1] https://about.gitlab.com/ -- http://www.the-compiler.org | me@the-compiler.org (Mail/XMPP) GPG: 916E B0C8 FD55 A072 | http://the-compiler.org/pubkey.asc I love long mails! | http://email.is-not-s.ms/
On 17/05, Florian Bruhin wrote:
* Johannes Löthberg <johannes@kyriasis.com> [2015-05-17 23:31:16 +0200]:
Merge requests are for merging two already existing packages into one. You seem to want something like git pull requests. There is no such thing, comment on the package and hope that the maintainer incorporates your changes.
Note GitLab[1] calls those Merge Requests, that's maybe where the confusion comes from.
IIRC gitorious did too now that I think about it. -- Sincerely, Johannes Löthberg PGP Key ID: 0x50FB9B273A9D0BB5 https://theos.kyriasis.com/~kyrias/
On Sun, 17 May 2015 14:27:34 -0700 Adam Brenner <adam@aeb.io> wrote:
Is this correct? If not, what fundamental concept am I missing?
Mainly that "merge" here is not used in the same context as a git merge. Merging on the AUR is used when a package is renamed. If you want the current maintainer to make changes to a PKGBUILD, you need to either leave a comment or contact them directly. Doug
On 05/17/2015 02:32 PM, Doug Newgard wrote:
On Sun, 17 May 2015 14:27:34 -0700 Adam Brenner <adam@aeb.io> wrote:
Is this correct? If not, what fundamental concept am I missing?
Mainly that "merge" here is not used in the same context as a git merge. Merging on the AUR is used when a package is renamed. If you want the current maintainer to make changes to a PKGBUILD, you need to either leave a comment or contact them directly.
Doug
Doug and Johannes, Thank you for your speedily reply! I will go ahead and contact the package maintainer directly. Thanks again! -Adam -- Adam Brenner <adam@aeb.io>
participants (4)
-
Adam Brenner
-
Doug Newgard
-
Florian Bruhin
-
Johannes Löthberg