[aur-general] PKGBUILD for touchcontrol-android
Dear AUR users, I wrote a PKGBUILD for "TouchControl For Android" (https://github.com/ternes3/TouchControl-for-Android) and I think this might be useful to others. Since this is my first one to publish I would like some advice/corrections for it before I am going to publish it. Cheers Jens Heyens
Hi, I'm not a packaging expert, however I noticed something that should be improved:
license=('custom:"Copyright (c) 2014 ternes3 / reBTSOFT" src:https://github.com/ternes3/TouchControl-for-Android#license')
This is a MIT license, not a custom one. https://en.wikipedia.org/wiki/MIT_License Regards, -- Rodolphe Breard
Am 11.11.2015 um 15:44 schrieb Rodolphe Breard:
Hi,
I'm not a packaging expert, however I noticed something that should be improved:
license=('custom:"Copyright (c) 2014 ternes3 / reBTSOFT" src:https://github.com/ternes3/TouchControl-for-Android#license')
This is a MIT license, not a custom one. https://en.wikipedia.org/wiki/MIT_License
Regards, Hello,
MIT and other BSD like license flavours _are_ custom licenses. Do a ls /usr/share/licenses/common, anything not listed there is custom license. Best Regards Stefan
On 12/11/2015 09:45, Stefan Husmann wrote:
MIT and other BSD like license flavours _are_ custom licenses.
For the sake of the license array, it is treated as a common license (license=('BSD'), license=('MIT'), license=('ZLIB') and
Any packages licensed under these four should have its own unique
Indeed, they are. I chose poor wording to express myself, so here is a quote from the PKGBUILD wiki page that shows what I wanted to say: license=('Python')), but technically each one is a custom license, because each one has its own copyright line. https://wiki.archlinux.org/index.php/PKGBUILD#license Maybe we should also quote the next line for more clarity for the original poster: license stored in /usr/share/licenses/pkgname. And an example: https://projects.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=p... Regards, -- Rodolphe Breard https://rodolphe.breard.tf/ PGP 6C41C1F2
On Wed, Nov 11, 2015 at 9:33 AM, Jens Heyens
Dear AUR users,
I wrote a PKGBUILD for "TouchControl For Android" (https://github.com/ternes3/TouchControl-for-Android) and I think this might be useful to others.
Since this is my first one to publish I would like some advice/corrections for it before I am going to publish it.
Cheers Jens Heyens
Is this really only available for x86_64? makepkg.conf already defines MAKEFLAGS="-j2" and allows the user to override this globally, no need to enforce this in the PKGBUILD. You specified an install file, but that file does not exist or you haven't attached it, so makepkg will fail with an error. There is no need to create the out directory, make will do that already. Other than that, I would modify the build() to use a single `cd "$srcdir/$pkgname"`, and use `install` instead of `cp`. It works either way, but `install` lets you avoid a separate `mkdir -p` and specify the permissions as well. Maybe that's just a personal style choice. ;) -- Eli Schwartz
participants (4)
-
Eli Schwartz
-
Jens Heyens
-
Rodolphe Breard
-
Stefan Husmann