On Wed, 2013-05-29 at 03:20 -0700, Felix Yan wrote:

On Wednesday, May 29, 2013 07:08:16 Agustin Ferrario wrote:

...

Hi I've made my first pkgbuild from scratch: https://github.com/py-crash/guake-solarized-Arch-Build Can somenone check it out and make the convinient critics before i uploaded to AUR?

git SCM source could use "git://github.com/coolwanglu/guake-colors-solarized.git" in sources array, no need to manually handle the clone/pull things since pacman 4.1.

And please quote "$pkgdir"/"${pkgdir}" in package().

License should be install "${pkgdir}/usr/share/licenses/${pkgname}/", while your "${pkgdir}/usr/share/licenses/guake-colors-solarized/" failed to indicate the correct path.

And you could make use of pkgver() to give $pkgver a more meaningful value. Refer to ArchWiki for this.

Regards, Felix Yan

What Felix said. Also such a simple patch can be achieved with a sed command. Source preparation now has a dedicated prepare() function, and you can add a conflicts line if you ever package a non git version. Please find an updated PKGBUILD here: http://sprunge.us/hbVY Cheers, -- Maxime

On Wed, 2013-05-29 at 19:03 +0800, Rashif Ray Rahman wrote:

On 29 May 2013 18:35, Maxime Gauduin wrote:

...

What Felix said. Also such a simple patch can be achieved with a sed command.

Just a note here: While the above is true for simple one-liners, I would recommend against getting in the habit of using sed to accomplish patching. A proper patch is much cleaner and conveys the message better. A patch knows exactly what to do, but with the sed command you may not.

-- GPG/PGP ID: C0711BF1

Of course, seding multiple lines would be quite inconvenient anyway, especially when they're not just substitutions. BTW I forgot a slash line 41, *doc}* should read *doc/}*. Cheers, -- Maxime

The PKGBUILD is now on aur: https://aur.archlinux.org/packages/guake-colors-solarized-git/ Hopefully is usefull for anyone Thanks to everyone who commented, Agustin Ferrario py_crash