[aur-general] package review and merge request
Could someone look over my package python2-django-extensions [1]? In particular, I'm curious about a namcap warning. [2] Namcap complains that python should be a dependency, because some scripts call python. However, this is a python 2 package, so that warning seems nonsensical. Thoughts? If all seems well, could someone merge django-extensions [3] into python2-django-extensions [1]? The current maintainer is OK with the merge, as per comments on the AUR. [1] https://aur.archlinux.org/packages/python2-django-extensions/ [2] http://pastebin.com/5VVhHnSQ [3] https://aur.archlinux.org/packages/django-extensions/
----------------------------------------
Date: Wed, 15 Jan 2014 10:41:30 -0500 From: ichimonji10@gmail.com To: aur-general@archlinux.org Subject: [aur-general] package review and merge request
Could someone look over my package python2-django-extensions [1]? In particular, I'm curious about a namcap warning. [2] Namcap complains that python should be a dependency, because some scripts call python. However, this is a python 2 package, so that warning seems nonsensical. Thoughts?
If all seems well, could someone merge django-extensions [3] into python2-django-extensions [1]? The current maintainer is OK with the merge, as per comments on the AUR.
[1] https://aur.archlinux.org/packages/python2-django-extensions/ [2] http://pastebin.com/5VVhHnSQ [3] https://aur.archlinux.org/packages/django-extensions/
Not nonsensical, if the script calls "python", it will run with python3. If they should be python2, you need to change the shebang yourself as part of the PKGBUILD.
Am 15.01.2014 20:07, schrieb Doug Newgard:
----------------------------------------
Date: Wed, 15 Jan 2014 10:41:30 -0500 From: ichimonji10@gmail.com To: aur-general@archlinux.org Subject: [aur-general] package review and merge request
Could someone look over my package python2-django-extensions [1]? In particular, I'm curious about a namcap warning. [2] Namcap complains that python should be a dependency, because some scripts call python. However, this is a python 2 package, so that warning seems nonsensical. Thoughts?
If all seems well, could someone merge django-extensions [3] into python2-django-extensions [1]? The current maintainer is OK with the merge, as per comments on the AUR.
[1] https://aur.archlinux.org/packages/python2-django-extensions/ [2] http://pastebin.com/5VVhHnSQ [3] https://aur.archlinux.org/packages/django-extensions/
Not nonsensical, if the script calls "python", it will run with python3. If they should be python2, you need to change the shebang yourself as part of the PKGBUILD.
As Doug already stated, the scripts have a python3 shebang, so you need to change it. You can add a prepare() function like this: https://paste.xinu.at/FprPT/bash Please make sure the scripts are actually intended for python2, though. Also, I don't think you need to include the LICENSE file directly, as the tarball has the same file and you are actually copying that. best regards, carstene1ns
----------------------------------------
Date: Wed, 15 Jan 2014 20:32:00 +0100 From: arch@carsten-teibes.de To: aur-general@archlinux.org Subject: Re: [aur-general] package review and merge request
Am 15.01.2014 20:07, schrieb Doug Newgard:
----------------------------------------
Date: Wed, 15 Jan 2014 10:41:30 -0500 From: ichimonji10@gmail.com To: aur-general@archlinux.org Subject: [aur-general] package review and merge request
Could someone look over my package python2-django-extensions [1]? In particular, I'm curious about a namcap warning. [2] Namcap complains that python should be a dependency, because some scripts call python. However, this is a python 2 package, so that warning seems nonsensical. Thoughts?
If all seems well, could someone merge django-extensions [3] into python2-django-extensions [1]? The current maintainer is OK with the merge, as per comments on the AUR.
[1] https://aur.archlinux.org/packages/python2-django-extensions/ [2] http://pastebin.com/5VVhHnSQ [3] https://aur.archlinux.org/packages/django-extensions/
Not nonsensical, if the script calls "python", it will run with python3. If they should be python2, you need to change the shebang yourself as part of the PKGBUILD.
As Doug already stated, the scripts have a python3 shebang, so you need to change it. You can add a prepare() function like this: https://paste.xinu.at/FprPT/bash Please make sure the scripts are actually intended for python2, though.
Also, I don't think you need to include the LICENSE file directly, as the tarball has the same file and you are actually copying that.
best regards, carstene1ns
Very close to the commands I would use, but I would suggest putting a "$" on the end of the match to make sure that "env python" is the end of the line. That safeguards against them changing the shebang in the future and you ending up with "env python22" if you don't notice the change. sed -i 's|bin/env python$|&2|' management/commands/{dumpscript,pipchecker}.py sed -i 's|bin/python$|&2|' utils/dia2django.py
Also, I don't think you need to include the LICENSE file directly, as the tarball has the same file and you are actually copying that.
Whoops. Thank you. I've fixed that.
Please make sure the scripts are actually intended for python2, though.
I just posted to the django-extensions google group/mailing list. Hopefully, they can clarify whether the scripts are compatible with Python 2. In the mean time, I've simply made the python2-django-extensions package depend upon Python 3 as well as Python 2. I don't exactly love the solution, but it seems to be the safest route. --Jeremy
User "Trbs" from the mailing list replied [1] promptly. He stated that the shebangs should not exist and suggested I create a patch to remove them entirely. (He also removed the shebangs from the official repo.) Thanks for the sample code, Doug and carstene1ns. I used it as the basis for a prepare() function that removes shebangs. I tested the package [2] on a python 2 django project I have handy. In particular, I made sure to exercise the dumpscript.py and pipchecker.py scripts. No problems. [1] https://groups.google.com/d/msg/django-extensions/KBXVARby3ps/JRfU2kiG0foJ [2] https://aur.archlinux.org/packages/py/python2-django-extensions/PKGBUILD
Could django-extensions [1] be merged into python2-django-extensions [2]? [1] https://aur.archlinux.org/packages/django-extensions/ [2] https://aur.archlinux.org/packages/python2-django-extensions/
On Sunday, January 19, 2014 19:12:32 Jeremy Audet wrote:
Could django-extensions [1] be merged into python2-django-extensions [2]?
[1] https://aur.archlinux.org/packages/django-extensions/ [2] https://aur.archlinux.org/packages/python2-django-extensions/
Merged, thanks. Regards, Felix Yan
participants (4)
-
carstene1ns
-
Doug Newgard
-
Felix Yan
-
Jeremy Audet