When you do grep like that, you should use two [[, to make sure that it doesn't care about spaces. http://stackoverflow.com/questions/669452/is-preferable-over-in-bash-scripts and in this case, you don't need them at all if grep -qi 'utf-*8' /etc/locale.conf; then The above will fail and not execute the 'then' portion of the if statement if the grep fails, the -q also prevents it from out putting anything, and it will return an exit status of not one. Even with that, the current PKGBUILD looks fine... just wanted to point it out. Daniel On Tue, Feb 10, 2015 at 7:02 PM, stef204 wrote:

10.02.2015, 17:20, "David Phillips" :

...

. There are a few points that need clearing up before your PKGBUILD can be released for use.

I'm probably really crap at explaining this, but it was worth a shot.

Dave,

Thanks for feedback. It's helpful.

You're right about just using ./configure --prefix=/user (only that).

I took a existing build and tried to update it to new standard, which uses package () , etc.

And modified very little, really, above package(). I did see the oddity in the ./configure option but got so involved in the error I was getting from package () that I forgot to backtrack,

Anyway, here is an updated version.

https://bpaste.net/show/8fdb2226c3d7

Better?

Thanks.

* stef204 [2015-02-10 18:02:15 -0700]:

Anyway, here is an updated version.

https://bpaste.net/show/8fdb2226c3d7

Better?

Some more remarks: - Is it really a good idea to check /etc/locale.conf? Wouldn't something like [[ ${LANG,,} == *utf-8* ]] be more appropriate? (the ,, converts it to lower-case, see http://wiki.bash-hackers.org/syntax/pe#case_modification ) - I'd move the 'cd' in line 32 to the top of package() and remove the second one in line 35, but that's just a small style issue Flo -- http://www.the-compiler.org | me@the-compiler.org (Mail/XMPP) GPG: 916E B0C8 FD55 A072 | http://the-compiler.org/pubkey.asc I love long mails! | http://email.is-not-s.ms/

10.02.2015, 22:33, "David Phillips" :

I question whether checking the locale is appropriate at all. It isn't something that should be compiled-in, surely?

Dave, The INSTALL file in he source states: "the source files of the fortunes are coded in ISO-8859-15 format, and are installed as they are by default. If you want to use an other format, you can specify it by executing the configure script with the option --with-charset=charset, where charset represents the format to use. To have the possibility to use this option, you should have the recode program installed on your system. To get the list of the supported formats, you can use the -l option of the recode program." That is why the check seems to be needed; but what do I know...I'm just a n00b... :) Set me straight as needed, I am not being ironic here; just trying to learn and improve.

10.02.2015, 22:22, "Florian Bruhin" :

Some more remarks:

- Is it really a good idea to check /etc/locale.conf? Wouldn't   something like   [[ ${LANG,,} == *utf-8* ]]   be more appropriate?

I don't know. Is it? Is $LANG set automatically or all arch users will have that set for sure? Does it take precedence over /etc/locale.conf ? (Or does it read it from there?) I'm open to suggestions as to which way to best do this; see my reply to David as well, with regards to why this even needs to be checked.

  (the ,, converts it to lower-case, see   http://wiki.bash-hackers.org/syntax/pe#case_modification )

- I'd move the 'cd' in line 32 to the top of package() and remove the   second one in line 35, but that's just a small style issue

OK, I cleaned up the style. And, so far, I followed the suggestion: if grep -qi 'utf-*8' /etc/locale.conf; then (Ignore line 21 for now, will remove it later). @everyone i this thread: Here is revised (cleaned up) version: https://bpaste.net/show/35fd72050984 Thanks for any additional feedback, as needed.