On 2011-01-14 <10:30:45>, Evangelos Foutras wrote:

On Fri, Jan 14, 2011 at 10:21 AM, Philipp Gesang <megas.kapaneus@googlemail.com> wrote:

...

Hello archers,

for my own use I made a pkgbuild of luaGRAPH[1] and I’d like to share it via aur. As this will be my first contribution I guess it can’t hurt to have it reviewed here by more experienced users before submitting.

- Get rid of the 'return 1' statements; they are not needed since pacman/makepkg 3.4.0. - Remove the name of the package from pkgdesc ("LuaGRAPH is a binary module ..." becomes "A binary module ..."). - The LICENSE file is part of the tarball, so remove it from the source array.

Other than these minor observations, it looks alright. Thanks for contributing. :)

Hi Evangelos, thanks to you and cantabile I happily append a revised pkgbuild. I’m going to upload it tomorrow evening unless anybody objects till then. Best regard, Philipp

On 2011-01-14 <09:39:28>, Philipp Überbacher wrote:

Excerpts from Philipp Gesang's message of 2011-01-14 09:21:57 +0100:

...

Hello archers,

for my own use I made a pkgbuild of luaGRAPH[1] and I’d like to share it via aur. As this will be my first contribution I guess it can’t hurt to have it reviewed here by more experienced users before submitting.

Thanks for your opinion, Philipp

[1] http://luagraph.luaforge.net/ http://luaforge.net/projects/luagraph/

# Maintainer: Philipp Gesang <megas dot kapaneus at gmail dot com> pkgname=luagraph pkgver=1.0.4 pkgrel=1 pkgdesc="LuaGRAPH is a binary module to create, manipulate, layout and render graphs using the Lua programming language." arch=("any") url="http://luaforge.net/projects/${pkgname}" license=("MIT") depends=("lua" "graphviz") source=("http://luaforge.net/frs/download.php/4528/${pkgname}-${pkgver}.tar.gz" "LICENSE") md5sums=("f2f71bcbabf243792e230665b1403f58" "814f32bd3d115e90f777e7baf714338d")

build() { cd "${srcdir}/${pkgname}-${pkgver}" || return 1 make install -Dm0755 graph/core.so "${pkgdir}/usr/lib/lua/5.1/graph/core.so" || return 1 install -Dm0644 graph.lua "${pkgdir}/usr/lib/lua/5.1/graph.lua" || return 1 install -Dm0644 LICENSE "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE" || return 1 }

Is there a reason to distribute it as a binary? Compiling from source is the preferred way. Link to source tarballs: http://luaforge.net/frs/?group_id=237&release_id=1626

Also, binary packages should be postfixed with -bin.

Hi Philipp, “binary module” in Lua doesn’t mean that it has to be distributed as binary but rather that it is a compiled library as opposed to modules written entirely in Lua. In fact, the “pkgdesc” string is taken right from the project’s page. Lua users will understand. Best regards, Philipp

On 14/01/11 11:28, Philipp Überbacher wrote:

Might be, but I see that the source is available, hence it's possible to build and install instead of downloading binaries. Building from source is the preferred way. If the source is available and you download binaries anyway you should postfix the name with -bin so that others can create the 'normal' package.

He's building from source, as far as I can see. He's using the same tarball you linked to previously.