[aur-general] Package from official repos build from git, instead of official upstream release - Was: TU Application - Dustin Falgout
On Wed, 2 Mar 2016 12:28:58 +0100, Levente Polyak wrote:
The simplest way to make these "static" if you want to import them into [community] is to pin the git source using #commit=1234567.
Also in that case, only if you have a sane reason to not stick to the upstream released versions. If there is no real reason one should follow the upstream released version so the commit hash should not be arbitrary but the one of the release. In general we want to follow upstream releases.
Would this [A] be a reason to provide an official package from git?
If so, I'll report a request to build jack2 from git.
Regards,
Ralf
[A]
Begin forwarded message:
Date: Sat, 27 Feb 2016 20:01:05 +0100
From: Ralf Mardorf
To: LAU
On 02/03, Ralf Mardorf wrote:
On Wed, 2 Mar 2016 12:28:58 +0100, Levente Polyak wrote:
The simplest way to make these "static" if you want to import them into [community] is to pin the git source using #commit=1234567.
Also in that case, only if you have a sane reason to not stick to the upstream released versions. If there is no real reason one should follow the upstream released version so the commit hash should not be arbitrary but the one of the release. In general we want to follow upstream releases.
Would this [A] be a reason to provide an official package from git? If so, I'll report a request to build jack2 from git.
...
Date: Wed, 24 Feb 2016 00:38:22 +0100 From: Robin Gareus To: ardour-users@lists.ardour.org Subject: Re: [Ardour-Users] Export hangs after script executing
[snip]
1.9.11 (actually git: 1.9.10-g1ed50c92) is known to be good WRT to this freewheeling bug.
That's more of a reason to backport the fix rather than getting all unreleased commits in the package. Or get them to make a new release. -- Sincerely, Johannes Löthberg PGP Key ID: 0x50FB9B273A9D0BB5 https://theos.kyriasis.com/~kyrias/
On 03/02/2016 07:06 AM, Ralf Mardorf wrote:
On Wed, 2 Mar 2016 12:28:58 +0100, Levente Polyak wrote:
The simplest way to make these "static" if you want to import them into [community] is to pin the git source using #commit=1234567.
Also in that case, only if you have a sane reason to not stick to the upstream released versions. If there is no real reason one should follow the upstream released version so the commit hash should not be arbitrary but the one of the release. In general we want to follow upstream releases.
Would this [A] be a reason to provide an official package from git? If so, I'll report a request to build jack2 from git.
[snip]
I would consider providing an official package from git only in the case of something like trash-cli. (I maintained it in the AUR before Pierre Neidhardt sponsored it for community.) Upstream development is essentially dead (the developer has moved on and doesn't really have time for trash-cli anymore), and instant segfaults are only fixed through an unmerged pull request. So it isn't reasonable to wait for a release, and I just pulled the latest commit hash (via tarball) -- plus the PR. I consider that to be the "latest version" and I was intending to update if and when a particular new commit felt valuable. Other projects might not do releases, just snapshots. Bu if an active project does releases then the appropriate response is probably as Johannes said, to backport that patch while waiting for a stable release. -- Eli Schwartz
Thank you Johannes and Eli, this sounds reasonable, especially since we've got jack2 provided by ABS and AUR to work around this issue. Regards, Ralf
PS: I've got a question regarding the jack2-git package from AUR. The maintainer does use $ git rev-list --count master 3425 [1], but IMO pkgver should be $ git describe|sed -r 's/^v//;s/([^-]*-g)/r\1/;s/-/./g' 1.9.10.r177.g7bdad49 since this is the correct version number, as used by https://www.archlinux.org/packages/community/x86_64/jack2/ . Is there no recommendation what to use for AUR PKGBUILD pkgver? Regards, Ralf [1] "pkgver() { cd jack2 # get a plain number echo $(git rev-list --count master) }" - https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=jack2-git
On 03/02/2016 11:42 AM, Ralf Mardorf wrote:
PS:
I've got a question regarding the jack2-git package from AUR.
The maintainer does use
$ git rev-list --count master 3425
[1], but IMO pkgver should be
$ git describe|sed -r 's/^v//;s/([^-]*-g)/r\1/;s/-/./g' 1.9.10.r177.g7bdad49
since this is the correct version number, as used by https://www.archlinux.org/packages/community/x86_64/jack2/ .
Is there no recommendation what to use for AUR PKGBUILD pkgver?
Regards, Ralf
[1] "pkgver() { cd jack2 # get a plain number echo $(git rev-list --count master) }" - https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=jack2-git
That is a super-ugly pkgver which is only supposed to be used as a method of last resort for packages that have *no* normal pkgver. You should suggest that the AUR maintainer fix the pkgver (and add an epoch). -- Eli Schwartz
On Wed, 2 Mar 2016 12:22:09 -0500, Eli Schwartz wrote:
On 03/02/2016 11:42 AM, Ralf Mardorf wrote:
"pkgver() { cd jack2 # get a plain number echo $(git rev-list --count master) }" - https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=jack2-git
That is a super-ugly pkgver which is only supposed to be used as a method of last resort for packages that have *no* normal pkgver.
You should suggest that the AUR maintainer fix the pkgver (and add an epoch).
Hi Eli, that's my opinion too, so I've done this by a comment on 2016-02-27. Assumed the maintainer shouldn't reply, resp. edit the PKGBUILD within 2 weeks, I'll repeat the request to use 'git describe'. Regards, Ralf
On 03/02/2016 01:05 PM, Ralf Mardorf wrote:
On Wed, 2 Mar 2016 12:22:09 -0500, Eli Schwartz wrote:
On 03/02/2016 11:42 AM, Ralf Mardorf wrote:
"pkgver() { cd jack2 # get a plain number echo $(git rev-list --count master) }" - https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=jack2-git
That is a super-ugly pkgver which is only supposed to be used as a method of last resort for packages that have *no* normal pkgver.
You should suggest that the AUR maintainer fix the pkgver (and add an epoch).
Hi Eli,
that's my opinion too, so I've done this by a comment on 2016-02-27. Assumed the maintainer shouldn't reply, resp. edit the PKGBUILD within 2 weeks, I'll repeat the request to use 'git describe'.
Regards, Ralf
And speaking of ugly, learn to love the Pastebin[1] when posting files to an AUR comment. ;) [1] http://pastebin.com/ -- Eli Schwartz
On Wed, 2 Mar 2016 13:15:39 -0500, Eli Schwartz wrote:
And speaking of ugly, learn to love the Pastebin[1] when posting files to an AUR comment. ;)
I was and I'm short in time. Actually I even have a Patebin account. Hopefully I can edit my comment within the next days, remove the PKGBUILD from the comment and add a link to a fixed version of the PKGBUILD, since regarding a typo I missed ... echo $(git describe|cut -d"v" -f2|sed -r 's/^V//;s/([^-]*-g)/r\1/;s/-/./g') ^^^ ^^^ should read 'v' ... I considered to cut the 'v', not to mention that the formatting got lost and that we shouldn't misuse comments for unrelated topics, but regarding an exceptionally serious issue with the official jack2 release from upstream, I acted without thinking and without having enough time to do better. My apologies, Ralf
Den 02-03-2016 kl. 19:15 skrev Eli Schwartz:
And speaking of ugly, learn to love the Pastebin[1] when posting files to an AUR comment. ;)
And speaking of Pastebin.com:
Note: pastebin.com is blocked for some people and has a history of annoying issues (javascript, adverts, poor formatting, etc)." https://wiki.archlinux.org/index.php/List_of_applications#Pastebin_clients
There are tons of other (and better (and free-er)) pastebin services. -- Namasté, Frederik “Freso” S. Olesen https://freso.dk/ AUR: https://aur.archlinux.org/account/Freso Wiki: https://wiki.archlinux.org/index.php/User:Freso
Den 02-03-2016 kl. 17:42 skrev Ralf Mardorf:
Is there no recommendation what to use for AUR PKGBUILD pkgver?
There's this: https://wiki.archlinux.org/index.php/VCS_package_guidelines#The_pkgver.28.29... -- Namasté, Frederik “Freso” S. Olesen https://freso.dk/ AUR: https://aur.archlinux.org/account/Freso Wiki: https://wiki.archlinux.org/index.php/User:Freso
participants (4)
-
Eli Schwartz
-
Frederik “Freso” S. Olesen
-
Johannes Löthberg
-
Ralf Mardorf