[aur-general] TU application -- Santiago Torres-Arias
27 Jul
2018
27 Jul
'18
3:16 p.m.
Hello everyone,
Formalities first, Christian Rebischke (Shibumi) is sponsoring my application, although I'd like to thank so many people for their feedback, help, guidance and counsel in all-things-Arch*.
Apologies for being somewhat late with the ztrawchse review.
argon2-git:
- CC-0 is, apparently, not common enough to be in the licenses package. As such, the license should be marked as 'custom:CC-0' and installed to /usr/share/licenses/$pkgname/ see how core/argon2 does this
git-latexdiff:
- unquoted srcdir/pkgdir
- license is not, in fact, GPL
- the source file has a unique name, but then you told makepkg to rename it to something non-unique. I.. must admit this is new to me...
in-toto:
- sources seem to come with a testsuite, this should be run in a check() function
python-securesystemslib:
- the check() function does not accept depends, this is broken
- multiple depends are deleted and overridden in the package() function
- empty optdepends array can be deleted
- tox doesn't really test what needs testing, code should be tested using the native testsuite hooked up to the packaged system dependencies
- license is the literal file (rather than a file within the directory of this name): /usr/share/licenses/python-securesystemslib
reprotest:
- multiple depends are deleted and overridden in the package() function
- optdepends could use description of what additional functionality they provide when installed
Thanks for the feedback!
I'll apply this changes as soon as I get back from work :)
-Santiago.
1957
Age (days ago)
1957
Last active (days ago)
0 comments
1 participants
participants (1)
-
Santiago Torres-Arias