On 08/05/14 07:46, Xyne wrote:

On 2014-05-08 06:24 +1000 Steven Haigh wrote:

...

Hi guys,

I'm trying to take back the bacula AUR package to continue maintaining. https://aur.archlinux.org/packages/bacula/

I am the submitter of the original AUR package: Submitter: CRCinAU

I am listed as a maintainer in the PKGBUILD file: https://aur.archlinux.org/packages/ba/bacula/PKGBUILD

# Maintainers: Steven Haigh <netwiz@crc.id.au> # goll <adrian.goll+aur[at]gmail>

I have tried contacting goll to update the package, but have not heard a response for some time (and a few revisions).

I hereby request that either the package be orphaned so I can pick it up and update it in future, or the maintainer be changed by to myself (ie the submitter).

Thanks.

Orphaned.

Is the temporary _instdir really necessary? It looks like an ugly hack at first glance. Regardless, it definitely shouldn't be creating directories in $PWD. Please change that to "$srcdir/build" or something similar.

The install commands in the package function should include explicit permissions as well, e.g. "install -Dm644 ...". If you really can't use the makefile install function then I would replace most of those commands with for loops, e.g

for script in "$_instdir"/etc/bacula/scripts/* do install -Dm644 "$script" "$pkgdir/etc/bacula/scripts/${script##*/}" done

Also note the quoting of all path variables to prevent word expansion on paths containing spaces.

All taken onboard. I'll implement these in future package updates. -- Steven Haigh Email: netwiz@crc.id.au Web: http://www.crc.id.au Phone: (03) 9001 6090 - 0412 935 897 Fax: (03) 8338 0299