On Tue 17 Sep 2013 at 21:36, Xyne wrote:

If you rename the package (uppity-git -> uppity), do you plan to modify it so that it builds from fixed tags? If not then it should not be renamed as it remains a git package. Renaming it would be against our guidelines.

I will do so.

I also noticed that you are using "cd $_gitname" in the PKGBUILD. Please see my reply to someone else about why this is incorrect[1] and update it to do everything in "$srcdir/$_gitname".

$_gitname is $srcdir/$_gitname, not $startdir/$_gitname, so it's fine. To double-check I set $SRCDEST to point somewhere else and it builds fine still.

[...] [1] https://mailman.archlinux.org/pipermail/aur-general/2013-September/025124.ht...

-- Jonathan Steel

On 18 September 2013 06:18, Xyne wrote:

Jonathan Steel wrote:

...

$_gitname is $srcdir/$_gitname, not $startdir/$_gitname, so it's fine. To double-check I set $SRCDEST to point somewhere else and it builds fine still.

You're right. Looking at the source of makepkg, I see now that all functions cd into $srcdir. I still prefer the "$srcdir/$_gitname" format as it is explicit and future-proof, but there is currently no technical reason to do so.

I was told by at least one pacman dev (can't quite recall who or via which communication channel) that this practice should not be obsoleted; we should continue to navigate into $srcdir before doing anything. -- GPG/PGP ID: C0711BF1