[aur-general] Request to check my PKGBUILD
I made a PKGBUILD for the "Badlion Client" software, but there will be some warnings during the build. How can I deal with this problem? If PKGBUILD has any other questions, please let me know.
tips: Badlion Client is a third-party launcher for Minecraft games. To run the game, you need to have a genuine Minecraft Java Edition account.
On 7/12/21 11:50 PM, 悲剧小白 via aur-general wrote:
I made a PKGBUILD for the "Badlion Client" software, but there will be some warnings during the build. How can I deal with this problem? If PKGBUILD has any other questions, please let me know.
tips: Badlion Client is a third-party launcher for Minecraft games. To run the game, you need to have a genuine Minecraft Java Edition account.
Hmm, what's the purpose of replacing the AppRun script? In fact, why not just run the binary directly?
Also I notice in your PKGBUILD you chmod -R 755 a directory tree... you should probably not be marking the files inside there, as executable. They're just images. Why do you them chmod -R 644 some of the files?
Maybe you should consider using:
chmod -R ugo+rwX
(Also: this once, you forgot to quote $pkgdir correctly.)
1.The AppRun file specifies the location of some lib files of the software. These variables seem to be called when the software is running.
2.The purpose of "chmod -R 755" is to change the permissions of these folders, but it also affects the pictures in the final directory, so use "chmod 644" to change the permissions of the pictures back. If you do not change the permissions of these folders, their permissions in the source directory are 600, and a warning will be output during installation that the directory permissions in the installation package are inconsistent with the permissions in the file system (In a clean ArchLinux environment, the default permission of the /usr/share/icons folder is 755)
Finally, please point out where I did not use $pkgdir correctly, I will check again
------------------ 原始邮件 ------------------ 发件人: "Discussion about the Arch User Repository (AUR)" <aur-general@lists.archlinux.org>; 发送时间: 2021年7月13日(星期二) 中午12:21 收件人: "aur-general"<aur-general@lists.archlinux.org>; 抄送: "Eli Schwartz"<eschwartz@archlinux.org>; 主题: Re: [aur-general] Request to check my PKGBUILD
On 7/12/21 11:50 PM, 悲剧小白 via aur-general wrote: > I made a PKGBUILD for the "Badlion Client" software, but there will > be some warnings during the build. How can I deal with this problem? > If PKGBUILD has any other questions, please let me know. > > tips: Badlion Client is a third-party launcher for Minecraft games. > To run the game, you need to have a genuine Minecraft Java Edition > account.
Hmm, what's the purpose of replacing the AppRun script? In fact, why not just run the binary directly?
Also I notice in your PKGBUILD you chmod -R 755 a directory tree... you should probably not be marking the files inside there, as executable. They're just images. Why do you them chmod -R 644 some of the files?
Maybe you should consider using:
chmod -R ugo+rwX
(Also: this once, you forgot to quote $pkgdir correctly.)
On 7/13/21 12:38 AM, 悲剧小白 via aur-general wrote:
1.The AppRun file specifies the location of some lib files of the software. These variables seem to be called when the software is running.
If this is just about lib files, you only need to set LD_LIBRARY_PATH, not some... stuff used to invoke a EULA???
Or you could use the patchelf program to add an rpath entry.
2.The purpose of "chmod -R 755" is to change the permissions of these folders, but it also affects the pictures in the final directory, so use "chmod 644" to change the permissions of the pictures back. If you do not change the permissions of these folders, their permissions in the source directory are 600, and a warning will be output during installation that the directory permissions in the installation package are inconsistent with the permissions in the file system (In a clean ArchLinux environment, the default permission of the /usr/share/icons folder is 755)
Can you re-check what I suggested? None of this should be a problem if you do the first chmod correctly.
More generally please see the discussion for "symbolic mode" in the chmod manpage.
Finally, please point out where I did not use $pkgdir correctly, I will check again
chmod -R 755 $pkgdir/usr/share/icons chmod -R 644 $pkgdir/usr/share/icons/hicolor/*/apps/BadlionClient.png
thanks for your suggestion
> If this is just about lib files, you only need to set LD_LIBRARY_PATH, > not some... stuff used to invoke a EULA???
I think it has nothing to do with EULA. The main interface of the game has a link related to EULA, but this is a link to the official website.
I tried to execute the binary program after defining the "LD_LIBRARY_PATH" variable in bash. The result is a crash after the window appears.
I suspect that other variables are needed. I wrote an AppRun (attachment) based on the source AppRun file, and the program runs normally, so I think this is the minimum variable required by the program.
> chmod -R 755 $pkgdir/usr/share/icons > chmod -R 644 $pkgdir/usr/share/icons/hicolor/*/apps/BadlionClient.png
I changed these two lines to "chmod -R go+rX $pkgdir/usr/share/icons"
On Tuesday, July 13, 2021 2:13:17 PM CST 悲剧小白 via aur-general wrote:
I changed these two lines to "chmod -R go+rX $pkgdir/usr/share/icons"
The "quote" Eli mentioned means adding quotation marks around $pkgdir, to avoid issues with whitespaces in the path.
participants (3)
-
Eli Schwartz
-
Felix Yan
-
悲剧小白