[aur-general] package review
Hi, Would anyone be so nice as to review my libgroove package? The current package [1] and proposed package [2] are both on GitHub. The package is for a C library, and I am hoping to add a pkg-config config file (libgroove.pc) to the package. I've never written one of these before, and am worried about accidentally trashing users' systems. [1] https://github.com/Ichimonji10/PKGBUILDs/tree/master/libgroove [2] https://github.com/Ichimonji10/PKGBUILDs/tree/libgroove-pkgconfig/libgroove — Jeremy "Ichimonji10" Audet
On 04/10, Jeremy Audet wrote:
Hi,
Would anyone be so nice as to review my libgroove package? The current package [1] and proposed package [2] are both on GitHub. The package is for a C library, and I am hoping to add a pkg-config config file (libgroove.pc) to the package. I've never written one of these before, and am worried about accidentally trashing users' systems.
It looks fine, and shouldn't really make a difference, but you should contact upstream about including it before adding it as a downstream change. -- Sincerely, Johannes Löthberg PGP Key ID: 0x50FB9B273A9D0BB5 https://keybase.io/johannes
I wonder why you have a test program but don't use it in the test()
function of your PKGBUILD? Not that this is needed, but as soon as I saw
'test.c', I thought I would find a test() too.
Furthermore, your package looks reasonable to me.
2014-10-04 12:55 GMT-03:00 Jeremy Audet
Hi,
Would anyone be so nice as to review my libgroove package? The current package [1] and proposed package [2] are both on GitHub. The package is for a C library, and I am hoping to add a pkg-config config file (libgroove.pc) to the package. I've never written one of these before, and am worried about accidentally trashing users' systems.
[1] https://github.com/Ichimonji10/PKGBUILDs/tree/master/libgroove [2] https://github.com/Ichimonji10/PKGBUILDs/tree/libgroove-pkgconfig/libgroove
— Jeremy "Ichimonji10" Audet
-- - Thiago
you should contact upstream about including it before adding it as a downstream change.
Smart. Will do, and thanks for the pointer.
I wonder why you have a test program but don't use it in the test() function of your PKGBUILD?
Pure ignorance. :/ This is a great idea, and I'll put it on my to-do list. — Jeremy "Ichimonji10" Audet
Am 05.10.2014 um 14:41 schrieb Thiago Barroso Perrotta:
I wonder why you have a test program but don't use it in the test() function of your PKGBUILD? Not that this is needed, but as soon as I saw 'test.c', I thought I would find a test() too.
Just a small correction: test() is no default function, the function you should use is check() [1]. best regards, carstene1ns [1]: https://www.archlinux.org/pacman/PKGBUILD.5.html#_packaging_functions
Just a small correction: test() is no default function, the function you should use is check()
Thank you.
I wonder why you have a test program but don't use it in the test() function of your PKGBUILD?
Pure ignorance. :/ This is a great idea, and I'll put it on my to-do list.
It looks like the `check` function won't fit my needs, actually. "test.c" prints the currently installed libgroove version. "test.c" is valuable because: * It serves as a sanity check to ensure that libgroove functions on a basic level. * It allows me to check that libgroove and pkg-config advertise the same version number. (See the default rule in "makefile".) Unfortunately, neither of these checks can be performed until after the package has been installed. Now, I could do something clever with post_{install,upgrade}, but that feels like an abuse of pacman. (And anyway, the package installation isn't aborted if post_{install,upgrade} fails.) My best course of action seems to be keeping the status quo; I can use "test.c" and the associated makefile as a personal sanity check before uploading each new version of the package to the AUR.
you should contact upstream about including it before adding it as a downstream change.
https://github.com/andrewrk/libgroove/pull/79 — Jeremy "Ichimonji10" Audet
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 05.10.2014 um 18:35 schrieb carstene1ns:
Am 05.10.2014 um 14:41 schrieb Thiago Barroso Perrotta:
I wonder why you have a test program but don't use it in the test() function of your PKGBUILD? Not that this is needed, but as soon as I saw 'test.c', I thought I would find a test() too.
Just a small correction: test() is no default function, the function you should use is check() [1].
best regards, carstene1ns
[1]: https://www.archlinux.org/pacman/PKGBUILD.5.html#_packaging_functions
And additionally: test is also a built-in function of popular shells, so running a script or binary named "test" can be the source of strange, unexpected things happening. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJUvCR0AAoJEIT1NQXkgeRlq8AP/3Q4ziJL2RhKuRBOy3RztZ1b utQHlQpC1fkPugeXKdIL2F9/c7o4aoEWpDxBGCDtR1edFpX2UpSVfy+0ocxk1F+V EmwNfqmepbITpGrGnDngoSKLRDQoFQIjbgicRCE4C4llkJi54AM5JWmkuFcf97va oAebrXfsAuxTLv7uPVlNDJ3PV+9zPtcucfKFPzZb7QBW3lhCab3BxAgpglggjzSS l8kma5Wo/f+ZH4GTjx18pWUWNKbfPXlDFH+LFf1PbB/c4tdI0/qtbJoTzPtJoFpf WJmk277CbGl0mVZtxZWB68UeIzUPqPLmI3rx9fEqGTKLm9oGzqVYileOqunFua6v 5AwhWkpnlu0oWB/6GL7QL5ZCedHZj5EVj7LFNzB5Q74vaArbp1ndvHnIu6iBfIkH 1tm1S6aBirJ+/Rmn+3WqgsJFJxbCtejIJ7jY3AA3NSv+eJretP9PlU2wF6+GjLBF pg8NHJJjuG/2hJJ3IJ+9jj516pYwTX6ej6oNtSwjFneaPrGXMgjU/X2vgOSbLvfx faECxhuLtbGcbNfdQgymczose97xpX3t0xfkFpZiXWdoiOdj/hfC7FDO9kS6dj1u 8tJidg8H/oI/DYuzF/kqFa2NRmEmPaTz4OjH5kAW09OPsXQLv/nypi2MHAoqlSVR kh9bM0PyXwWABn2M40fv =0gCk -----END PGP SIGNATURE-----
participants (5)
-
carstene1ns
-
Jeremy Audet
-
Johannes Löthberg
-
Stefan Husmann
-
Thiago Barroso Perrotta