Why are patches submitted via email?
Hi, quick question: Why aren't pull requests made directly on gitlab/somewhere on the site, but instead are sent over email. Even from the human aspect, I think most devs want to track their "ego points" in the form of how many merges they made. Or is it just me who is doing it wrong and I should put patches into comments instead?
Jul 18, 2023 07:09:56 Adam Labus <adam.labuznik@gmail.com>:
Hi, quick question: Why aren't pull requests made directly on gitlab/somewhere on the site, but instead are sent over email. Even from the human aspect, I think most devs want to track their "ego points" in the form of how many merges they made.
Or is it just me who is doing it wrong and I should put patches into comments instead? That depends entirely on the maintainer of the AUR package, there is no "standard" for contributing patches to the maintainer. Some provide a Git{hub,lab,ea} repository for their AUR packages, some don't. Most people who decide to contribute to the maintainer tend to either send the patch by email or put it in a pastebin/gist and put the link in the comments.
On 7/18/23 07:39, Kusoneko wrote:
Jul 18, 2023 07:09:56 Adam Labus <adam.labuznik@gmail.com <mailto:adam.labuznik@gmail.com>>:
Hi, quick question: Why aren't pull requests made directly on gitlab/somewhere on the site, but instead are sent over email. Even from the human aspect, I think most devs want to track their "ego points" in the form of how many merges they made.
Or is it just me who is doing it wrong and I should put patches into comments instead?
That depends entirely on the maintainer of the AUR package, there is no "standard" for contributing patches to the maintainer. Some provide a Git{hub,lab,ea} repository for their AUR packages, some don't. Most people who decide to contribute to the maintainer tend to either send the patch by email or put it in a pastebin/gist and put the link in the comments.
You also have to remember the migration to the gitlab only officially happened last month. There's still some pieces being figured out and discussed. The goal from what i can tell is to move everything to the gitlab, but we're not completely there. https://lists.archlinux.org/archives/list/pacman-dev@lists.archlinux.org/thr... https://gitlab.archlinux.org/archlinux/infrastructure/-/issues/515 You -can- submit issues and merge requests on the gitlab already, but it's not "officially" how things are done. (As far as I know).
Le 18/07/2023 à 16:59, Matthew Sexton a écrit :
On 7/18/23 07:39, Kusoneko wrote:
Jul 18, 2023 07:09:56 Adam Labus <adam.labuznik@gmail.com <mailto:adam.labuznik@gmail.com>>:
Hi, quick question: Why aren't pull requests made directly on gitlab/somewhere on the site, but instead are sent over email. Even from the human aspect, I think most devs want to track their "ego points" in the form of how many merges they made.
Or is it just me who is doing it wrong and I should put patches into comments instead?
That depends entirely on the maintainer of the AUR package, there is no "standard" for contributing patches to the maintainer. Some provide a Git{hub,lab,ea} repository for their AUR packages, some don't. Most people who decide to contribute to the maintainer tend to either send the patch by email or put it in a pastebin/gist and put the link in the comments.
You also have to remember the migration to the gitlab only officially happened last month. There's still some pieces being figured out and discussed. The goal from what i can tell is to move everything to the gitlab, but we're not completely there.
https://lists.archlinux.org/archives/list/pacman-dev@lists.archlinux.org/thr...
https://gitlab.archlinux.org/archlinux/infrastructure/-/issues/515 Just a little bit of precision about the recent Git/GitLab migration: This migration was about official/repo packages only. If the subject here are AUR packages, they aren't concerned by GitLab whatsoever.
You -can- submit issues and merge requests on the gitlab already, but it's not "officially" how things are done. (As far as I know). As far as Gitlab's package repositories are concerned, you cannot submit issues nor merge requests yet. At the moment, the aim is to migrate the current "flyspray" bugtracker to GitLab issues and then open merge requests as well in a later time but this is still a work in progress currently.
-- Regards, Robin Candau / Antiz
Why aren't pull requests made directly on gitlab/somewhere on the site, but instead are sent over email. There is no policies in this case. You are doing nothing wrong.
As for “why”, the reasons will vary between maintainers and they’re the only ones to answer this question. But one point to consider is: Pull requests are not a feature of Git itself. They’re specific to GitLab. To manage PRs one is forced to use GitLab’s app: either the webapp or CLI tool `glab`. The latter being far from convenient. A maintainer may wish not to use this app. With motivation ranging from freedom, through convenience, to simply being used to the email medium. Maybe not far from you deciding to use the mailing list, instead of asking on Reddit. Cheers
participants (5)
-
Adam Labus
-
Kusoneko
-
Matthew Sexton
-
mpan
-
Robin Candau