powertabeditor - request for PKGBUILD review
Hi, this is my first time creating a PKGBUILD. I tried to follow the guidelines and the recommended practices for cmake packages, but not sure I didn't miss something. Thanks for any suggestions. I checked that it builds in clean chroot. The software seems to work well, except for JACK server not running error (for playback of midi). I am not sure if this should be somehow solved in the PKGBUILD, or if it should be left to the user. When I run qsynth alongside the powertabeditor the playback works just fine. Somehow setting up timidity++ daemon would work too, I guess. Best regards, Jonas Serych
The PKGBUILD got sent as a binary mime type, sorry about that. Here it is as text/plain.
On 19-02-2024 10:39, Jonas Serych wrote:
The PKGBUILD got sent as a binary mime type, sorry about that. Here it is as text/plain.
One comment : upstream readme mnetrions requiring a 'midi sequencer' . Some soundcards offer that ability in hardware, but the majority doesn't. timidity++ and fluidsynth are the 2 most common software midi synthesizers on archlinux. I suggest you list them as optdepends . Lone_Wolf
Hello, Appreciate it if you paste the PKGBUILD into the email body, and not attach it. Would also make it easier to quote. Thanks! Take care, -- Polarian GPG signature: 0770E5312238C760 Website: https://polarian.dev JID/XMPP: polarian@icebound.dev
participants (3)
-
Jonas Serych
-
Lone_Wolf
-
Polarian