[aur-general] oh-my-zsh PKGBUILD
Hi, I made a PKGBUILD from Robby Russell's oh-my-zsh <https://github.com/robbyrussell/oh-my-zsh> framework which helps manage your zsh configuration. There are over 40 themes with a handful of functions and auto-complete helpers available. It installs fine here, but in case you find something that should be modified, please provide some constructive input so I can submit this PKGBUILD to AUR. PKGBUILD: http://archlinux.pastebin.com/B3fyYkrp install file: http://archlinux.pastebin.com/1HpZXGwF Thanks, -- Tony
On Tue, Nov 23, 2010 at 3:03 AM, Tony <crt.011@gmail.com> wrote:
PKGBUILD: http://archlinux.pastebin.com/B3fyYkrp
It appears that you're using the PKGBUILD as a script that installs and configures oh-my-zsh for the current user. No files are copied into the actual package directory ($pkgdir), so you end up with an empty package. As you understand, this is incorrect behavior. Also note that while a package is being built, it should never create or modify files inside the user's home directory (or anywhere outside of $startdir for that matter).
install file: http://archlinux.pastebin.com/1HpZXGwF
I'd lose the ASCII art and the "oh-my-zsh is now installed" line, for the sake of keeping the pacman log as clean as possible. In addition, the "chsh -s /usr/bin/env zsh" line is incorrect; zsh is interpreted as a separate argument.
On Mon, Nov 22, 2010 at 8:30 PM, Evangelos Foutras <foutrelis@gmail.com> wrote:
On Tue, Nov 23, 2010 at 3:03 AM, Tony <crt.011@gmail.com> wrote:
PKGBUILD: http://archlinux.pastebin.com/B3fyYkrp
It appears that you're using the PKGBUILD as a script that installs and configures oh-my-zsh for the current user. No files are copied into the actual package directory ($pkgdir), so you end up with an empty package. As you understand, this is incorrect behavior. Also note that while a package is being built, it should never create or modify files inside the user's home directory (or anywhere outside of $startdir for that matter).
install file: http://archlinux.pastebin.com/1HpZXGwF
I'd lose the ASCII art and the "oh-my-zsh is now installed" line, for the sake of keeping the pacman log as clean as possible. In addition, the "chsh -s /usr/bin/env zsh" line is incorrect; zsh is interpreted as a separate argument.
And the: op=$1 shift $op $* are no longer needed.
On Mon, Nov 22, 2010 at 8:30 PM, Evangelos Foutras<foutrelis@gmail.com> wrote:
On Tue, Nov 23, 2010 at 3:03 AM, Tony<crt.011@gmail.com> wrote:
PKGBUILD: http://archlinux.pastebin.com/B3fyYkrp It appears that you're using the PKGBUILD as a script that installs and configures oh-my-zsh for the current user. No files are copied into the actual package directory ($pkgdir), so you end up with an empty package. As you understand, this is incorrect behavior. Also note that while a package is being built, it should never create or modify files inside the user's home directory (or anywhere outside of $startdir for that matter).
install file: http://archlinux.pastebin.com/1HpZXGwF I'd lose the ASCII art and the "oh-my-zsh is now installed" line, for the sake of keeping the pacman log as clean as possible. In addition, the "chsh -s /usr/bin/env zsh" line is incorrect; zsh is interpreted as a separate argument.
And the: op=$1 shift $op $* are no longer needed. The new PKGBUILD & install file are much better now. The package is no longer empty. I was a bit stumped on getting oh-my-zsh installed correctly because I was originally under the impression that I needed to /make &&/ /make DESTDIR=$pkgdir install /in order to not have an empty
On 11/22/2010 08:02 PM, Eric Bélanger wrote: package. However, per the install docs on the main repository <https://github.com/robbyrussell/oh-my-zsh> page, we only need to ensure the "/oh-my-zsh"/ directory be hidden in the user's $HOME. From the oh-my-zsh repository: /"*NOTE*: If you already have a ~/.zshrc file, you should back it up. |cp ~/.zshrc ~/.zshrc.orig| in case you want to go back to your original settings. /|/cp ~/.oh-my-zsh/templates/zshrc.zsh-template ~/.zshrc". / |PKGBUILD: http://archlinux.pastebin.com/n5B7tALf .install: http://archlinux.pastebin.com/pwfaLbM0 Thanks for the very helpful input Evangelos & Eric! -- Tony
On Tue, Nov 23, 2010 at 7:08 AM, Tony <crt.011@gmail.com> wrote:
|PKGBUILD: http://archlinux.pastebin.com/n5B7tALf .install: http://archlinux.pastebin.com/pwfaLbM0
The PKGBUILD and .install file still contain references to the user's home directory (for the latter, it's only a harmless message in post_install, but the information is wrong). After taking a closer look at oh-my-zsh, I'm not sure if it's a good candidate for a package. I find the manual installation instructions at https://github.com/robbyrussell/oh-my-zsh#readme to be very intuitive and easy to follow, and at the same time providing the user with complete control over what's happening. Maybe I'm looking at it the wrong way, but having a package which is a snapshot of the Git repository isn't much better -- and is probably worse -- than each user keeping a Git clone in their home directories.
On 11/22/2010 09:38 PM, Evangelos Foutras wrote:
|PKGBUILD: http://archlinux.pastebin.com/n5B7tALf .install: http://archlinux.pastebin.com/pwfaLbM0 The PKGBUILD and .install file still contain references to the user's home directory (for the latter, it's only a harmless message in
On Tue, Nov 23, 2010 at 7:08 AM, Tony<crt.011@gmail.com> wrote: post_install, but the information is wrong).
After taking a closer look at oh-my-zsh, I'm not sure if it's a good candidate for a package. I find the manual installation instructions at https://github.com/robbyrussell/oh-my-zsh#readme to be very intuitive and easy to follow, and at the same time providing the user with complete control over what's happening.
Maybe I'm looking at it the wrong way, but having a package which is a snapshot of the Git repository isn't much better -- and is probably worse -- than each user keeping a Git clone in their home directories. You do make a good point on the matter. The manual instructions at https://github.com/robbyrussell/oh-my-zsh#readme are easy to follow without really needing a PKGBUILD. Originally, using the manual instructions was how I went about using oh-my-zsh. This was a very smooth process.
I'm going to have to agree with you here since your point makes absolute sense. Since the installation is so straight forward, it does seem best to give the user control with oh-my-zsh instead of using a PKGBUILD which only seems to add an unnecessary step. With that said, I can agree that oh-my-zsh does not make a good candidate for a package. I do appreciate and thank you for your time and input with this. Cheers, -- Tony
participants (3)
-
Eric Bélanger
-
Evangelos Foutras
-
Tony