[aur-general] Use of sudo in pkgbuild

newer
[aur-general] machine-update in AUR

older
Re: [aur-general] Use of sudo in...

Laurie Clark-Michalek

7 Apr 2009 7 Apr '09

7:55 p.m.

Hi, I've been working on the splashy-creator package (updating it to 2.2), and had got it working, when I realised I had a potential problem. I needed to use sudo in the pkgbuild, and so far, I have never seen it used in a package. Is this OK, and/or is there away to avoid it? Here is my package build for inspection: # Contributor: Laurie Clark-Michalek pkgname=splashy-creator pkgver=2.2 pkgrel=1 pkgdesc="A tool for creating Splashy themes." arch=('i686' 'x86_64') url="http://www.nanolx.org/index.php?option=com_content&task=view&id=34" license=('GPL3') depends=('sed' 'pygtk>=2.4' 'python>=2.4' 'splashy') makedepends=('sudo' 'patch') source=(http://nanolx.org/free/$pkgname-$pkgver.tar.bz2 $pkgname.patch) md5sums=('615033a2cabab0b132ecc9aff2c07a7b' 'b8095120f36b5f2cc3b1704a7b2e32a6') build() { cd $srcdir/$pkgname ./configure patch ./Makefile $srcdir/splashy-creator.patch sudo make DESTDIR=$pkgdir install || return 1 } The patch is just a small one: 23c23 < @mkdir -p $(DESTDIR)/usr/usr/bin/ ---

...

@mkdir -p $(DESTDIR)/usr/bin/

Thanks, Laurie P.S. This is the first time I've used patch, so is the .patch file alright?

Show replies by date

Thomas Bächler

7 Apr 7 Apr

10:14 p.m.

Laurie Clark-Michalek schrieb:

...

Hi,

I've been working on the splashy-creator package (updating it to 2.2), and had got it working, when I realised I had a potential problem. I needed to use sudo in the pkgbuild, and so far, I have never seen it used in a package. Is this OK, and/or is there away to avoid it?

I see you're already getting lots of good help here, but just for reference I want to make this clear: No, never, absolutely not. The reason you need sudo ist that make install wants to modify something inside your system. Not only will that make the build system unclean, these changes also won't show up on install time on the system you use it. This won't work as soon as you build the package on one system and install it on another. That is why (like others already explained to you), this command has to be moved to a post_upgrade script. I didn't look it up now, but this is supposed to be somewhere in the Arch Packaging Standards or in a related document.

Dan Vratil

8 Apr 8 Apr

8 p.m.

You don't need to use SUDO for `make install` as you have write privileges into $pkgdir folder. On Tuesday 07 April 2009 21:55:38 Laurie Clark-Michalek wrote:

...

Hi,

I've been working on the splashy-creator package (updating it to 2.2), and had got it working, when I realised I had a potential problem. I needed to use sudo in the pkgbuild, and so far, I have never seen it used in a package. Is this OK, and/or is there away to avoid it? Here is my package build for inspection:

# Contributor: Laurie Clark-Michalek

pkgname=splashy-creator pkgver=2.2 pkgrel=1 pkgdesc="A tool for creating Splashy themes." arch=('i686' 'x86_64') url="http://www.nanolx.org/index.php?option=com_content&task=view&id=34" license=('GPL3') depends=('sed' 'pygtk>=2.4' 'python>=2.4' 'splashy') makedepends=('sudo' 'patch') source=(http://nanolx.org/free/$pkgname-$pkgver.tar.bz2 $pkgname.patch) md5sums=('615033a2cabab0b132ecc9aff2c07a7b' 'b8095120f36b5f2cc3b1704a7b2e32a6')

build() { cd $srcdir/$pkgname ./configure patch ./Makefile $srcdir/splashy-creator.patch sudo make DESTDIR=$pkgdir install || return 1 }

The patch is just a small one:

23c23 < @mkdir -p $(DESTDIR)/usr/usr/bin/ ---

...
@mkdir -p $(DESTDIR)/usr/bin/

Thanks,

Laurie

P.S. This is the first time I've used patch, so is the .patch file alright?

-- --------------------------------- Dan Vrátil progdan@progdansoft.com ICQ 249163429 Jabber progdan@jabber.cz Tel. +420 732 326 870

Laurie Clark-Michalek

7 Apr 7 Apr

8:06 p.m.

The pkg will not build if I don't have sudo enabled. It's because gtk-update-icon-cache is used during the make install, regardless of directory. See the error message below. gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : Permission denied make: *** [install] Error 1 ==> ERROR: Build Failed. 2009/4/8 Dan Vratil

...

You don't need to use SUDO for `make install` as you have write privileges into $pkgdir folder.

On Tuesday 07 April 2009 21:55:38 Laurie Clark-Michalek wrote:

...
Hi,

I've been working on the splashy-creator package (updating it to 2.2), and had got it working, when I realised I had a potential problem. I needed to use sudo in the pkgbuild, and so far, I have never seen it used in a package. Is this OK, and/or is there away to avoid it? Here is my package build for inspection:

# Contributor: Laurie Clark-Michalek

pkgname=splashy-creator pkgver=2.2 pkgrel=1 pkgdesc="A tool for creating Splashy themes." arch=('i686' 'x86_64') url="http://www.nanolx.org/index.php?option=com_content&task=view&id=34" license=('GPL3') depends=('sed' 'pygtk>=2.4' 'python>=2.4' 'splashy') makedepends=('sudo' 'patch') source=(http://nanolx.org/free/$pkgname-$pkgver.tar.bz2 $pkgname.patch) md5sums=('615033a2cabab0b132ecc9aff2c07a7b' 'b8095120f36b5f2cc3b1704a7b2e32a6')

build() { cd $srcdir/$pkgname ./configure patch ./Makefile $srcdir/splashy-creator.patch sudo make DESTDIR=$pkgdir install || return 1 }

The patch is just a small one:

23c23 < @mkdir -p $(DESTDIR)/usr/usr/bin/ ---

...
@mkdir -p $(DESTDIR)/usr/bin/

Thanks,

Laurie

P.S. This is the first time I've used patch, so is the .patch file alright?

-- --------------------------------- Dan Vrátil progdan@progdansoft.com ICQ 249163429 Jabber progdan@jabber.cz Tel. +420 732 326 870

Mathias Burén

8:09 p.m.

Perhaps you could edit the makefile or add some parameters somewhere? 2009/4/7 Laurie Clark-Michalek

...

The pkg will not build if I don't have sudo enabled. It's because gtk-update-icon-cache is used during the make install, regardless of directory. See the error message below.

gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : Permission denied make: *** [install] Error 1 ==> ERROR: Build Failed.

2009/4/8 Dan Vratil

...
You don't need to use SUDO for `make install` as you have write privileges into $pkgdir folder.

...
Hi,

I've been working on the splashy-creator package (updating it to 2.2), and had got it working, when I realised I had a potential problem. I needed to use sudo in the pkgbuild, and so far, I have never seen it used in a package. Is this OK, and/or is there away to avoid it? Here is my

On Tuesday 07 April 2009 21:55:38 Laurie Clark-Michalek wrote: package

...
build for inspection:

# Contributor: Laurie Clark-Michalek

pkgname=splashy-creator pkgver=2.2 pkgrel=1 pkgdesc="A tool for creating Splashy themes." arch=('i686' 'x86_64') url=" http://www.nanolx.org/index.php?option=com_content&task=view&id=34" license=('GPL3') depends=('sed' 'pygtk>=2.4' 'python>=2.4' 'splashy') makedepends=('sudo' 'patch') source=(http://nanolx.org/free/$pkgname-$pkgver.tar.bz2$pkgname.patch) md5sums=('615033a2cabab0b132ecc9aff2c07a7b' 'b8095120f36b5f2cc3b1704a7b2e32a6')

build() { cd $srcdir/$pkgname ./configure patch ./Makefile $srcdir/splashy-creator.patch sudo make DESTDIR=$pkgdir install || return 1 }

The patch is just a small one:

23c23 < @mkdir -p $(DESTDIR)/usr/usr/bin/ ---

...
@mkdir -p $(DESTDIR)/usr/bin/

Thanks,

Laurie

P.S. This is the first time I've used patch, so is the .patch file alright?

-- --------------------------------- Dan Vrátil progdan@progdansoft.com ICQ 249163429 Jabber progdan@jabber.cz Tel. +420 732 326 870

Daenyth Blank

8:15 p.m.

On Tue, Apr 7, 2009 at 16:06, Laurie Clark-Michalek wrote:

...

The pkg will not build if I don't have sudo enabled. It's because gtk-update-icon-cache is used during the make install, regardless of directory. See the error message below.

Disable that or simply patch it out of the makefile, then add it to post_{install,update}

Laurie Clark-Michalek

8:20 p.m.

I patched it out, thanks, but what do you mean by add it to post_{install,update}. Would that be in a .install scriptlet? 2009/4/7 Daenyth Blank >

...

On Tue, Apr 7, 2009 at 16:06, Laurie Clark-Michalek wrote:

...
The pkg will not build if I don't have sudo enabled. It's because gtk-update-icon-cache is used during the make install, regardless of directory. See the error message below.

Disable that or simply patch it out of the makefile, then add it to post_{install,update}

Ju Liu

8:29 p.m.

On 07/apr/09, at 22:20, Laurie Clark-Michalek wrote:

...

I patched it out, thanks, but what do you mean by add it to post_{install,update}. Would that be in a .install scriptlet?

Yep, follow the wiki to get a better idea of the structure of an .install file ;)

Jan de Groot

8 Apr 8 Apr

10:08 a.m.

On Tue, 2009-04-07 at 20:06 +0000, Laurie Clark-Michalek wrote:

...

The pkg will not build if I don't have sudo enabled. It's because gtk-update-icon-cache is used during the make install, regardless of directory. See the error message below.

gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : Permission denied make: *** [install] Error 1 ==> ERROR: Build Failed.

Wreck it out. First of all, a PKGBUILD should _NEVER_ touch the system it is built on. Second, hicolor icon caches should _NEVER_ be in any package, it should be generated from post_install.

Laurie Clark-Michalek

10:12 a.m.

Ye, I've been thinking about this. My current feeling is to add hicolour-icon-theme to opt-depends and then put an echo about updating the icon cache in the post_install. Currently, hicolour-icon-theme is a depend which seems rather overkill to me, and the icon cache is updated from post_install 2009/4/8 Jan de Groot

...

On Tue, 2009-04-07 at 20:06 +0000, Laurie Clark-Michalek wrote:

...
The pkg will not build if I don't have sudo enabled. It's because gtk-update-icon-cache is used during the make install, regardless of directory. See the error message below.

gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : Permission denied make: *** [install] Error 1 ==> ERROR: Build Failed.

Wreck it out. First of all, a PKGBUILD should _NEVER_ touch the system it is built on. Second, hicolor icon caches should _NEVER_ be in any package, it should be generated from post_install.

Dan Vratil

8:24 p.m.

According to the Makefile it seems, the cache can be disabled: @if test ! $(CACHE_DISABLE) ; then \ echo -e "$(MAGENTA)updating: $(SMOOTHBLUE)icon cache" ;\ gtk-update-icon-cache -f /usr/share/icons/hicolor;\ fi Try make DESTDIR=$pkgdir CACHE_DISABLE install or make DESTDIR=$pkgdir CACHE_DISABLE=true install I don't know how exactly 'test' works, so I don't know which value is expected in $(CACHE_DISABLE) On Tuesday 07 April 2009 22:06:14 Laurie Clark-Michalek wrote:

...

The pkg will not build if I don't have sudo enabled. It's because gtk-update-icon-cache is used during the make install, regardless of directory. See the error message below.

gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : Permission denied make: *** [install] Error 1 ==> ERROR: Build Failed.

2009/4/8 Dan Vratil

...
You don't need to use SUDO for `make install` as you have write privileges into $pkgdir folder.

On Tuesday 07 April 2009 21:55:38 Laurie Clark-Michalek wrote:

...
Hi,

I've been working on the splashy-creator package (updating it to 2.2),

and

...
had got it working, when I realised I had a potential problem. I needed

to

...
use sudo in the pkgbuild, and so far, I have never seen it used in a package. Is this OK, and/or is there away to avoid it? Here is my package build for inspection:

# Contributor: Laurie Clark-Michalek
us>

...
pkgname=splashy-creator pkgver=2.2 pkgrel=1 pkgdesc="A tool for creating Splashy themes." arch=('i686' 'x86_64') url="http://www.nanolx.org/index.php?option=com_content&task=view&id=34 " license=('GPL3') depends=('sed' 'pygtk>=2.4' 'python>=2.4' 'splashy') makedepends=('sudo' 'patch') source=(http://nanolx.org/free/$pkgname-$pkgver.tar.bz2 $pkgname.patch) md5sums=('615033a2cabab0b132ecc9aff2c07a7b' 'b8095120f36b5f2cc3b1704a7b2e32a6')

build() { cd $srcdir/$pkgname ./configure patch ./Makefile $srcdir/splashy-creator.patch sudo make DESTDIR=$pkgdir install || return 1 }

The patch is just a small one:

23c23 < @mkdir -p $(DESTDIR)/usr/usr/bin/ ---

...
@mkdir -p $(DESTDIR)/usr/bin/

Thanks,

Laurie

P.S. This is the first time I've used patch, so is the .patch file

alright?

-- --------------------------------- Dan Vrátil progdan@progdansoft.com ICQ 249163429 Jabber progdan@jabber.cz Tel. +420 732 326 870

-- --------------------------------- Dan Vrátil progdan@progdansoft.com ICQ 249163429 Jabber progdan@jabber.cz Tel. +420 732 326 870

Laurie Clark-Michalek

7 Apr 7 Apr

8:29 p.m.

I was planning to use a little .install file: post_install() { gtk-update-icon-cache -f /usr/share/icons/hicolor } 2009/4/8 Dan Vratil

...

According to the Makefile it seems, the cache can be disabled:

@if test ! $(CACHE_DISABLE) ; then \ echo -e "$(MAGENTA)updating: $(SMOOTHBLUE)icon cache" ;\ gtk-update-icon-cache -f /usr/share/icons/hicolor;\ fi

Try make DESTDIR=$pkgdir CACHE_DISABLE install or make DESTDIR=$pkgdir CACHE_DISABLE=true install

I don't know how exactly 'test' works, so I don't know which value is expected in $(CACHE_DISABLE)

On Tuesday 07 April 2009 22:06:14 Laurie Clark-Michalek wrote:

...
The pkg will not build if I don't have sudo enabled. It's because gtk-update-icon-cache is used during the make install, regardless of directory. See the error message below.

gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : Permission denied make: *** [install] Error 1 ==> ERROR: Build Failed.

2009/4/8 Dan Vratil

...
You don't need to use SUDO for `make install` as you have write privileges into $pkgdir folder.

On Tuesday 07 April 2009 21:55:38 Laurie Clark-Michalek wrote:

...
Hi,

I've been working on the splashy-creator package (updating it to 2.2),

and

...
had got it working, when I realised I had a potential problem. I needed

to

...
use sudo in the pkgbuild, and so far, I have never seen it used in a package. Is this OK, and/or is there away to avoid it? Here is my package build for inspection:

# Contributor: Laurie Clark-Michalek
us>

...
pkgname=splashy-creator pkgver=2.2 pkgrel=1 pkgdesc="A tool for creating Splashy themes." arch=('i686' 'x86_64') url=" http://www.nanolx.org/index.php?option=com_content&task=view&id=34 " license=('GPL3') depends=('sed' 'pygtk>=2.4' 'python>=2.4' 'splashy') makedepends=('sudo' 'patch') source=(http://nanolx.org/free/$pkgname-$pkgver.tar.bz2$pkgname.patch) md5sums=('615033a2cabab0b132ecc9aff2c07a7b' 'b8095120f36b5f2cc3b1704a7b2e32a6')

build() { cd $srcdir/$pkgname ./configure patch ./Makefile $srcdir/splashy-creator.patch sudo make DESTDIR=$pkgdir install || return 1 }

The patch is just a small one:

23c23 < @mkdir -p $(DESTDIR)/usr/usr/bin/ ---

...
@mkdir -p $(DESTDIR)/usr/bin/

Thanks,

Laurie

P.S. This is the first time I've used patch, so is the .patch file

alright?

-- --------------------------------- Dan Vrátil progdan@progdansoft.com ICQ 249163429 Jabber progdan@jabber.cz Tel. +420 732 326 870

-- --------------------------------- Dan Vrátil progdan@progdansoft.com ICQ 249163429 Jabber progdan@jabber.cz Tel. +420 732 326 870

Laurie Clark-Michalek

8:35 p.m.

Ok, it's working, and I've uploaded it to the aur: http://aur.archlinux.org/packages.php?ID=16781 Thanks for your help 2009/4/7 Laurie Clark-Michalek

...

I was planning to use a little .install file:

post_install() { gtk-update-icon-cache -f /usr/share/icons/hicolor }

2009/4/8 Dan Vratil

...
According to the Makefile it seems, the cache can be disabled:

@if test ! $(CACHE_DISABLE) ; then \ echo -e "$(MAGENTA)updating: $(SMOOTHBLUE)icon cache" ;\ gtk-update-icon-cache -f /usr/share/icons/hicolor;\ fi

Try make DESTDIR=$pkgdir CACHE_DISABLE install or make DESTDIR=$pkgdir CACHE_DISABLE=true install

I don't know how exactly 'test' works, so I don't know which value is expected in $(CACHE_DISABLE)

On Tuesday 07 April 2009 22:06:14 Laurie Clark-Michalek wrote:

...
The pkg will not build if I don't have sudo enabled. It's because gtk-update-icon-cache is used during the make install, regardless of directory. See the error message below.

gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : Permission denied make: *** [install] Error 1 ==> ERROR: Build Failed.

2009/4/8 Dan Vratil

...
You don't need to use SUDO for `make install` as you have write privileges into $pkgdir folder.

On Tuesday 07 April 2009 21:55:38 Laurie Clark-Michalek wrote:

...
Hi,

I've been working on the splashy-creator package (updating it to 2.2),

and

...
had got it working, when I realised I had a potential problem. I needed

to

...
use sudo in the pkgbuild, and so far, I have never seen it used in a package. Is this OK, and/or is there away to avoid it? Here is my package build for inspection:

# Contributor: Laurie Clark-Michalek
us>

...
pkgname=splashy-creator pkgver=2.2 pkgrel=1 pkgdesc="A tool for creating Splashy themes." arch=('i686' 'x86_64') url=" http://www.nanolx.org/index.php?option=com_content&task=view&id=34 " license=('GPL3') depends=('sed' 'pygtk>=2.4' 'python>=2.4' 'splashy') makedepends=('sudo' 'patch') source=(http://nanolx.org/free/$pkgname-$pkgver.tar.bz2$pkgname.patch) md5sums=('615033a2cabab0b132ecc9aff2c07a7b' 'b8095120f36b5f2cc3b1704a7b2e32a6')

build() { cd $srcdir/$pkgname ./configure patch ./Makefile $srcdir/splashy-creator.patch sudo make DESTDIR=$pkgdir install || return 1 }

The patch is just a small one:

23c23 < @mkdir -p $(DESTDIR)/usr/usr/bin/ ---

...
@mkdir -p $(DESTDIR)/usr/bin/

Thanks,

Laurie

P.S. This is the first time I've used patch, so is the .patch file

alright?

-- --------------------------------- Dan Vrátil progdan@progdansoft.com ICQ 249163429 Jabber progdan@jabber.cz Tel. +420 732 326 870

-- --------------------------------- Dan Vrátil progdan@progdansoft.com ICQ 249163429 Jabber progdan@jabber.cz Tel. +420 732 326 870

Angel Velásquez

8:39 p.m.

On Wed, Apr 8, 2009 at 4:05 PM, Laurie Clark-Michalek wrote:

...

Ok, it's working, and I've uploaded it to the aur: http://aur.archlinux.org/packages.php?ID=16781

Hi, please add hicolor-icon-theme on the depends array, and make on the makedepends array Cheers -- Angel Velásquez angvp @ irc.freenode.net Linux Counter: #359909

Laurie Clark-Michalek

9 p.m.

I'v added hicolor-icon-theme and make. (so much for getting away with pkgrel=1 xD). 2009/4/7 Angel Velásquez

...

On Wed, Apr 8, 2009 at 4:05 PM, Laurie Clark-Michalek wrote:

...
Ok, it's working, and I've uploaded it to the aur: http://aur.archlinux.org/packages.php?ID=16781

Hi, please add hicolor-icon-theme on the depends array, and make on the makedepends array

Cheers -- Angel Velásquez angvp @ irc.freenode.net Linux Counter: #359909

Daenyth Blank

9:32 p.m.

On Tue, Apr 7, 2009 at 17:00, Laurie Clark-Michalek wrote:

...

I'v added hicolor-icon-theme and make. (so much for getting away with pkgrel=1 xD).

You don't need to depend on automake because it's in base-devel

Angel Velásquez

9:37 p.m.

...

You don't need to depend on automake because it's in base-devel

I said "make", I've installed (office machine) with the FTP image, and I don't had make :o, and neither patch -- Angel Velásquez angvp @ irc.freenode.net Linux Counter: #359909

Mathias Burén

9:40 p.m.

base-devel is a group which includes patch, make etc. 2009/4/7 Angel Velásquez

...

...
You don't need to depend on automake because it's in base-devel

I said "make", I've installed (office machine) with the FTP image, and I don't had make :o, and neither patch

-- Angel Velásquez angvp @ irc.freenode.net Linux Counter: #359909

Dan Vratil

8 Apr 8 Apr

8:41 p.m.

Did you upload the right PKGBUILD? I don't see there the CACHE_DISABLE in make install neither the Makefile patch :-) On Tuesday 07 April 2009 22:35:19 Laurie Clark-Michalek wrote:

...

Ok, it's working, and I've uploaded it to the aur: http://aur.archlinux.org/packages.php?ID=16781

Thanks for your help

2009/4/7 Laurie Clark-Michalek

...
I was planning to use a little .install file:

post_install() { gtk-update-icon-cache -f /usr/share/icons/hicolor }

2009/4/8 Dan Vratil

...
According to the Makefile it seems, the cache can be disabled:

@if test ! $(CACHE_DISABLE) ; then \ echo -e "$(MAGENTA)updating: $(SMOOTHBLUE)icon cache" ;\ gtk-update-icon-cache -f /usr/share/icons/hicolor;\ fi

Try make DESTDIR=$pkgdir CACHE_DISABLE install or make DESTDIR=$pkgdir CACHE_DISABLE=true install

I don't know how exactly 'test' works, so I don't know which value is expected in $(CACHE_DISABLE)

On Tuesday 07 April 2009 22:06:14 Laurie Clark-Michalek wrote:

...
The pkg will not build if I don't have sudo enabled. It's because gtk-update-icon-cache is used during the make install, regardless of directory. See the error message below.

gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : Permission denied make: *** [install] Error 1 ==> ERROR: Build Failed.

2009/4/8 Dan Vratil

...
You don't need to use SUDO for `make install` as you have write privileges into $pkgdir folder.

On Tuesday 07 April 2009 21:55:38 Laurie Clark-Michalek wrote:

...
Hi,

I've been working on the splashy-creator package (updating it to

2.2),

...
...
and

...
had got it working, when I realised I had a potential problem. I

needed

...
...
to

...
use sudo in the pkgbuild, and so far, I have never seen it used in a package. Is this OK, and/or is there away to avoid it? Here is my package build for inspection:

# Contributor: Laurie Clark-Michalek
(dot)

...
...
us>

...
pkgname=splashy-creator pkgver=2.2 pkgrel=1 pkgdesc="A tool for creating Splashy themes." arch=('i686' 'x86_64') url="

http://www.nanolx.org/index.php?option=com_content&task=view&id=34

...
...
...
" license=('GPL3') depends=('sed' 'pygtk>=2.4' 'python>=2.4' 'splashy') makedepends=('sudo' 'patch') source=(http://nanolx.org/free/$pkgname-$pkgver.tar.bz2$pkgname.pa tch) md5sums=('615033a2cabab0b132ecc9aff2c07a7b' 'b8095120f36b5f2cc3b1704a7b2e32a6')

build() { cd $srcdir/$pkgname ./configure patch ./Makefile $srcdir/splashy-creator.patch sudo make DESTDIR=$pkgdir install || return 1 }

The patch is just a small one:

23c23 < @mkdir -p $(DESTDIR)/usr/usr/bin/ ---

> @mkdir -p $(DESTDIR)/usr/bin/

Thanks,

Laurie

P.S. This is the first time I've used patch, so is the .patch file

alright?

-- --------------------------------- Dan Vrátil progdan@progdansoft.com ICQ 249163429 Jabber progdan@jabber.cz Tel. +420 732 326 870

-- --------------------------------- Dan Vrátil progdan@progdansoft.com ICQ 249163429 Jabber progdan@jabber.cz Tel. +420 732 326 870

-- --------------------------------- Dan Vrátil progdan@progdansoft.com ICQ 249163429 Jabber progdan@jabber.cz Tel. +420 732 326 870

Dan Vratil

8:43 p.m.

Oh rock me - I should take better look next time, of course it's there. I'm sorry Laurie. On Tuesday 07 April 2009 22:35:19 Laurie Clark-Michalek wrote:

...

Ok, it's working, and I've uploaded it to the aur: http://aur.archlinux.org/packages.php?ID=16781

Thanks for your help

2009/4/7 Laurie Clark-Michalek

...
I was planning to use a little .install file:

post_install() { gtk-update-icon-cache -f /usr/share/icons/hicolor }

2009/4/8 Dan Vratil

...
According to the Makefile it seems, the cache can be disabled:

@if test ! $(CACHE_DISABLE) ; then \ echo -e "$(MAGENTA)updating: $(SMOOTHBLUE)icon cache" ;\ gtk-update-icon-cache -f /usr/share/icons/hicolor;\ fi

Try make DESTDIR=$pkgdir CACHE_DISABLE install or make DESTDIR=$pkgdir CACHE_DISABLE=true install

I don't know how exactly 'test' works, so I don't know which value is expected in $(CACHE_DISABLE)

On Tuesday 07 April 2009 22:06:14 Laurie Clark-Michalek wrote:

...
The pkg will not build if I don't have sudo enabled. It's because gtk-update-icon-cache is used during the make install, regardless of directory. See the error message below.

gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : Permission denied make: *** [install] Error 1 ==> ERROR: Build Failed.

2009/4/8 Dan Vratil

...
You don't need to use SUDO for `make install` as you have write privileges into $pkgdir folder.

On Tuesday 07 April 2009 21:55:38 Laurie Clark-Michalek wrote:

...
Hi,

I've been working on the splashy-creator package (updating it to

2.2),

...
...
and

...
had got it working, when I realised I had a potential problem. I

needed

...
...
to

...
use sudo in the pkgbuild, and so far, I have never seen it used in a package. Is this OK, and/or is there away to avoid it? Here is my package build for inspection:

# Contributor: Laurie Clark-Michalek
(dot)

...
...
us>

...
pkgname=splashy-creator pkgver=2.2 pkgrel=1 pkgdesc="A tool for creating Splashy themes." arch=('i686' 'x86_64') url="

http://www.nanolx.org/index.php?option=com_content&task=view&id=34

...
...
...
" license=('GPL3') depends=('sed' 'pygtk>=2.4' 'python>=2.4' 'splashy') makedepends=('sudo' 'patch') source=(http://nanolx.org/free/$pkgname-$pkgver.tar.bz2$pkgname.pa tch) md5sums=('615033a2cabab0b132ecc9aff2c07a7b' 'b8095120f36b5f2cc3b1704a7b2e32a6')

build() { cd $srcdir/$pkgname ./configure patch ./Makefile $srcdir/splashy-creator.patch sudo make DESTDIR=$pkgdir install || return 1 }

The patch is just a small one:

23c23 < @mkdir -p $(DESTDIR)/usr/usr/bin/ ---

> @mkdir -p $(DESTDIR)/usr/bin/

Thanks,

Laurie

P.S. This is the first time I've used patch, so is the .patch file

alright?

-- --------------------------------- Dan Vrátil progdan@progdansoft.com ICQ 249163429 Jabber progdan@jabber.cz Tel. +420 732 326 870

-- --------------------------------- Dan Vrátil progdan@progdansoft.com ICQ 249163429 Jabber progdan@jabber.cz Tel. +420 732 326 870

-- --------------------------------- Dan Vrátil progdan@progdansoft.com ICQ 249163429 Jabber progdan@jabber.cz Tel. +420 732 326 870

Angel Velásquez

7 Apr 7 Apr

8:46 p.m.

On Thu, Apr 9, 2009 at 4:13 PM, Dan Vratil wrote:

...

Oh rock me - I should take better look next time, of course it's there. I'm sorry Laurie.

Please don't do top -posting .. -- Angel Velásquez angvp @ irc.freenode.net Linux Counter: #359909

Dieter Plaetinck

8:40 p.m.

On Tue, 7 Apr 2009 20:29:41 +0000 Laurie Clark-Michalek wrote:

...

I was planning to use a little .install file:

post_install() { gtk-update-icon-cache -f /usr/share/icons/hicolor }

fwiw, you could have a look at the liferea package (.install file). it also does stuff like this. can maybe be interesting... It's in extra. Dieter

5519

Age (days ago)

5520

Last active (days ago)

List overview

Download

21 comments

9 participants

participants (9)

Angel Velásquez
Daenyth Blank
Dan Vratil
Dieter Plaetinck
Jan de Groot
Ju Liu
Laurie Clark-Michalek
Mathias Burén
Thomas Bächler