[aur-general] Review request for first AUR package
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 - -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hi, I've made a package for sic. This is my first package. I've tested it and I haven't noticed any issues. Please review it in case I've missed something. sic: http://tools.suckless.org/sic Package: http://nyuszika7h.cadoth.net/assets/aur/sic-1.2-1.src.tar.gz - - -- nyuszika7h - -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Homepage: http://nyuszika7h.cadoth.net/ Comment: Public key: http://bit.ly/1aXbBEh iQIcBAEBCgAGBQJSm3L+AAoJEMrMWwlOwAIGGm8P/0AKwkdAxRKKaZMVJcaNi4YP N0qIyzV0jxn5iGE4Bmspm7c6N3l+UAJt2yzMBMGU/kVvraOb+zVN3hm1UB8/XpY5 CRlQHuDbsrRk1ljuJK79/LOiBjofMDdHp32G3cuVQLOzNYz0m0lpZfo2ZBVqagQL SM+I75ePLg5AbgAyJT+X7/W4k0AtEJ9Fk8y3/6HREBZ4oP/ny1Ui0J/VFtc+G4Ds TDJ1JfPRfyILkyPdoX180JO7na6BqxawKIJKr9RwMtIOlL/erMS9C3h0B4vuDmoc idBZRrMSBS3/yjkP+6xaSZ/cu3FaOew6/z2i4q8hKCNPhraVoVk1nQlFOoAkYXcu PLY2YS8HJ3JqppwRr/2hEEvd/ORoYvV23/Ox1lDqSwB6utU9XYmtYhnvC7HOsaVh 8V+yXShcLDXnlz++h0XosenOfC+sBKdioBc0R8OtTHAqzvJxH41b9LTOskELQ9Fu z5LXJIRo4hb1yzEKJVJ1Xmy6vfbE48HDYG9Qqo539sK86w6oToZ2BwD/R9W35IjU wuGAMlM/R7bfok5MeGw+ldliApBbVGT13OVWn3C79tH40/89K+5VEPYyjIj0imwL vTA7kOSfmYvu/joQCTwRgWLoydL+EuOGUtEnB09BaMes/Z8VPs2iqB8jTbm5MMHw e7/o7tZmfKOTLaKRJBrm =Bhxd - -----END PGP SIGNATURE----- -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Homepage: http://nyuszika7h.cadoth.net/ Comment: Public key: http://bit.ly/1aXbBEh iQIcBAEBCgAGBQJSm3ZyAAoJEMrMWwlOwAIGCtAQAM1U48vtBPeb5rQZIph83Z/K ZlqsajDbUhKWcPIkvX/9PfNX50yohK3hqB/datqozSicwoKx6c9zsp/mhtwIvGVg aLF1NkZwDTHDGWBF3NAQeaNyiHGMADZMgA8VMY1AVWEzhqh9objNxUq7Asub5xG9 zhk6TxTCgNz3Un19D3NH8JrOmKITVYX5DUrPp3I1vQWP/V6Aysq+uh1WBVujM7Vq ao2Z9VsWNqMtYFgT0pdi0ik8viCBbudusJ3WwK+S+DDBfDBfk3fCU9jgZDAfbqBS j5ApJFcmuT61mHYvZoXVUV2ZDuwX+8zm76QW0FPiwAKDN44ApG6R9m1Qw7UwR68m gW7g6CXOUqBYXScX3342Fr9fqC61210fNOcMMDUw3yjUDV4K+FpxKYzRIomNFFsd 6/ql4H3YhiYkWgCrAKdubJ+fSnPl91TlSDCt9bdQ/C135xfUTSHjJDe5uGIcqkxQ 2wO5V6Wz3gZkOTF6VAZNibzXNzefIYWltbxIagrf6hO68+RdI/IArACUdnzp2fhi DKx3ndDbzd2yWg+vrvq/ZAjjyBiEW67aUQpl7D3hnKZeiOsN6HyCN1YYc49hvH8t UZ042uBnAEosHGfKa5E2N7FvsH9GqbMdfA6aTAW9+XfhF0Gu9I2Pb2o1C/9IvLe3 wgEq5BHiHU0yWRC2QXcV =jQ3j -----END PGP SIGNATURE-----
Please review it in case I've missed something.
You can drop the `pkgdir= #TODO` line completely. makepkg defines $pkgdir for you. [1] namcap emits several warnings. Run `namcap sic-1.2-1-x86_64.pkg.tar.xz` to see them. [1] https://www.archlinux.org/pacman/PKGBUILD.5.html#_build_function. --Jeremy
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On Sun, Dec 01, 2013 at 02:43:13PM -0500, Jeremy Audet wrote:
Please review it in case I've missed something.
You can drop the `pkgdir= #TODO` line completely. makepkg defines $pkgdir for you. [1]
namcap emits several warnings. Run `namcap sic-1.2-1-x86_64.pkg.tar.xz` to see them.
[1] https://www.archlinux.org/pacman/PKGBUILD.5.html#_build_function.
--Jeremy
It looks like I overlooked that, I accidentally left it in the PKGBUILD. I didn't even notice it was there, even though vim highlights "TODO". I'll check the namcap warnings soon. - -- nyuszika7h -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Homepage: http://nyuszika7h.cadoth.net/ Comment: Public key: http://bit.ly/1aXbBEh iQIcBAEBCgAGBQJSm5XCAAoJEMrMWwlOwAIGjN4P/R/2MX1/mj8d/xJey656H4fV 3A3eEYeypUvgSJTcBajVlW4Z1ao/0xvGZ28okmUx0d3HoD1FNvsiJEnZh8ZwSU3/ Xw7/EBxRPJyXC8rqSdLNkGSox+ey0+ONAfXfJt/quKe5H/0zFnfXInOkdUmick0y fOw3ux7C9fRhioSZQGIOUtV1j3pfsMYEqi9hPeYYPP0hhvXtUOeI0HTh892HWDZ+ c/1bfruRrRYCO6/ljJZBQ1ucxrsR6LGPRYOmK2MUXtiwixo+7L0wexSEggfn7Mt7 /OuCSZHF+mWiFhkzDDxgPNMDrvt5paNRMdoMI/GttSSK0O7YAIsPOzRS5g8TAe7g 4g3V6nyiTLw4iICixBz6sYX2qUweoLrKeJj8ds3GYfzkUJL2vYHOtE7HJLg86IPT V5FM0MPGDex8utQB9B5qv8eejM4vQWFSrM/WOYWH2Zgv0NHYbKRR/AVvjX1aj7/m owUxdh9JhIRsGUUR9E4NDOKb/FzryeYvrw0VRnCawG4MhYo7NKt1uCt7iPKokdEv zma++ZfT3YHr1MWFmOPSDGA4IuVDYd56lDr9w5WxZE0qIuqYw5mEPqcDmbn+AilW /7b/Kxh4OyFqK4RxumYgI6e6Jb8pPKQkeW5hwxkdp0O0fbiU22oBcG++1QRnTgTm eLcLCjKCDnCzc+TKQzm3 =qZyD -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On Sun, Dec 01, 2013 at 02:43:13PM -0500, Jeremy Audet wrote:
Please review it in case I've missed something.
You can drop the `pkgdir= #TODO` line completely. makepkg defines $pkgdir for you. [1]
namcap emits several warnings. Run `namcap sic-1.2-1-x86_64.pkg.tar.xz` to see them.
[1] https://www.archlinux.org/pacman/PKGBUILD.5.html#_build_function.
--Jeremy
Oh, of course, I got confused and forgot DESTDIR and PREFIX are two separate things. I've removed the pkgdir line, fixed the namcap warnings, and reuploaded the package now. Thanks for your help, is there anything else? - -- nyuszika7h -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Homepage: http://nyuszika7h.cadoth.net/ Comment: Public key: http://bit.ly/1aXbBEh iQIcBAEBCgAGBQJSm5gHAAoJEMrMWwlOwAIGa34QAKaYVNS4HDI0VNhL18x+M9LP Yh2TVxTwgyloacmWzx05YWAdL3Waf0SRgjKz4ULeaVVDWgpd8+v27hQ4Rn9dC/sI FOyBE9qNRZi9SKXTrr8g+nf1JgK/3rEC+dp4fzLrNWZI/4oGhva9TUjAN+aZMEOH KGA/tetmy+6UkWtfnBJ+mW2PujS6QJSJHLHOOokLUul0PTADDIeiypsO7gYPmuAh /3Mkmon0LMc0G1cLIHOx5UnPfoVC6A8GcngBNXIn0hmbBZtcYCWBMFqhJHndg9rY 04RwglPKFSJg5nhcnXJdGN1aiG91TfhAhj6wE4pd83AuQVcfFQNOVZj5/BU3XCi0 xx6iy4ApCUSMklEVYbptqx3HexUhYuvCBsMT/143P9fm/ev2F0E11ahID8F42htP DCio1f/hb5r3vhv+K4wvfzmtM1TYbfS3J5PLOwV3GUv9IrJRteOCENhbeUeFUPoA cAXIsTDKXS3MUBRLTpby40NGxVDRa2WGpqlj5SNJGjN6Yn9aowrLZBJVEVILiLez z7q3lDf11ONoFB32H1vmJMdv/3QlwFsgd5Lm510ef4USLoDpT7vYIqGBFy84eiWl DC1fMXW1KhSaZoFe9nicBCvp6l1f+eupU5H8GNRCX6hhF++i0WGmLQX6pvZTFE5t oufL2Io+QF/PORjIcNYp =XjNU -----END PGP SIGNATURE-----
I've removed the pkgdir line, fixed the namcap warnings, Great!
and reuploaded the package now. Is the new .tar.gz file available at the same location? [1] I'm still getting the exact same set of files.
Thanks for your help, Thank *you* for taking the time to email this list.
is there anything else? Yes. The current PKGBUILD [2] lists a maintainer and two contributors. It's polite to list all three of them in the new PKGBUILD as contributors.
[1] http://nyuszika7h.cadoth.net/assets/aur/sic-1.2-1.src.tar.gz [2] https://aur.archlinux.org/packages/si/sic/PKGBUILD --Jeremy
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On Sun, Dec 01, 2013 at 03:59:42PM -0500, Jeremy Audet wrote:
Is the new .tar.gz file available at the same location? [1] I'm still getting the exact same set of files.
I forgot to rebuild the source tarball. I've fixed that now.
Yes. The current PKGBUILD [2] lists a maintainer and two contributors. It's polite to list all three of them in the new PKGBUILD as contributors.
Oh, I didn't notice there's a package for sic in the AUR already. The wiki says not to create duplicate packages. Should I contact the current maintainer about it? (I've updated the PKGBUILD to list them as contributors.) - -- nyuszika7h -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Homepage: http://nyuszika7h.cadoth.net/ Comment: Public key: http://bit.ly/1aXbBEh iQIcBAEBCgAGBQJSm6dnAAoJEMrMWwlOwAIGUrEP/2VT5Mt9K74W6/RivxG4a6V1 rTkriBzJpmFwyeIu4Axb0Col+ivMpHT3lnP2WEKJ7eEoE4LJjgP4rS2kur0u7o3N fBErE+7fQIWkmkgJHXOG8xkSJbiWp1Vw6c2Z/mJNxfhpCg/h9GhDJBqrsgesXbGB MhYhZ2gzRb2ACR5/q369SUyODKvdQNWhwKHpGIdoG58YzguLgSQRk79aPD4ihTUq mXonR+xRFIhmDdSE8mREB0/isDlPrbudnA6+/W9ycPU+YldBunAivjMkvGHdqkgY zVgw4OoI/XeI6/Rbv1PM5q4TShf7A1JJqcjcpUqT57qatl2CWCo5sb2f7Rw47KRz cN6cj576LpApZWzSIhjHNmfIqFv0ap0i7u/S1J5MmgFg7ZnZf3jhojpVYqdiZ8By vSxj7bBt5B53ennS3DZ5K/0WPycGOewlC+Zm1U3PcXjhgQwQhP3rcdQk+B6hY8/d sgZCo4+TwYNQHUjQVg4j6oioxiq1EYN//QcPOGDbWr3DnRcf/37akJKgONoS3n/J 866F7L77oHa496QDvgfWfB+cyu4764re+NNooillN1reEMtDsp6ZGnNfhYMzBqSY TsKiP4q7EPXSHrnUBOZ7+ZzZoh4Dsc9WekKXce1OzwQaBSmU8TkZIP/MnMa5qBpX d+3Pu7PjokETBLAhn2LL =Vuyf -----END PGP SIGNATURE-----
On Sunday 01 December 2013 22:17:28 nyuszika7h wrote:
On Sun, Dec 01, 2013 at 03:59:42PM -0500, Jeremy Audet wrote:
Is the new .tar.gz file available at the same location? [1] I'm still getting the exact same set of files.
I forgot to rebuild the source tarball. I've fixed that now.
Yes. The current PKGBUILD [2] lists a maintainer and two contributors. It's polite to list all three of them in the new PKGBUILD as contributors.
Oh, I didn't notice there's a package for sic in the AUR already. The wiki says not to create duplicate packages. Should I contact the current maintainer about it? (I've updated the PKGBUILD to list them as contributors.)
The original package [1] is out-of-date. If you want to maintain the package you must contact with its current maintainer first via email and wait for a reply for a two week [1]. After this if he doens't reply you may send a disown request to this mailing list. However, if he reply that he will maintain this package you may suggest him your PKGBUILD. In this case YOU will be contributor. [1] https://aur.archlinux.org/packages/sic [2] https://wiki.archlinux.org/index.php/AUR#Other_requests -- С уважением, Е.Алексеев. Sincerely yours, E.Alekseev. e-mail: darkarcanis@mail.ru ICQ: 407-398-235 Jabber: arcanis@jabber.ru
participants (3)
-
Evgeniy Alekseev
-
Jeremy Audet
-
nyuszika7h