On 2021-06-18 14:35:24 (+0100), Morgan Adamiec via aur-general wrote:

Hey there!

I'm Morgan, Morganamilo in most places and I'd like to apply to become a Trusted User with dvzrv and kpcyrd's sponsorship.

I confirm my sponsorship. Let the discussion period begin! :) -- https://sleepmap.de

On 2021-06-18 14:35, Morgan Adamiec via aur-general wrote:

Hey there!

I'm Morgan, Morganamilo in most places and I'd like to apply to become a Trusted User with dvzrv and kpcyrd's sponsorship.

Hello, Morgan! Nice to meet you. :)

I've been an avid Arch user for the past 5 or so years. I started dipping my toes into the community with some wiki edits, bug reporting and submitted my first AUR package back in 2017.

I also love FOSS as a whole, I contribute to random projects here and there, participate where I can and just love the community aspect.

These days my main involvement with arch is pacman and the AUR.

I started contributing to pacman 3 years ago. Adding stricter pkgbuild linting and fixing a bug here or there. Fast forward to now and I'm one of the maintainers of pacman as well as maintaining the rust bindings for libalpm.

On the AUR side I co developed yay, developed paru and also have contributions in pretty much every current AUR helper.

I think that might get some stones thrown at you... ;) But I jest: You've put in a lot of great work and I appreciate not only your development of these tools but also your maintenance of their packages in the AUR/involvement with users.

So I pretty know the AUR/pacman/makepkg inside out.

I think this is an interesting conundrum, because it's clear that you *do* know this inside out, but there are relatively few packages to review on your account! What I see seems well-written and I'm confident in your capabilities of keeping up with everything. My only nitpick would be on a recent comment in the AUR [1]. I know it's mostly in jest but I think it's important that users *are* trusted (to a reasonable point, I'm not saying to take everything at their word...). I know there are the occasional... er... less-than-optimal users that do things like file deletion requests when their aur helper breaks or something, but it's important to keep a healthy community atmosphere. Many of the users are less technical and just need a gentle push in the right direction. And other users are great in providing insight/a second set of eyes. Again, I'm only *nitpicking*; I think you've been great!

Some other things I do in and around Arch are:

* I maintain a handful of AUR packages * I'm a moderator for the r/archlinux subreddit * I'm a (bit inactive) Bug wrangler

You make great bug reports! For example, https://bugs.archlinux.org/task/64208

* I also maintain a handful of pacman/AUR oriented rust/go libraries * I also go and bug AUR maintainers about broken pkgbuilds

I'm a big fan of rust, so a lot of the packages I wish to maintain are rust related. A lot of it is there in the repos already So I'd be looking to co maintain:

[...]

Github: https://github.com/Morganamilo AUR: https://aur.archlinux.org/account/Morganamilo Forums: https://bbs.archlinux.org/profile.php?id=113213

+1 on a great attitude.

Bugs: https://bugs.archlinux.org/user/26268 irc: Morganamilo

I'm looking forward to sinking my teeth into Arch even more. It's a great community and I've thoroughly enjoyed my time so far.

Morgan

Thanks for applying! [1] https://aur.archlinux.org/packages/discord-canary/#comment-811202

On 03/07/2021 09:35, Morgan Adamiec via aur-general wrote:

On 03/07/2021 04:03, Brett Cornwall via aur-general wrote:

...

Hello, Morgan! Nice to meet you. :)

Hi there, nice to see some one break the silence.

...

I think that might get some stones thrown at you... ;)

I was fearing I might catch a little bit of flak on that. But as long as I don't pull a cower and shove it in community I should be fine :)

Indeed. There's even a special exception rule that bans pacman wrappers from ever making it into the repos. 🎉 [2] [2] https://wiki.archlinux.org/title/AUR_Trusted_User_Guidelines#The_TU_and_the_...

...

But I jest: You've put in a lot of great work and I appreciate not only your development of these tools but also your maintenance of their packages in the AUR/involvement with users. I think this is an interesting conundrum, because it's clear that you *do* know this inside out, but there are relatively few packages to review on your account! What I see seems well-written and I'm confident in your capabilities of keeping up with everything.

Thanks. I do realize the amount of packages I maintain on the AUR is rather small. I blame every one else for beating me to the punch on things :P

Some notes on those you have: * https://aur.archlinux.org/packages/lib32-vk9-bin/ A user mentioned a 404, you should probably fix it * https://aur.archlinux.org/packages/pacdiffviewer/ You seem to have rewritten yaourt's pacdiffviewer, but included no documentation - in particular what it does over the original while requiring rust and a fixed version of pacman. * https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=paru The pacman -T lines (also for pacdiffviewer) looks pretty strange. I guess rust has no ifdefs.

...

My only nitpick would be on a recent comment in the AUR [1]. I know it's mostly in jest but I think it's important that users *are* trusted (to a reasonable point, I'm not saying to take everything at their word...). I know there are the occasional... er... less-than-optimal users that do things like file deletion requests when their aur helper breaks or something, but it's important to keep a healthy community atmosphere. Many of the users are less technical and just need a gentle push in the right direction. And other users are great in providing insight/a second set of eyes.

Again, I'm only *nitpicking*; I think you've been great!

Yeah it was meant in jest (good ol PEBCAK) but I'll try to avoid such comments in future. (I have however may been slightly peeved because paru was wrongly flagged out of date 3 times that day).

With some packages - usually very popular ones - it gets pretty egregious, to the point TUs have to step in and warn people. It's still a good idea to keep a cool head at all times. (I should tell myself that...) Alad

...

You make great bug reports! For example, https://bugs.archlinux.org/task/64208

Thanks, I absolutely hate bad bug reports so I try my best.

...

+1 on a great attitude. Thanks for applying!

Thanks for looking over my application!

On 03/07/2021 10:16, Morgan Adamiec via aur-general wrote:

On 03/07/2021 08:59, alad via aur-general wrote:

...

On 03/07/2021 09:35, Morgan Adamiec via aur-general wrote:

...

On 03/07/2021 04:03, Brett Cornwall via aur-general wrote:

...

Hello, Morgan! Nice to meet you. :) Hi there, nice to see some one break the silence.

...

I think that might get some stones thrown at you... ;) I was fearing I might catch a little bit of flak on that. But as long as I don't pull a cower and shove it in community I should be fine :) Indeed. There's even a special exception rule that bans pacman wrappers from ever making it into the repos. 🎉 [2]

[2] https://wiki.archlinux.org/title/AUR_Trusted_User_Guidelines#The_TU_and_the_...

...

...

But I jest: You've put in a lot of great work and I appreciate not only your development of these tools but also your maintenance of their packages in the AUR/involvement with users. I think this is an interesting conundrum, because it's clear that you *do* know this inside out, but there are relatively few packages to review on your account! What I see seems well-written and I'm confident in your capabilities of keeping up with everything.

Thanks. I do realize the amount of packages I maintain on the AUR is rather small. I blame every one else for beating me to the punch on things :P Some notes on those you have:

* https://aur.archlinux.org/packages/lib32-vk9-bin/

A user mentioned a 404, you should probably fix it The whole repo is gone. I still need to figure out where it went...

...

* https://aur.archlinux.org/packages/pacdiffviewer/

You seem to have rewritten yaourt's pacdiffviewer, but included no documentation - in particular what it does over the original while requiring rust and a fixed version of pacman. The name just happens to be the same as yaourts binary. It's not meant to be related. There's a --help page which is good enough really.

You mean the few lines in https://github.com/Morganamilo/pacdiffviewer/blob/master/src/config.rs Still no idea what distinguishes this project from say, pacdiff, but whatever I guess.

...

* https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=paru

The pacman -T lines (also for pacdiffviewer) looks pretty strange. I guess rust has no ifdefs. Sure there are ifdefs. This is how I'm saying what ifdefs are defined. This is the same as adding -Dpacman-git=true in configure.

But why has it to be part of the PKGBUILD? You're saying alpm has no defines for the version? Alad

...

...

...

My only nitpick would be on a recent comment in the AUR [1]. I know it's mostly in jest but I think it's important that users *are* trusted (to a reasonable point, I'm not saying to take everything at their word...). I know there are the occasional... er... less-than-optimal users that do things like file deletion requests when their aur helper breaks or something, but it's important to keep a healthy community atmosphere. Many of the users are less technical and just need a gentle push in the right direction. And other users are great in providing insight/a second set of eyes.

Again, I'm only *nitpicking*; I think you've been great!

Yeah it was meant in jest (good ol PEBCAK) but I'll try to avoid such comments in future. (I have however may been slightly peeved because paru was wrongly flagged out of date 3 times that day). With some packages - usually very popular ones - it gets pretty egregious, to the point TUs have to step in and warn people. It's still a good idea to keep a cool head at all times. (I should tell myself that...)

Alad

...

...

You make great bug reports! For example, https://bugs.archlinux.org/task/64208

Thanks, I absolutely hate bad bug reports so I try my best.

...

+1 on a great attitude. Thanks for applying! Thanks for looking over my application!

On 03/07/2021 10:26, alad via aur-general wrote:

On 03/07/2021 10:16, Morgan Adamiec via aur-general wrote:

...

On 03/07/2021 08:59, alad via aur-general wrote:

...

On 03/07/2021 09:35, Morgan Adamiec via aur-general wrote:

...

On 03/07/2021 04:03, Brett Cornwall via aur-general wrote:

...

Hello, Morgan! Nice to meet you. :) Hi there, nice to see some one break the silence.

...

I think that might get some stones thrown at you... ;) I was fearing I might catch a little bit of flak on that. But as long as I don't pull a cower and shove it in community I should be fine :) Indeed. There's even a special exception rule that bans pacman wrappers from ever making it into the repos. 🎉 [2]

[2] https://wiki.archlinux.org/title/AUR_Trusted_User_Guidelines#The_TU_and_the_...

...

...

But I jest: You've put in a lot of great work and I appreciate not only your development of these tools but also your maintenance of their packages in the AUR/involvement with users. I think this is an interesting conundrum, because it's clear that you *do* know this inside out, but there are relatively few packages to review on your account! What I see seems well-written and I'm confident in your capabilities of keeping up with everything.

Thanks. I do realize the amount of packages I maintain on the AUR is rather small. I blame every one else for beating me to the punch on things :P Some notes on those you have:

* https://aur.archlinux.org/packages/lib32-vk9-bin/

A user mentioned a 404, you should probably fix it The whole repo is gone. I still need to figure out where it went...

...

* https://aur.archlinux.org/packages/pacdiffviewer/

You seem to have rewritten yaourt's pacdiffviewer, but included no documentation - in particular what it does over the original while requiring rust and a fixed version of pacman. The name just happens to be the same as yaourts binary. It's not meant to be related. There's a --help page which is good enough really.

You mean the few lines in https://github.com/Morganamilo/pacdiffviewer/blob/master/src/config.rs

Yes: morganamilo@Octavia ~ % pacdiffviewer --help pacdiffviewer - pacfiles manager Usage: pacdiffviewer [OPTIONS] [targets]... Options: --action <action> automatically perform an action on each pacfile [possible values: view, skip, remove, overrwrite, quit] -a, --all manage all pacfiles instead of providing a selection menu --color=<color> specify when to enable color [default: auto] [possible values: never, auto, always] -c, --config <config> the pacman.conf to use -b, --dbpath <dbpath> the dbpath to use -d, --diffprog <diffprog> diff program to use [env: DIFFPROG=] -h, --help display this help menu --nosudoedit don't use sudo -e to open the editor under your user account -o, --output print pacfiles instead of managing them -r, --root <root> the root dir to use -u, --sudouser <sudouser> user to change to when editing files [env: SUDO_USER=] -V, --version display the version -v, --show hidden errors

Still no idea what distinguishes this project from say, pacdiff, but whatever I guess.

...

...

* https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=paru

The pacman -T lines (also for pacdiffviewer) looks pretty strange. I guess rust has no ifdefs. Sure there are ifdefs. This is how I'm saying what ifdefs are defined. This is the same as adding -Dpacman-git=true in configure.

But why has it to be part of the PKGBUILD? You're saying alpm has no defines for the version?

Nope there's no version defines. Eli was pushing for it though. And even if there were, there would need to be defines for is the -git version being used.

Alad

...

...

...

...

My only nitpick would be on a recent comment in the AUR [1]. I know it's mostly in jest but I think it's important that users *are* trusted (to a reasonable point, I'm not saying to take everything at their word...). I know there are the occasional... er... less-than-optimal users that do things like file deletion requests when their aur helper breaks or something, but it's important to keep a healthy community atmosphere. Many of the users are less technical and just need a gentle push in the right direction. And other users are great in providing insight/a second set of eyes.

Again, I'm only *nitpicking*; I think you've been great!

Yeah it was meant in jest (good ol PEBCAK) but I'll try to avoid such comments in future. (I have however may been slightly peeved because paru was wrongly flagged out of date 3 times that day). With some packages - usually very popular ones - it gets pretty egregious, to the point TUs have to step in and warn people. It's still a good idea to keep a cool head at all times. (I should tell myself that...)

Alad

...

...

You make great bug reports! For example, https://bugs.archlinux.org/task/64208

Thanks, I absolutely hate bad bug reports so I try my best.

...

+1 on a great attitude. Thanks for applying! Thanks for looking over my application!