Re: [aur-general] Proofreading request
On Mon, Aug 26, 2013 at 11:17:16PM +0200, Cl?ment Junca wrote:
Could someone have a look at the attached package, please ? It's my first AUR package written from scratch.
I made some changes to your PKGBUILD file. Here they are:
# Maintainer: Clément Junca
----------------------------------------
Date: Tue, 27 Aug 2013 13:02:17 -0400 From: teitelmanevan@gmail.com To: aur-general@archlinux.org Subject: Re: [aur-general] Proofreading request
# Using `install` to create directories is common. I believe `makepkg` sets # `umask` appropriately though so `makedir` should work. install -dm755 "$pkgdir/etc" install -dm755 "$pkgdir/usr/bin" install -dm755 "$pkgdir/usr/share/licenses/$pkgname" # Whitespace is nice.
# The `-D` switch is not necessary here. install -m755 feather "$pkgdir/usr/bin/feather" install -m644 feather.yaml.dist "$pkgdir/etc/feather.yaml" # You should put LICENSE in the `source` array. install -m644 ../../LICENSE "$pkgdir/usr/share/licenses/$pkgname/LICENSE" }
Why. Leave the -D switch and get rid of the extra step of making the dirs altogether. Much simpler and cleaner.
participants (2)
-
Doug Newgard
-
Evan Teitelman