Hi,
The qutebrowser package in community has been behind for quite a while, and unfortunately it fails to start on qt 5.11, so it would be nice to have it bumped before that happens.
I noticed that the install fails when bumping the version, due to adding a PREFIX variable instead of hardcoding /usr: https://github.com/qutebrowser/qutebrowser/pull/3844
Per the packaging standards here, this should be /usr/ instead of /usr/local, so I changed it back, and it seems to work properly again: https://wiki.archlinux.org/index.php/Arch_packaging_standards
Here is the finished patch. Let me know if anyone sees any issues, this is my first time working with arch packaging.
-Jay
I sent this email to the list before subscribing, please don't approve that one, as I resent it here.
On 21-05-18 16:41:27 -0700, Jay Kamat via aur-general wrote:
Here is the finished patch. Let me know if anyone sees any issues, this is my first time working with arch packaging.
The mailing list strips attachaments so your patch was probably swallowed. If you want, you can send it inline with the email.
Jagannathan Tiruvallur Eachambadi via aur-general writes:
The mailing list strips attachaments so your patch was probably swallowed. If you want, you can send it inline with the email.
Ah, I sent it as an inline mime attachment, but it was scrubbed anyway. Here is the patch fully inline:
--- qutebrowser/trunk/PKGBUILD | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qutebrowser/trunk/PKGBUILD b/qutebrowser/trunk/PKGBUILD index a08f22bcd62..f7e50461e14 100644 --- a/qutebrowser/trunk/PKGBUILD +++ b/qutebrowser/trunk/PKGBUILD @@ -2,7 +2,7 @@ # Contributor: Florian Bruhin (The Compiler) archlinux.org@the-compiler.org
pkgname=qutebrowser -pkgver=1.2.1 +pkgver=1.3.0 pkgrel=1 pkgdesc="A keyboard-driven, vim-like browser based on PyQt5" arch=("any") @@ -23,7 +23,7 @@ source=( "https://github.com/qutebrowser/qutebrowser/releases/download/v$pkgver/qutebr..." "https://github.com/qutebrowser/qutebrowser/releases/download/v$pkgver/qutebr...") validpgpkeys=("E04E560002401B8EF0E76F0A916EB0C8FD55A072") -sha256sums=('1ce6cf2634f06d3e715c53b50e4d042ba04aa39207ec318039a2a333e2d46beb' +sha256sums=('83cf51e934d37ac6fa686ba25878d63ba319b3e548f41f8ea2ee02d393313095' 'SKIP')
build() { @@ -34,5 +34,5 @@ build() {
package() { cd "$srcdir/$pkgname-$pkgver" - make -f misc/Makefile DESTDIR="$pkgdir" install + make -f misc/Makefile DESTDIR="$pkgdir" PREFIX="/usr" install } -- 2.14.2
Sorry for the awfully long delay.
The patch looks good to me. I haven't much time for Arch these days, so if any of the developers / trusted users is willing to apply and test it, please go ahead :)
Thanks!
On 05/22/2018 01:44 AM, Pierre Neidhardt via aur-general wrote:
Sorry for the awfully long delay.
The patch looks good to me. I haven't much time for Arch these days, so if any of the developers / trusted users is willing to apply and test it, please go ahead :)
Updating to use PREFIX=/usr...
checkpkg reports mostly clean, with three new files (plus setuptools versioned egg metadata): usr/lib/python3.6/site-packages/qutebrowser/javascript/global_wrapper.js usr/share/qutebrowser/userscripts/getbib usr/share/qutebrowser/userscripts/qute-keepass
Changelog looks fairly uncontroversial.
I'm not a big qutebrowser user, but it seems to work okay with my testing, plus I got some random #archlinux-offtopic person to test my package :D so I guess I'm comfortable pushing this update.
On Tue, May 22, 2018 at 02:55:33AM -0400, Eli Schwartz via aur-general wrote:
I'm not a big qutebrowser user, but it seems to work okay with my testing, plus I got some random #archlinux-offtopic person to test my package :D so I guess I'm comfortable pushing this update.
Can confirm some weirdo TU asked me about his package.
(Daily qutebrowser user, 1.3.0 works as intended.)
On Tue, May 22, 2018 at 02:55:33AM -0400, Eli Schwartz via aur-general wrote:
On 05/22/2018 01:44 AM, Pierre Neidhardt via aur-general wrote:
Sorry for the awfully long delay.
The patch looks good to me. I haven't much time for Arch these days, so if any of the developers / trusted users is willing to apply and test it, please go ahead :)
Updating to use PREFIX=/usr...
checkpkg reports mostly clean, with three new files (plus setuptools versioned egg metadata): usr/lib/python3.6/site-packages/qutebrowser/javascript/global_wrapper.js usr/share/qutebrowser/userscripts/getbib usr/share/qutebrowser/userscripts/qute-keepass
Changelog looks fairly uncontroversial.
I'm not a big qutebrowser user, but it seems to work okay with my testing, plus I got some random #archlinux-offtopic person to test my package :D so I guess I'm comfortable pushing this update.
qutebrowser maintainer/benevolent dictator/whatever here - looks good to me as well! :) Thanks Jay, Pierre and Eli!
I plan to release a v1.3.1 somewhen soon because while v1.3.0 doesn't outright crash with Qt 5.11, it still needs a few workarounds for annoying Qt bugs[1]... But until then, this definitely improves things.
[1] https://bugreports.qt.io/browse/QTBUG-68224 https://bugreports.qt.io/browse/QTBUG-68076
Florian
aur-general@lists.archlinux.org