[aur-general] [Review request] chrontel-wetab-rpm
Could somebody look at this package http://aur.archlinux.org/packages.php?ID=55619 and tell me if the PKGBUILD is okay and "standards compilant"?
On 08.01.2012 10:23, Markus Unterwaditzer wrote:
Could somebody look at this package
http://aur.archlinux.org/packages.php?ID=55619
and tell me if the PKGBUILD is okay and "standards compilant"?
You could replace the version in _rpmname with $pkgver so it's easier to update. Why is $arch x86_64 only and not i686? Does it fail to build on i686? Use install -Dm755 in package() when you are installing binaries. -D will create the target directory automatically so you don't need mkdir and -m755 will ensure that the permissions are correct.
cp "${srcdir}/${_rpmextractname}/resources/fw7036.bin" "${pkgdir}/lib/firmware/chrontel"
If you do something like this please either add a slash at the end so it's obvious that chrontel is a directory or just add the whole filename. Looks good otherwise. -- Florian Pritz
The architecture is x86_64, because the package itself is for the WeTab only, which is x86_64. I dont think it fails to build on i686, but there it would be useless. Thanks for the suggestions. Florian Pritz <bluewind@xinu.at> wrote: On 08.01.2012 10:23, Markus Unterwaditzer wrote:
Could somebody look at this package
http://aur.archlinux.org/packages.php?ID=55619
and tell me if the PKGBUILD is okay and "standards compilant"?
You could replace the version in _rpmname with $pkgver so it's easier to update. Why is $arch x86_64 only and not i686? Does it fail to build on i686? Use install -Dm755 in package() when you are installing binaries. -D will create the target directory automatically so you don't need mkdir and -m755 will ensure that the permissions are correct.
cp "${srcdir}/${_rpmextractname}/resources/fw7036.bin" "${pkgdir}/lib/firmware/chrontel"
If you do something like this please either add a slash at the end so it's obvious that chrontel is a directory or just add the whole filename. Looks good otherwise. -- Florian Pritz
The architecture is x86_64, because the package itself is for the WeTab only, which is x86_64. I dont think it fails to build on i686, but there it would be useless. Seems the wetab has a regular Intel Atom CPU so it is possible to run i686 on it too....
Am Sonntag, den 08.01.2012, 12:59 +0200 schrieb Jesse Juhani Jaara:
The architecture is x86_64, because the package itself is for the WeTab only, which is x86_64. I dont think it fails to build on i686, but there it would be useless. Seems the wetab has a regular Intel Atom CPU so it is possible to run i686 on it too....
Okay, whatever, i'll change it to x86_64 and i686
Am Sonntag, den 08.01.2012, 10:53 +0100 schrieb Florian Pritz:
On 08.01.2012 10:23, Markus Unterwaditzer wrote:
Could somebody look at this package
http://aur.archlinux.org/packages.php?ID=55619
and tell me if the PKGBUILD is okay and "standards compilant"?
You could replace the version in _rpmname with $pkgver so it's easier to update.
That's not that easy, because the download contains a hyphen instead of a underscore. So i use search and replace in my PKGBUILD now.
Why is $arch x86_64 only and not i686? Does it fail to build on i686?
Use install -Dm755 in package() when you are installing binaries. -D will create the target directory automatically so you don't need mkdir and -m755 will ensure that the permissions are correct.
Done.
cp "${srcdir}/${_rpmextractname}/resources/fw7036.bin" "${pkgdir}/lib/firmware/chrontel"
If you do something like this please either add a slash at the end so it's obvious that chrontel is a directory or just add the whole filename.
Done, i've replaced it with the install command.
participants (3)
-
Florian Pritz
-
Jesse Juhani Jaara
-
Markus Unterwaditzer