anbox-modules-dkms follows last working commit with the patch for 5.10

anbox-modules-dkms-git follows master branch with sed instead of a patch

https://wiki.archlinux.org/title/VCS_package_guidelines#Guidelines

“Suffix pkgname with -cvs, -svn, -hg, -darcs, -bzr, -git etc. unless the package fetches a specific release.”

The commit is in the PKGBUILD, as there are no releases. Said commit is 8148a162755bf5500a07cf41a65a02c8f3eb0af9"

`source=("git+https://github.com/choff/${_pkgname}.git#commit=8148a162755bf5500a07cf41a65a02c8f3eb0af9"`

Jan 15, 2022, 23:59 by env252525@gmail.com:
bbswitch-ati-dkms-git bbswitch-ati-git are split packages from the
same PKGBUILD. Of course they have same version.

darling is a duplicate of darling-git

yay follows upstream release, yay-git follows git branch

On Sat, Jan 15, 2022 at 9:57 PM <info@sick.codes> wrote:

Are you suggesting that every AUR package that is up to date with master where there is a -git package should be removed?

bbswitch-ati-dkms-git 0.8.5.gddbd243-1 3
bbswitch-ati-git 0.8.5.gddbd243-1

darling r3131.fa5348c8a-1
darling-git r3131.fa5348c8a-1

yay 11.1.0-1
yay-git 11.1.0.r0.gac13060-1

AUR rules https://wiki.archlinux.org/title/AUR_submission_guidelines#Rules_of_submission

“If it is currently maintained, changes can be submitted in a comment for the maintainer's attention. If it is unmaintained or the maintainer is unresponsive, the package can be adopted and updated as required. Do not create duplicate packages.“

It’s not a duplicate, it’s the pegged non-git package which uses a specific commit.

The package was merged because I removed myself from the mailing list and didn’t reply stating that the issues were resolved.

Why did you merge instead of suggesting changes?

Your package is git package that does not have -git sufflix.

And why do you want the package deleted so urgently?

It's not urgent.
Jan 15, 2022, 20:00 by env252525@gmail.com:

It is still a duplicate. There are no releases upstream. What's the point of having a non git version if it's just going to follow the latest git commit anyway?

Yes this matter was resolved. The package was merged. That is why anbox-modules-dkms should not exist.

On Sat, Jan 15, 2022 at 4:08 PM <info@sick.codes> wrote:

Hey eNV25,

Just because the non-git and git packages are on the same commit id does not mean the whole package should be wiped and its changelog, comments, AUR git history, and any other informative discussion should be deleted.

Once master is updated, the non-git will be out of date. That's what Out of Date is for.

# non-git
source=("git+https://github.com/choff/${_pkgname}.git#commit=8148a162755bf5500a07cf41a65a02c8f3eb0af9"

# git
source=("git+$url#branch=master")

As you know your original Merge Request reasons were already addressed.

Merge request: https://lists.archlinux.org/pipermail/aur-requests/2021-December/063155.html

Fixes: https://aur.archlinux.org/cgit/aur.git/commit/?h=anbox-modules-dkms&id=8790fadcc199ff742f1f21b1530675b8efca46b5

And: https://aur.archlinux.org/cgit/aur.git/commit/?h=anbox-modules-dkms&id=20a63e6c219e218edc49731cc21c2b3db1336e0b

- Removed the build function from previous 2017 maintainer
- Removed linux-headers from previous 2017 maintainer
- Removed /usr/lib/modules-load.d/ from previous 2017 maintainer

I didn't create the original pkgbuild, I simply revived it as-is, including it's git history for transparency. I didn't write the original PKGBUILD. I re-uploaded it with accurate git history so that anyone else can actually see the commit history of the package: https://aur.archlinux.org/cgit/aur.git/log/?h=anbox-modules-dkms

Given you are well aware I was actively maintaining the package, why would you submit a merge request instead of emailing me or submit a pull request?

I really don't understand your sudden urgency to remove the package from the AUR.

Why did you merge instead of suggesting changes?

And why do you want the package deleted so urgently?

In good faith,

Sick Codes of the Security Research Team @SickCodes

https://sick.codes
https://github.com/sickcodes
https://twitter.com/sickcodes
https://www.linkedin.com/in/sickcodes/
https://www.youtube.com/c/sickcodes
https://parler.com/profile/sickcodes/
https://hackerone.com/sickcodes
https://bugcrowd.com/sickcodes
https://hub.docker.com/r/sickcodes






Jan 15, 2022, 09:05 by env252525@gmail.com:

On Sat, Jan 15, 2022 at 11:10 AM <info@sick.codes> wrote:


This is a false deletion request, the maintainer knows this is a correct non-git dkms PKGBUILD


I don't think so.


https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=anbox-modules-dkms

The maintainer discussion between myself and the other maintainer is on https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=anbox-modules-dkms

I don’t we know what the current maintainer is trying to achieve here but the two packages are distinct.

1) I personally maintain the fork with the GitHub user


fine


2) I had already made env25 a co maintainer


And I made you a co-maintainer for anbox-modules-dkms-git

3) I am on the WayDroid dev team


It's not relevant who you are

2) this fork was created by myself and Choff


fine

3) the non-git is perfectly fine now


No it's not it's a duplicate of anbox-modules-dkms-git

4) eNV25 has already merged requested this, in a rush, for no apparent reason.


The TU ainola merged this. I submitted the request.

https://lists.archlinux.org/pipermail/aur-requests/2021-December/063155.html
https://lists.archlinux.org/pipermail/aur-requests/2021-December/063596.html


Please reject this merge & deletion request for the following reasons:


Please don't reject this deletion request.


And if possible please merge back the non-git repo comment history as you can clearly see

I have been maintaining the WIKI on Anbox to be accurate https://wiki.archlinux.org/title/Anbox


fine


In good faith,

Sick Codes of the Security Research Team @SickCodes

https://sick.codes
https://github.com/sickcodes
https://twitter.com/sickcodes
https://www.linkedin.com/in/sickcodes/
https://www.youtube.com/c/sickcodes
https://parler.com/profile/sickcodes/
https://hackerone.com/sickcodes
https://bugcrowd.com/sickcodes
https://hub.docker.com/r/sickcodes






Jan 14, 2022, 22:57 by notify@aur.archlinux.org:

eNV25 [1] filed a deletion request for anbox-modules-dkms [2]:

This package is a duplicate of anbox-modules-dkms-git.

I previously submitted a merge request from anbox-modules-dkms to
anbox-modules-dkms-git.

I maintain anbox-modules-dkms-git.

[1] https://aur.archlinux.org/account/eNV25/
[2] https://aur.archlinux.org/pkgbase/anbox-modules-dkms/