[aur-requests] [PRQ#7438] Merge Request for firefox-developer
awal [1] filed a request to merge firefox-developer [2] into firefox- dev [3]: Also I think the current name should be carry forwarded (firefox- developer) [1] https://aur.archlinux.org/account/awal/ [2] https://aur.archlinux.org/pkgbase/firefox-developer/ [3] https://aur.archlinux.org/pkgbase/firefox-dev/
Request #7438 has been rejected by ArchangeGabriel [1]: You apparently didn’t even asked the maintainer of firefox-developer about that move. Also, firefox-developer is the correct name, if anything it’s firefox-dev that should be merged in firefox-developer. That being said, both packages need some fixing, and auto-updating a VCS-like package is not a good practice, so I advise both maintainer to take a look at https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=firefox- nightly-fr for instance on how to handle firefox nightly builds (from whatever channel) in the most automatic and secure manner. Maybe you could work together as co-maintainer of firefox-developer. [1] https://aur.archlinux.org/account/ArchangeGabriel/
You apparently didn’t even asked the maintainer of firefox-developer about that move.
Apologies, I didn't realize I should be doing that first.
Also, firefox-developer is the correct name, if anything it’s firefox-dev that should be merged in firefox-developer.
That is indeed what I mentioned in the original request, but I figured it made more sense to have the outdated package get merged in the updated one and rename the new one instead.
That being said, both packages need some fixing, and auto-updating a VCS-like package is not a good practice
Agreed. I'll take a better look at your nightly PKGBUILD and see if I can co-maintain firefox-developer. Thanks. On Tue, Feb 7, 2017 at 6:20 PM <notify@aur.archlinux.org> wrote: Request #7438 has been rejected by ArchangeGabriel [1]: You apparently didn’t even asked the maintainer of firefox-developer about that move. Also, firefox-developer is the correct name, if anything it’s firefox-dev that should be merged in firefox-developer. That being said, both packages need some fixing, and auto-updating a VCS-like package is not a good practice, so I advise both maintainer to take a look at https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=firefox- nightly-fr for instance on how to handle firefox nightly builds (from whatever channel) in the most automatic and secure manner. Maybe you could work together as co-maintainer of firefox-developer. [1] https://aur.archlinux.org/account/ArchangeGabriel/
Le 07/02/2017 à 14:06, Awal Garg via aur-requests a écrit :
You apparently didn’t even asked the maintainer of firefox-developer about that move.
Apologies, I didn't realize I should be doing that first.
Contacting the maintainer before filing a request is a good practice, whether you ask his package to be orphaned, deleted or merged into another. ;) Maybe we should patch https://git.archlinux.org/aurweb.git/tree/web/template/pkgreq_form.php?h=v4.... to add that for merge and deletion (it’s already there for orphan).
Also, firefox-developer is the correct name, if anything it’s firefox-dev that should be merged in firefox-developer.
That is indeed what I mentioned in the original request, but I figured it made more sense to have the outdated package get merged in the updated one and rename the new one instead.
Since renaming = pushing a package with the new name + filing a request to merge the old one in the new one, this doesn’t make any sense.
That being said, both packages need some fixing, and auto-updating a VCS-like package is not a good practice
Agreed.
I'll take a better look at your nightly PKGBUILD and see if I can co-maintain firefox-developer. Thanks.
That’s OK. I’ll monitor the situation with firefox-aurora/firefox-dev/firefox-developer from now on, and will wait for things to be settled before accepting the current remaining requests. Regards, Bruno
On 2/7/17 8:56 AM, Bruno Pagani via aur-requests wrote:
Le 07/02/2017 à 14:06, Awal Garg via aur-requests a écrit :
Contacting the maintainer before filing a request is a good practice, whether you ask his package to be orphaned, deleted or merged into another. ;)
Maybe we should patch https://git.archlinux.org/aurweb.git/tree/web/template/pkgreq_form.php?h=v4.... to add that for merge and deletion (it’s already there for orphan).
Since renaming = pushing a package with the new name + filing a request to merge the old one in the new one, this doesn’t make any sense.
That’s OK. I’ll monitor the situation with firefox-aurora/firefox-dev/firefox-developer from now on, and will wait for things to be settled before accepting the current remaining requests.
Regards, Bruno
I'm here, I'll take a good at the firefox-nightly-fr pkgbuild and work to make the necessary adjustments. I've never particularly cared for how it just skips the sha512 sum on the tarball, but I also wasn't thrilled updating the sha512 every 1-180 minutes so I went with what was available to me at the time. I too agree that auto-updating a PKGBUILD without some form of vetting is a bad idea. Given the number of pkgs I maintain, I'd love to let things update automatically, but my experience in these past several years suggests that there is always something that fails in the process and that nothing but good old fashioned vim/diff can properly ensure a working and clean pkgbuild. As for co-maintaining... I'm not really ready for that, but thanks anyways. -- Thanks, John D Jones III UNIX Zealot; Perl Lover unixgeek1972@gmail.com jnbek1972@gmail.com http://zoelife4u.org/ Where Earth and Spirit Unite
Le 07/02/2017 à 18:01, John D Jones III a écrit :
I'm here, I'll take a good at the firefox-nightly-fr pkgbuild and work to make the necessary adjustments. I've never particularly cared for how it just skips the sha512 sum on the tarball, but I also wasn't thrilled updating the sha512 every 1-180 minutes so I went with what was available to me at the time.
I too agree that auto-updating a PKGBUILD without some form of vetting is a bad idea. Given the number of pkgs I maintain, I'd love to let things update automatically, but my experience in these past several years suggests that there is always something that fails in the process and that nothing but good old fashioned vim/diff can properly ensure a working and clean pkgbuild.
My point was more about the fact that updating VCS-like PKGBUILD just for the sake of updating them has no purpose (whether it’s auto or not doesn’t matter here). The only case where a VCS-like PKGBUILD needs to be updated is when there is a change in build process or dependencies. It’s even more true in the case of Firefox channels, since you can quite reliably when the next build is going to be, so they are plenty of way to handle this on the user-end side. But even for -git packages for instance there is no point, and I even would like this to be against the rules for several reasons, which is something that should be discussed amongst TUs. I was particularly scared by this one for instance: https://aur.archlinux.org/cgit/aur.git/log/?h=krita-git, just take a look at the full commit message of any “Updated version” commit…
As for co-maintaining... I'm not really ready for that, but thanks anyways.
That’s your call. As long as the PKGBUILD is fine for everyone and you update it in a timely manner, that’s OK. ;) Regards, Bruno
Le 07/02/2017 à 19:22, Bruno Pagani a écrit :
Le 07/02/2017 à 18:01, John D Jones III a écrit :
I'm here, I'll take a good at the firefox-nightly-fr pkgbuild and work to make the necessary adjustments. I've never particularly cared for how it just skips the sha512 sum on the tarball, but I also wasn't thrilled updating the sha512 every 1-180 minutes so I went with what was available to me at the time.
I too agree that auto-updating a PKGBUILD without some form of vetting is a bad idea. Given the number of pkgs I maintain, I'd love to let things update automatically, but my experience in these past several years suggests that there is always something that fails in the process and that nothing but good old fashioned vim/diff can properly ensure a working and clean pkgbuild. My point was more about the fact that updating VCS-like PKGBUILD just for the sake of updating them has no purpose (whether it’s auto or not doesn’t matter here). The only case where a VCS-like PKGBUILD needs to be updated is when there is a change in build process or dependencies. It’s even more true in the case of Firefox channels, since you can quite reliably when the next build is going to be, so they are plenty of way to handle this on the user-end side.
For further notice, this very discussion arose today on https://aur.archlinux.org/packages/firefox-nightly/, and a quite elegant solution was proposed: https://aur.archlinux.org/packages/changeling/ Bruno
Contacting the maintainer before filing a request is a good practice, whether you ask his package to be orphaned, deleted or merged into another. ;)
Well... when I see something freaky on the AUR, I don't usually bother consulting the maintainer before filing a deletion request. Their opinion doesn't matter when they violate the AUR guidelines. :) Anyway, maintainers get CC'ed so it's all good.
That’s OK. I’ll monitor the situation with firefox-aurora/firefox-dev/firefox-developer from now on, and will wait for things to be settled before accepting the current remaining requests.
Not sure why you need to wait. :) firefox-developer was uploaded I guess when Mozilla stopped officially calling it "aurora"? So their respective maintainers should figure it out between them, while we spectators assume good faith. However, firefox-dev is a straight-up rules violation serving no purpose. I don't see much good faith there, and even ignorance of the rules doesn't justify keeping it up. It also has highly suspicious undertones of "hostile takeover", although I am not sure why anyone might care that much... the deletion request for firefox-developer kinda triggered me. -- Eli Schwartz
Le 07/02/2017 à 19:32, Eli Schwartz via aur-requests a écrit :
Contacting the maintainer before filing a request is a good practice, whether you ask his package to be orphaned, deleted or merged into another. ;) Well... when I see something freaky on the AUR, I don't usually bother consulting the maintainer before filing a deletion request. Their opinion doesn't matter when they violate the AUR guidelines. :)
Yes, I hesitated a lot to add more around that, but decided to keep it concise. Indeed, when there is a matter of rules violation, and especially when the maintainer was already warned about that but decided to keep going (YKWIM), this can be skipped.
Anyway, maintainers get CC'ed so it's all good.
Yes, but as a maintainer I prefer being reached about it before receiving a PRQ require my package to be deleted.
That’s OK. I’ll monitor the situation with firefox-aurora/firefox-dev/firefox-developer from now on, and will wait for things to be settled before accepting the current remaining requests. Not sure why you need to wait. :)
On firefox-aurora side, I’m waiting for the pkgdesc of firefox-developer to be updated in order to mention it’s now also Aurora (see below), and on firefox-dev side I’m waiting for firefox-developer to be updated, especially in a way that <aurhelper> -S firefox-developer always provides the latest binary of that branch.
firefox-developer was uploaded I guess when Mozilla stopped officially calling it "aurora"? So their respective maintainers should figure it out between them, while we spectators assume good faith.
No, Firefox Developer had an independent existence from Aurora since its creation in 2015 and until two weeks ago, when Aurora was removed in favour of the former. Note that on Android for instance Firefox Aurora does still exist, so people might still be used to that name.
However, firefox-dev is a straight-up rules violation serving no purpose. I don't see much good faith there, and even ignorance of the rules doesn't justify keeping it up. It also has highly suspicious undertones of "hostile takeover", although I am not sure why anyone might care that much... the deletion request for firefox-developer kinda triggered me.
I definitively agree with you, and firefox-dev should never have been updated while denvit would have had to wait for jnbek to update its package. But the fact is firefox-developer is severely outdated (pulseaudio deps should be here for a while for instance), and while jnbek isn’t inactive and answered he wanted to keep this package, it has not yet been updated, while firefox-dev is working almost OK. Regards, Bruno
and while
jnbek isn’t inactive and answered he wanted to keep this package, it has not yet been updated, while firefox-dev is working almost OK.
Regards, Bruno
I should probably apologize for my much slower response time. I had two major spinal surgeries in 2015, this last one in December was quite a bit more painful than was expected. That said, I haven't been keeping up with my email anywhere near my usual everyday perusal. As stated in my previous email, I do try to get to out of date requests and 'hey this thing is broken' comments/emails as quickly as possible, I apologize for not notifying everyone much sooner as to the state of my maintainership. Right now, I am specifically focusing on my most popular and/or most actively developed pkgbuilds to keep them up to date. I did drop the ball with firefox-developer, knowing that updates occur sometimes in a matter of minutes and I will endeavor to prevent any further interruptions between the development process and pkgbuild updates. Of note, I did get the version updated last night and it should be working fine, if this is not the case, please let me know. Now, Bruno: What about the pulseaudio dependencies? -- Thanks, John D Jones III UNIX Zealot; Perl Lover unixgeek1972@gmail.com jnbek1972@gmail.com http://zoelife4u.org/ Where Earth and Spirit Unite
Le 08/02/2017 à 16:53, John D Jones III a écrit :
and while
jnbek isn’t inactive and answered he wanted to keep this package, it has not yet been updated, while firefox-dev is working almost OK.
Regards, Bruno
I should probably apologize for my much slower response time. I had two major spinal surgeries in 2015, this last one in December was quite a bit more painful than was expected. That said, I haven't been keeping up with my email anywhere near my usual everyday perusal. As stated in my previous email, I do try to get to out of date requests and 'hey this thing is broken' comments/emails as quickly as possible, I apologize for not notifying everyone much sooner as to the state of my maintainership. Right now, I am specifically focusing on my most popular and/or most actively developed pkgbuilds to keep them up to date. I did drop the ball with firefox-developer, knowing that updates occur sometimes in a matter of minutes and I will endeavor to prevent any further interruptions between the development process and pkgbuild updates. Of note, I did get the version updated last night and it should be working fine, if this is not the case, please let me know.
Sure, I understand your reasons. But do not hesitate to eventually state them on the package page, and if you lack time to care about some packages there is no shame in orphaning them or accepting comaintainers. ;)
Now, Bruno: What about the pulseaudio dependencies?
Try to play a video or any sound in Firefox without having pulseaudio installed, and tell me what happen. But I’m giving you the answer right away: a nice scroll notification telling you that pulseaudio is required to actually play sound in Firefox. So this should be added as an optional dependency (I, for one, live OK without sound in my browser, and prefer that above installing pulseaudio), just like ffmpeg is for h264 playback support. Note that Firefox didn’t dropped support for ALSA altogether, but it’s a compile time option off by default, so not in official mozilla builds. Also, regarding the PKGBUILD update, things have become even more simple, because the new build process (responsible for the missing checksum) added PGP sigs to the tarball itself. So checksums can be skipped altogether. Please find attached (I’m still unsure whether the list accept attachment, so if there is nothing just tell me) a new version that you can use, which will work without the checksum (but doesn’t work just now, see below for reason and a fix). When comparing with your package, the change are the following: – added all the known optdeps ; – proper handling of different sources for different CARCH (the way you do it currently is wrong) ; – make use of PGP sigs (note that at the moment this doesn’t work since the sig doesn’t match, but it works if you change the domain part of the url from https://download-installer.cdn.mozilla.net/ to https://ftp.mozilla.org/pub/firefox/nightly/latest-mozilla-aurora/) ; – make use of system hyphen and hunspell ; – install more icons to hicolor. Cheers, Bruno
firefox-developer was uploaded I guess when Mozilla stopped officially calling it "aurora"? So their respective maintainers should figure it out between them, while we spectators assume good faith.
Well, as far as I know, the Firefox Developer package differs for vanilla Aurora in that it includes a number of tools for Web Development that may not be available with Aurora Builds https://www.mozilla.org/en-US/firefox/developer/ for reference, well, actually I stand corrected, it seems they've shifted the Aurora channel to only support Android builds, though it might still be possible to run it on a Desktop? I'm not sure, I never used the Aurora build. I took over Firefox Developer when I discovered it's existence. I took the AUR v3 PKGBUILD and updated it and uploaded it to AUR v4. I presume that means that it was an orphaned pkg on the v3 AUR, so how that came to be initially vs Aurora, I don't actually know. I do attempt to update the versions within a few days of it being marked out of date or a comment comes in, though life happens and sometimes it takes an extra day or two for me to get around to it. Anyways, all that said, when I get off work, I'll first, update it to the latest version, then look into making it a bit more capable of checking it's own sha512 sums similar to the nightly-fr pkgbuild after that. I appreciate all the feedback about my pkgbuild, it helps me to feel like I really am making a contribution, albeit small, to the Open Source and Arch Linux communities. -- Thanks, John D Jones III UNIX Zealot; Perl Lover unixgeek1972@gmail.com jnbek1972@gmail.com http://zoelife4u.org/ Where Earth and Spirit Unite
Le 07/02/2017 à 20:04, John D Jones III via aur-requests a écrit :
firefox-developer was uploaded I guess when Mozilla stopped officially calling it "aurora"? So their respective maintainers should figure it out between them, while we spectators assume good faith.
Well, as far as I know, the Firefox Developer package differs for vanilla Aurora in that it includes a number of tools for Web Development that may not be available with Aurora Builds https://www.mozilla.org/en-US/firefox/developer/ for reference, well, actually I stand corrected, it seems they've shifted the Aurora channel to only support Android builds, though it might still be possible to run it on a Desktop? I'm not sure, I never used the Aurora build. I took over Firefox Developer when I discovered it's existence. I took the AUR v3 PKGBUILD and updated it and uploaded it to AUR v4. I presume that means that it was an orphaned pkg on the v3 AUR, so how that came to be initially vs Aurora, I don't actually know.
I think our emails crossed each others… But this makes me realize I’ve made a mistake, Firefox Developer started in November 2014 and not 2015. Time pass. For future reference, they intend to make the developer tools a system addon FWIR.
I do attempt to update the versions within a few days of it being marked out of date or a comment comes in, though life happens and sometimes it takes an extra day or two for me to get around to it. Anyways, all that said, when I get off work, I'll first, update it to the latest version, then look into making it a bit more capable of checking it's own sha512 sums similar to the nightly-fr pkgbuild after that.
I appreciate all the feedback about my pkgbuild, it helps me to feel like I really am making a contribution, albeit small, to the Open Source and Arch Linux communities.
I’ve tailored firefox-nightly-fr PKGBUILD for use in firefox-developer, I’ve joined it (+updated .desktop file) to this email. It won’t work for now since the checksums are not online, but those should be back tomorrow. Don’t hesitate to ask if they are things you don’t understand in my PKGBUILD. ;) Cheers, Bruno
participants (5)
-
Awal Garg
-
Bruno Pagani
-
Eli Schwartz
-
John D Jones III
-
notify@aur.archlinux.org